Skip to content
Permalink
Browse files
Web Inspector: Styles Redesign: Inline widgets don't hide when starti…
…ng editing by tabbing from property name

https://bugs.webkit.org/show_bug.cgi?id=178638

Reviewed by Joseph Pecoraro.

* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
which displayed inline swatches. Display inline swatches only after blur event on the property value.


Canonical link: https://commits.webkit.org/194863@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
NV committed Oct 24, 2017
1 parent f1507e1 commit 3a7e5464bf816f919679b9c81d13ad7737658e9d
Showing with 13 additions and 1 deletion.
  1. +12 −0 Source/WebInspectorUI/ChangeLog
  2. +1 −1 Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
@@ -1,3 +1,15 @@
2017-10-23 Nikita Vasilyev <nvasilyev@apple.com>

Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
https://bugs.webkit.org/show_bug.cgi?id=178638

Reviewed by Joseph Pecoraro.

* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
which displayed inline swatches. Display inline swatches only after blur event on the property value.

2017-10-23 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: Please support HAR Export for network traffic
@@ -235,7 +235,7 @@ WI.SpreadsheetStyleProperty = class SpreadsheetStyleProperty extends WI.Object
{
if (textField.value.trim() === "")
this._remove();
else
else if (textField === this._valueTextField)
this._renderValue(this._valueElement.textContent);
}

0 comments on commit 3a7e546

Please sign in to comment.