Skip to content
Permalink
Browse files
2009-01-16 Dmitry Titov <dimich@chromium.org>
        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=23394
        Remove unnecessary calls to setDeferringTimers().

        Use of this function was obsoleted by better handling of EINTR.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.


Canonical link: https://commits.webkit.org/32187@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Alp Toker committed Jan 16, 2009
1 parent b321fb5 commit 3ace0a836b87587b257a81aa0e14dad68d0fcf59
Showing with 13 additions and 3 deletions.
  1. +12 −0 WebCore/ChangeLog
  2. +1 −3 WebCore/platform/network/curl/ResourceHandleManager.cpp
@@ -1,3 +1,15 @@
2009-01-16 Dmitry Titov <dimich@chromium.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=23394
Remove unnecessary calls to setDeferringTimers().

Use of this function was obsoleted by better handling of EINTR.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.

2009-01-16 David Hyatt <hyatt@apple.com>

Fix badness with the cursor CSS property. For all links and form controls, resetting to a value of auto
@@ -264,8 +264,7 @@ void ResourceHandleManager::downloadTimerCallback(Timer<ResourceHandleManager>*
timeout.tv_sec = 0;
timeout.tv_usec = selectTimeoutMS * 1000; // select waits microseconds

// Temporarily disable timers since signals may interrupt select(), raising EINTR errors on some platforms
setDeferringTimers(true);
// Retry 'select' if it was interrupted by a process signal.
int rc = 0;
do {
FD_ZERO(&fdread);
@@ -278,7 +277,6 @@ void ResourceHandleManager::downloadTimerCallback(Timer<ResourceHandleManager>*
if (maxfd >= 0)
rc = ::select(maxfd + 1, &fdread, &fdwrite, &fdexcep, &timeout);
} while (rc == -1 && errno == EINTR);
setDeferringTimers(false);

if (-1 == rc) {
#ifndef NDEBUG

0 comments on commit 3ace0a8

Please sign in to comment.