From 3b541328a03cb3f83c75e69c9c5b480b3a07dc47 Mon Sep 17 00:00:00 2001 From: Miguel Gomez Date: Tue, 19 Dec 2017 07:59:16 +0000 Subject: [PATCH] Merge r224671 - [GTK][WPE] CoordinatedGraphicsLayer::setNeedsDisplayInRect() converts FloatRect to IntRect erroneously https://bugs.webkit.org/show_bug.cgi?id=179476 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reviewed by Žan Doberšek. Convert the passed FloatRect into an IntRect using enclosingIntRect(), so we are guaranteed that the rectangle to paint fits into the buffer that the backingStore will allocate. No behaviour change. * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect): --- Source/WebCore/ChangeLog | 15 +++++++++++++++ .../coordinated/CoordinatedGraphicsLayer.cpp | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 9cbd4da5b809..34262726eefe 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,18 @@ +2017-11-10 Miguel Gomez + + [GTK][WPE] CoordinatedGraphicsLayer::setNeedsDisplayInRect() converts FloatRect to IntRect erroneously + https://bugs.webkit.org/show_bug.cgi?id=179476 + + Reviewed by Žan Doberšek. + + Convert the passed FloatRect into an IntRect using enclosingIntRect(), so we are guaranteed that + the rectangle to paint fits into the buffer that the backingStore will allocate. + + No behaviour change. + + * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: + (WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect): + 2017-12-18 Zalan Bujtas [SVG] Detach list wrappers before resetting the base value. diff --git a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp index 022767bb0bf5..5522a3d12bc5 100644 --- a/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp +++ b/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp @@ -532,7 +532,7 @@ void CoordinatedGraphicsLayer::setNeedsDisplay() void CoordinatedGraphicsLayer::setNeedsDisplayInRect(const FloatRect& rect, ShouldClipToLayer) { if (m_mainBackingStore) - m_mainBackingStore->invalidate(IntRect(rect)); + m_mainBackingStore->invalidate(enclosingIntRect(rect)); didChangeLayerState();