Skip to content
Permalink
Browse files
Remove some Mavericks guards in ServicesOverlayController
https://bugs.webkit.org/show_bug.cgi?id=152238

Reviewed by Darin Adler.

* page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::selectionRectsDidChange): Deleted.
(WebCore::ServicesOverlayController::selectedTelephoneNumberRangesChanged): Deleted.
The whole file is already PLATFORM(MAC) guarded, and the 10.9 guards
are no longer necessary.


Canonical link: https://commits.webkit.org/170369@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@194047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
hortont424 committed Dec 14, 2015
1 parent 3332d12 commit 3be84a6d33d164bae417031a8aafe8f03607bb81
Showing with 13 additions and 8 deletions.
  1. +13 −0 Source/WebCore/ChangeLog
  2. +0 −8 Source/WebCore/page/mac/ServicesOverlayController.mm
@@ -1,3 +1,16 @@
2015-12-14 Tim Horton <timothy_horton@apple.com>

Remove some Mavericks guards in ServicesOverlayController
https://bugs.webkit.org/show_bug.cgi?id=152238

Reviewed by Darin Adler.

* page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::selectionRectsDidChange): Deleted.
(WebCore::ServicesOverlayController::selectedTelephoneNumberRangesChanged): Deleted.
The whole file is already PLATFORM(MAC) guarded, and the 10.9 guards
are no longer necessary.

2015-12-14 Daniel Bates <dabates@apple.com>

[iOS] DOM click event may not be dispatched when page has :active style and <input type="search">
@@ -366,7 +366,6 @@ static void compactRectsWithGapRects(Vector<LayoutRect>& rects, const Vector<Gap

void ServicesOverlayController::selectionRectsDidChange(const Vector<LayoutRect>& rects, const Vector<GapRects>& gapRects, bool isTextOnly)
{
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1090
m_currentSelectionRects = rects;
m_isTextOnly = isTextOnly;

@@ -379,19 +378,12 @@ static void compactRectsWithGapRects(Vector<LayoutRect>& rects, const Vector<Gap

LOG(Services, "ServicesOverlayController - Selection rects changed - Now have %lu\n", rects.size());
invalidateHighlightsOfType(Highlight::SelectionType);
#else
UNUSED_PARAM(rects);
UNUSED_PARAM(gapRects);
UNUSED_PARAM(isTextOnly);
#endif
}

void ServicesOverlayController::selectedTelephoneNumberRangesChanged()
{
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1090
LOG(Services, "ServicesOverlayController - Telephone number ranges changed\n");
invalidateHighlightsOfType(Highlight::TelephoneNumberType);
#endif
}

void ServicesOverlayController::invalidateHighlightsOfType(Highlight::Type type)

0 comments on commit 3be84a6

Please sign in to comment.