Skip to content
Permalink
Browse files
Make input placeholder line-height declaration !important
https://bugs.webkit.org/show_bug.cgi?id=240225

Reviewed by Tim Nguyen.

Source/WebCore:

This is the same the changes made in chromium at
https://chromium-review.googlesource.com/c/chromium/src/+/3594234
and Firefox change at
https://phabricator.services.mozilla.com/D116907

* css/html.css:
(input::placeholder):

LayoutTests:

Unskip the test that passes.
* TestExpectations:

Canonical link: https://commits.webkit.org/250414@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ziransun committed May 9, 2022
1 parent 0f060b5 commit 3c4d68171b6e2a1aec932e5d34020429fea031b7
Showing 4 changed files with 26 additions and 2 deletions.
@@ -1,3 +1,13 @@
2022-05-09 Ziran Sun <zsun@igalia.com>

Make input placeholder line-height declaration !important
https://bugs.webkit.org/show_bug.cgi?id=240225

Reviewed by Tim Nguyen.

Unskip the test that passes.
* TestExpectations:

2022-05-09 Antoine Quint <graouts@apple.com>

REGRESSION (r291817): NativeImage passed to RemoteResourceCacheProxy::recordNativeImageUse may be null
@@ -662,7 +662,6 @@ imported/w3c/web-platform-tests/html/browsers/windows/iframe-cross-origin-print.
imported/w3c/web-platform-tests/html/editing/editing-0/spelling-and-grammar-checking/spelling-markers-008.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/editing/editing-0/spelling-and-grammar-checking/spelling-markers-010.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/bindings/the-select-element-0/option-label.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/input-placeholder-line-height.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/lists/li-type-unsupported-lower-alpha.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/lists/li-type-unsupported-lower-roman.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/lists/li-type-unsupported-upper-alpha.html [ ImageOnlyFailure ]
@@ -1,3 +1,18 @@
2022-05-09 Ziran Sun <zsun@igalia.com>

Make input placeholder line-height declaration !important
https://bugs.webkit.org/show_bug.cgi?id=240225

Reviewed by Tim Nguyen.

This is the same the changes made in chromium at
https://chromium-review.googlesource.com/c/chromium/src/+/3594234
and Firefox change at
https://phabricator.services.mozilla.com/D116907

* css/html.css:
(input::placeholder):

2022-05-09 Antoine Quint <graouts@apple.com>

REGRESSION (r291817): NativeImage passed to RemoteResourceCacheProxy::recordNativeImageUse may be null
@@ -768,7 +768,7 @@ input::placeholder {
white-space: pre;
word-wrap: normal;
overflow: hidden;
line-height: initial;
line-height: initial !important;
}

input:is([type="hidden"], [type="image"], [type="file"]) {

0 comments on commit 3c4d681

Please sign in to comment.