Skip to content
Permalink
Browse files
Make dragging off a tab in Safari with a docked Inspector reattach th…
…e Inspector.

https://webkit.org/b/115832
rdar://problem/13605661

Reviewed by Benjamin Poulain.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.


Canonical link: https://commits.webkit.org/134264@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
xeenon committed May 9, 2013
1 parent d60b56f commit 3c5ecbcb9865ef566f1dc82d104b74cf50f85664
Showing with 22 additions and 0 deletions.
  1. +14 −0 Source/WebKit2/ChangeLog
  2. +8 −0 Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm
@@ -1,3 +1,17 @@
2013-05-09 Timothy Hatcher <timothy@apple.com>

Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.

https://webkit.org/b/115832
rdar://problem/13605661

Reviewed by Benjamin Poulain.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.

2013-05-08 Anders Carlsson <andersca@apple.com>

Fix a typo in a comment.
@@ -473,6 +473,14 @@ static unsigned long long exceededDatabaseQuota(WKPageRef, WKFrameRef, WKSecurit

void WebInspectorProxy::platformBringToFront()
{
// If the Web Inspector is no longer in the same window as the inspected view,
// then we need to reopen the Inspector to get it attached to the right window.
// This can happen when dragging tabs to another window in Safari.
if (m_isAttached && m_inspectorView.get().window != m_page->wkView().window) {
platformOpen();
return;
}

// FIXME <rdar://problem/10937688>: this will not bring a background tab in Safari to the front, only its window.
[m_inspectorView.get().window makeKeyAndOrderFront:nil];
[m_inspectorView.get().window makeFirstResponder:m_inspectorView.get()];

0 comments on commit 3c5ecbc

Please sign in to comment.