Skip to content
Permalink
Browse files
2010-01-04 Yongjun Zhang <yongjun.zhang@nokia.com>
        Reviewed by Laszlo Gombos.

        https://bugs.webkit.org/show_bug.cgi?id=29048
        [Qt] make RenderStyle.h compile in winscw compiler.

        Change compareEqual to a macro in Winscw compiler to get around "illegal operand"
        error when compareEqual is defined as template.

        The compiler bug is reported at:
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447

        * rendering/style/RenderStyle.h:

Canonical link: https://commits.webkit.org/44146@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Jan 4, 2010
1 parent 02de67e commit 3e37b5792b2a6b422c2a7a28b7624d2bf7da3d07
Showing 2 changed files with 19 additions and 0 deletions.
@@ -1,3 +1,18 @@
2010-01-04 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=29048
[Qt] make RenderStyle.h compile in winscw compiler.

Change compareEqual to a macro in Winscw compiler to get around "illegal operand"
error when compareEqual is defined as template.

The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447

* rendering/style/RenderStyle.h:

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Hausmann.
@@ -89,7 +89,11 @@
#include "BindingURI.h"
#endif

#if COMPILER(WINSCW)
#define compareEqual(t, u) ((t) == (u))
#else
template<typename T, typename U> inline bool compareEqual(const T& t, const U& u) { return t == static_cast<T>(u); }
#endif

#define SET_VAR(group, variable, value) \
if (!compareEqual(group->variable, value)) \

0 comments on commit 3e37b57

Please sign in to comment.