Skip to content
Permalink
Browse files
Web Inspector: Network Table: activity is not marked as a previous se…
…ssion when the Network Tab is not selected

https://bugs.webkit.org/show_bug.cgi?id=240846

Reviewed by Patrick Angle.

* Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._mainResourceDidChange):
(WI.NetworkTableContentView.prototype._entryForResource):
Also mark `WI.Resource` that haven't yet been inserted into the `WI.Table` when navigating the main
resource. Use this when generating an entry for that `WI.Resource` for the first time, instead of
always assuming that the `WI.Resource` is part of the current session.

Canonical link: https://commits.webkit.org/250902@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dcrousso committed May 24, 2022
1 parent d323be6 commit 3e38a86c87700e079d7059b2761de68f23428dfc
Showing 1 changed file with 6 additions and 1 deletion.
@@ -1653,6 +1653,9 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
} else {
for (let entry of collection.entries)
entry.currentSession = false;

for (let resource of collection.pendingInsertions)
resource[WI.NetworkTableContentView._currentSessionSymbol] = false;
}
}

@@ -1904,7 +1907,7 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
remoteAddress: resource.displayRemoteAddress,
connectionIdentifier: resource.connectionIdentifier,
startTime: resource.firstTimestamp,
currentSession: true,
currentSession: resource[WI.NetworkTableContentView._currentSessionSymbol] ?? true,
};
}

@@ -2533,3 +2536,5 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
this._transitioningPageTarget = true;
}
};

WI.NetworkTableContentView._currentSessionSymbol = Symbol("current-session");

0 comments on commit 3e38a86

Please sign in to comment.