Skip to content
Permalink
Browse files
Activate Cache API by default
https://bugs.webkit.org/show_bug.cgi?id=178186

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-16
Reviewed by Chris Dumez.

Source/WebKit:

* Shared/WebPreferencesDefinitions.h:

Tools:

Removing explicit activation of cache api.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setCacheAPIEnabled): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:

Canonical link: https://commits.webkit.org/194577@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youennf authored and webkit-commit-queue committed Oct 16, 2017
1 parent f767510 commit 3eb5fe038c08ae5a899a3581c848a89162c26b76
@@ -1,3 +1,12 @@
2017-10-16 Youenn Fablet <youenn@apple.com>

Activate Cache API by default
https://bugs.webkit.org/show_bug.cgi?id=178186

Reviewed by Chris Dumez.

* Shared/WebPreferencesDefinitions.h:

2017-10-16 Sam Weinig <sam@webkit.org>

[Settings] Remove all custom code from Settings.h/cpp
@@ -374,7 +374,7 @@

#define FOR_EACH_WEBKIT_EXPERIMENTAL_FEATURE_PREFERENCE(macro) \
macro(AsyncFrameScrollingEnabled, asyncFrameScrollingEnabled, Bool, bool, false, "Async Frame Scrolling", "Perform frame scrolling in a dedicated thread or process") \
macro(CacheAPIEnabled, cacheAPIEnabled, Bool, bool, false, "Cache API", "Enable Cache API") \
macro(CacheAPIEnabled, cacheAPIEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Cache API", "Enable Cache API") \
macro(ConstantPropertiesEnabled, constantPropertiesEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Constant Properties", "Enable CSS constant() properties") \
macro(DisplayContentsEnabled, displayContentsEnabled, Bool, bool, false, "CSS display: contents", "Enable CSS display: contents support") \
macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "CSS Spring Animations", "CSS Spring Animation prototype") \
@@ -1,3 +1,18 @@
2017-10-16 Youenn Fablet <youenn@apple.com>

Activate Cache API by default
https://bugs.webkit.org/show_bug.cgi?id=178186

Reviewed by Chris Dumez.

Removing explicit activation of cache api.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setCacheAPIEnabled): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:

2017-10-16 Ross Kirsling <ross.kirsling@sony.com>

run-webkit-tests help text should mention arguments too
@@ -355,8 +355,6 @@ void InjectedBundle::beginTesting(WKDictionaryRef settings)
m_testRunner->setWebGL2Enabled(true);
m_testRunner->setWebGPUEnabled(true);

m_testRunner->setCacheAPIEnabled(true);

m_testRunner->setWritableStreamAPIEnabled(true);
m_testRunner->setReadableByteStreamAPIEnabled(true);

@@ -399,13 +399,6 @@ void TestRunner::setWebGPUEnabled(bool enabled)
WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
}

void TestRunner::setCacheAPIEnabled(bool enabled)
{
WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitCacheAPIEnabled"));
auto& injectedBundle = InjectedBundle::singleton();
WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
}

void TestRunner::setWritableStreamAPIEnabled(bool enabled)
{
WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitWritableStreamAPIEnabled"));
@@ -102,7 +102,6 @@ class TestRunner : public JSWrappable {
void setModernMediaControlsEnabled(bool);
void setWebGL2Enabled(bool);
void setWebGPUEnabled(bool);
void setCacheAPIEnabled(bool);
void setWritableStreamAPIEnabled(bool);
void setReadableByteStreamAPIEnabled(bool);

0 comments on commit 3eb5fe0

Please sign in to comment.