Skip to content
Permalink
Browse files
[ews-build.webkit.org] Specify repository when sending emails
https://bugs.webkit.org/show_bug.cgi?id=239739
<rdar://problem/92291225>

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.should_send_email_for_pr): Pass repository URL.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

Canonical link: https://commits.webkit.org/249983@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JonWBedard committed Apr 26, 2022
1 parent 11afa66 commit 3fa50a3f128adee5b2b2d9366b880dec68661a45
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 4 deletions.
@@ -238,8 +238,8 @@ def _is_pr_draft(self, pr_json):
return 1
return 0

def should_send_email_for_pr(self, pr_number):
pr_json = self.get_pr_json(pr_number)
def should_send_email_for_pr(self, pr_number, repository_url=None):
pr_json = self.get_pr_json(pr_number, repository_url=repository_url)
if not pr_json:
return True

@@ -2512,7 +2512,7 @@ def send_email_for_new_build_failure(self):

if patch_id and not self.should_send_email_for_patch(patch_id):
return
if pr_number and not self.should_send_email_for_pr(pr_number):
if pr_number and not self.should_send_email_for_pr(pr_number, self.getProperty('repository')):
return
if not patch_id and not (pr_number and sha):
self._addToLog('stderr', 'Unrecognized change type')
@@ -3355,7 +3355,7 @@ def send_email_for_new_test_failures(self, test_names, exceed_failure_limit=Fals

if patch_id and not self.should_send_email_for_patch(patch_id):
return
if pr_number and not self.should_send_email_for_pr(pr_number):
if pr_number and not self.should_send_email_for_pr(pr_number, self.getProperty('repository')):
return
if not patch_id and not (pr_number and sha):
self._addToLog('stderr', 'Unrecognized change type')
@@ -1,3 +1,16 @@
2022-04-25 Jonathan Bedard <jbedard@apple.com>

[ews-build.webkit.org] Specify repository when sending emails
https://bugs.webkit.org/show_bug.cgi?id=239739
<rdar://problem/92291225>

Reviewed by Aakash Jain.

* CISupport/ews-build/steps.py:
(GitHubMixin.should_send_email_for_pr): Pass repository URL.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

2022-04-25 Aditya Keerthi <akeerthi@apple.com>

[iOS] Add NSCoding support for findInteractionEnabled

0 comments on commit 3fa50a3

Please sign in to comment.