Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Extract the logic to merge tests from MergeTestsHandler and add unit …
…tests https://bugs.webkit.org/show_bug.cgi?id=79602 Reviewed by Hajime Morita. Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler, and moved MergeTestsHandler into admin_handlers.py where it belongs. Added new backend "model-manipulator" to execute tasks to merge tests. Also revive the inadvertently removed manual submission form on the admin page. * Websites/webkit-perf.appspot.com/admin_handlers.py: (AdminDashboardHandler.get_tests): (MergeTestsHandler): (MergeTestsHandler.post): * Websites/webkit-perf.appspot.com/app.yaml: * Websites/webkit-perf.appspot.com/backends.yaml: Added. * Websites/webkit-perf.appspot.com/css/admin.css: * Websites/webkit-perf.appspot.com/js/admin.js: * Websites/webkit-perf.appspot.com/main.py: * Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed. * Websites/webkit-perf.appspot.com/models.py: (Test): (Test.merge): (TestResult.replace_to_change_test_name): * Websites/webkit-perf.appspot.com/models_unittest.py: (DataStoreTestsBase.assertOnlyInstance): (DataStoreTestsBase): (DataStoreTestsBase.assertOnlyInstances): (DataStoreTestsBase.assertEqualUnorderedModelList): (DataStoreTestsBase.assertEqualUnorderedList): (_create_build): (TestModelTests.test_merge): (TestResultTests): (TestResultTests.test_get_or_insert_value): (TestResultTests.test_get_or_insert_stat_value): (TestResultTests.test_replace_to_change_test_name): (TestResultTests.test_replace_to_change_test_name_with_stat_value): (TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result): Canonical link: https://commits.webkit.org/96819@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
269 additions
and 106 deletions.
- +43 −0 ChangeLog
- +43 −0 Websites/webkit-perf.appspot.com/admin_handlers.py
- +1 −7 Websites/webkit-perf.appspot.com/app.yaml
- +3 −0 Websites/webkit-perf.appspot.com/backends.yaml
- +14 −3 Websites/webkit-perf.appspot.com/css/admin.css
- +25 −5 Websites/webkit-perf.appspot.com/js/admin.js
- +3 −3 Websites/webkit-perf.appspot.com/main.py
- +0 −78 Websites/webkit-perf.appspot.com/merge_tests_handler.py
- +29 −0 Websites/webkit-perf.appspot.com/models.py
- +108 −10 Websites/webkit-perf.appspot.com/models_unittest.py
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -0,0 +1,3 @@ | ||
backends: | ||
- model-manipulator | ||
options: dynamic |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.