Skip to content
Permalink
Browse files
2009-11-01 Philippe Normand <pnormand@igalia.com>
        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30586
        [GTK] Failing test media/video-src-empty.html

        * platform/gtk/Skipped: Unskip fixed test.
2009-11-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30586
        [GTK] Failing test media/video-src-empty.html

        Correctly set network/ready state depending on GStreamer errors
        received on the bus.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback):

Canonical link: https://commits.webkit.org/41818@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Nov 1, 2009
1 parent 7952d1b commit 3fc02eee3a8232c5f12b20aa6cf4ee17b5398dc0
Showing 4 changed files with 29 additions and 6 deletions.
@@ -1,3 +1,12 @@
2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

* platform/gtk/Skipped: Unskip fixed test.

2009-10-31 Oliver Hunt <oliver@apple.com>

Reviewed by Jon Honeycutt.
@@ -5528,9 +5528,6 @@ media/video-played-reset.html
# https://bugs.webkit.org/show_bug.cgi?id=30680
media/audio-delete-while-step-button-clicked.html

# https://bugs.webkit.org/show_bug.cgi?id=30586
media/video-src-empty.html

# https://bugs.webkit.org/show_bug.cgi?id=30594
fast/dom/Window/window-properties.html

@@ -1,3 +1,16 @@
2009-11-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30586
[GTK] Failing test media/video-src-empty.html

Correctly set network/ready state depending on GStreamer errors
received on the bus.

* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateMessageCallback):

2009-10-31 Oliver Hunt <oliver@apple.com>

Build fix
@@ -66,11 +66,15 @@ gboolean mediaPlayerPrivateMessageCallback(GstBus* bus, GstMessage* message, gpo
LOG_VERBOSE(Media, "Error: %d, %s", err->code, err->message);

error = MediaPlayer::Empty;
if (err->domain == GST_CORE_ERROR || err->domain == GST_LIBRARY_ERROR)
error = MediaPlayer::DecodeError;
else if (err->domain == GST_RESOURCE_ERROR)
if (err->code == GST_STREAM_ERROR_CODEC_NOT_FOUND ||
err->code == GST_STREAM_ERROR_WRONG_TYPE ||
err->code == GST_STREAM_ERROR_FAILED ||
err->code == GST_CORE_ERROR_MISSING_PLUGIN ||
err->code == GST_RESOURCE_ERROR_NOT_FOUND)
error = MediaPlayer::FormatError;
else if (err->domain == GST_STREAM_ERROR)
error = MediaPlayer::DecodeError;
else if (err->domain == GST_RESOURCE_ERROR)
error = MediaPlayer::NetworkError;

if (mp)

0 comments on commit 3fc02ee

Please sign in to comment.