Skip to content
Permalink
Browse files
Remove an unused line of code.
https://bugs.webkit.org/show_bug.cgi?id=160350

Reviewed by Simon Fraser.

No new tests because there's no behavior change.  Just removing dead code.

SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun.
Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun
was introduced in https://trac.webkit.org/changeset/61393, but was later
rendered unused in https://trac.webkit.org/changeset/62099 because we
switched to using paintTextWithShadows() with the selectionStyle.  Hence,
selectionTextRun can be removed.

* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintText):



Canonical link: https://commits.webkit.org/178498@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@203910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Mark Lam committed Jul 29, 2016
1 parent c500ef4 commit 40bfabc9145566dbf9138c1fee6a136922e7bb83
Showing 2 changed files with 19 additions and 1 deletion.
@@ -1,3 +1,22 @@
2016-07-29 Mark Lam <mark.lam@apple.com>

Remove an unused line of code.
https://bugs.webkit.org/show_bug.cgi?id=160350

Reviewed by Simon Fraser.

No new tests because there's no behavior change. Just removing dead code.

SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun.
Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun
was introduced in https://trac.webkit.org/changeset/61393, but was later
rendered unused in https://trac.webkit.org/changeset/62099 because we
switched to using paintTextWithShadows() with the selectionStyle. Hence,
selectionTextRun can be removed.

* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintText):

2016-07-29 Eric Carlson <eric.carlson@apple.com>

Change internal AVCaptureDeviceType typedef name
@@ -612,7 +612,6 @@ void SVGInlineTextBox::paintText(GraphicsContext& context, const RenderStyle* st
if (style != selectionStyle)
SVGResourcesCache::clientStyleChanged(parent()->renderer(), StyleDifferenceRepaint, *selectionStyle);

TextRun selectionTextRun = constructTextRun(selectionStyle, fragment);
paintTextWithShadows(context, selectionStyle, textRun, fragment, startPosition, endPosition);

if (style != selectionStyle)

0 comments on commit 40bfabc

Please sign in to comment.