Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages Reviewed by Anders Carlsson. WebKit2: - Convert injected bundle UIClient functions to will-style, at least until we establish more concrete use cases for them past the TestRunner. * WebProcess/InjectedBundle/API/c/WKBundlePage.h: * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::willAddMessageToConsole): (WebKit::InjectedBundlePageUIClient::willSetStatusbarText): (WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert): (WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm): (WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt): * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::addMessageToConsole): (WebKit::WebChromeClient::runJavaScriptAlert): (WebKit::WebChromeClient::runJavaScriptConfirm): (WebKit::WebChromeClient::runJavaScriptPrompt): (WebKit::WebChromeClient::setStatusbarText): WebKitTools: * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::_willAddMessageToConsole): (WTR::InjectedBundlePage::_willSetStatusbarText): (WTR::InjectedBundlePage::_willRunJavaScriptAlert): (WTR::InjectedBundlePage::_willRunJavaScriptConfirm): (WTR::InjectedBundlePage::_willRunJavaScriptPrompt): (WTR::InjectedBundlePage::willAddMessageToConsole): (WTR::InjectedBundlePage::willSetStatusbarText): (WTR::InjectedBundlePage::willRunJavaScriptAlert): (WTR::InjectedBundlePage::willRunJavaScriptConfirm): (WTR::InjectedBundlePage::willRunJavaScriptPrompt): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: LayoutTests: * platform/mac-wk2/Skipped: Canonical link: https://commits.webkit.org/54687@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
228 additions
and 126 deletions.
- +9 −0 LayoutTests/ChangeLog
- +45 −81 LayoutTests/platform/mac-wk2/Skipped
- +25 −0 WebKit2/ChangeLog
- +10 −4 WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
- +24 −6 WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp
- +6 −2 WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h
- +20 −6 WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
- +21 −0 WebKitTools/ChangeLog
- +58 −22 WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
- +10 −5 WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.