Skip to content
Permalink
Browse files
Frequent crashes in JSC::parse in a worker thread when running regres…
…sion tests

https://bugs.webkit.org/show_bug.cgi?id=82660

Reviewed by Geoffrey Garen.

Source/WebCore:

Initialize m_script to empty string.  Therefore if there isn't any script payload,
the worker thread will see an empty string, not a null string.

Re-enabling fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html tests as part of this patch.

* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):

LayoutTests:

Re-enable fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html with corresponding fix.

* platform/mac/Skipped:


Canonical link: https://commits.webkit.org/100430@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
msaboff committed Apr 3, 2012
1 parent 9af563b commit 43d2a2f225dd1ebf1b4e088ef094c260589aa68d
Showing 4 changed files with 29 additions and 4 deletions.
@@ -1,3 +1,15 @@
2012-04-03 Michael Saboff <msaboff@apple.com>

Frequent crashes in JSC::parse in a worker thread when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=82660

Reviewed by Geoffrey Garen.

Re-enable fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html with corresponding fix.

* platform/mac/Skipped:

2012-04-02 Robert Hogan <robert@webkit.org>

CSS 2.1 failure: at-import-009.htm fails
@@ -645,10 +645,6 @@ fast/events/dropzone-005.html
# Spelling tests that are flakey. https://bugs.webkit.org/show_bug.cgi?id=82555
editing/spelling/spellcheck-async-mutation.html

# Remove from the skipped list when https://bugs.webkit.org/show_bug.cgi?id=82660 is fixed.
fast/workers/empty-worker-nocrash.html
fast/workers/shared-worker-constructor.html

# This should only be a layer change.
# http://webkit.org/b/82129
# https://bugs.webkit.org/show_bug.cgi?id=82742
@@ -1,3 +1,19 @@
2012-04-03 Michael Saboff <msaboff@apple.com>

Frequent crashes in JSC::parse in a worker thread when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=82660

Reviewed by Geoffrey Garen.

Initialize m_script to empty string. Therefore if there isn't any script payload,
the worker thread will see an empty string, not a null string.

Re-enabling fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html tests as part of this patch.

* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):

2012-04-03 James Robinson <jamesr@chromium.org>

[chromium] Enable sparkline FPS counter in threaded compositing mode
@@ -48,6 +48,7 @@ namespace WebCore {

WorkerScriptLoader::WorkerScriptLoader()
: m_client(0)
, m_script("")
, m_failed(false)
, m_identifier(0)
, m_finishing(false)

0 comments on commit 43d2a2f

Please sign in to comment.