Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[GTK][WPE] Fix non-unified builds after r251326
https://bugs.webkit.org/show_bug.cgi?id=203244

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

* ftl/FTLOSREntry.h: Add missing forward declaration of JSC::VM.
* inspector/ScriptCallStackFactory.h: Add missing forward declaration of JSC::JSGlobalObject.
* llint/LLIntExceptions.h: Add missing forward declaration of JSC::VM.
* runtime/ExceptionFuzz.h: Add missing forward declaration of JSC::JSGlobalObject.
* runtime/JSDateMath.h: Ditto.
* runtime/JSStringJoiner.h: Add missing inclusion of the JSGlobalObject.h header.
* runtime/Watchdog.h: Add missing forward declaration of JSC::JSGlobalObject.
* wasm/WasmOperations.h: Add missing forward declaration of JSC::JSWebAssemblyInstance.

Source/WebCore:

No new tests needed.

* Modules/async-clipboard/Clipboard.cpp: Switch inclusion of Blob.h to JSBlob.h, in order to
have a toJS() conversion for Blob defined. Remove the unneeded JSPromise.h header inclusion.
* Modules/indexeddb/IDBFactory.h: Add missing forward declaration of JSC::JSGlobalObject.
* bindings/js/JSDOMBindingSecurity.h: Ditto.
* bindings/js/ScriptState.h: Ditto.
* dom/Node.cpp: Add missing inclusion of JavaScriptCore/HeapInlines.h
* page/RemoteDOMWindow.h: Add missing forward declaration of JSC::JSGlobalObject.
* platform/graphics/HEVCUtilities.cpp: Add missing inclusion of the wtf/text/StringHash.h
header, needed to use String as key for a HashMap.

Source/WebKit:

* Shared/UserData.cpp: Add missing inclusion of WebCoreArgumentCoders.h
* UIProcess/Automation/SimulatedInputDispatcher.cpp: Add missing inclusion of wtf/Variant.h
* UIProcess/ProvisionalPageProxy.h: Add missing inclusion of WebCore/ResourceRequest.h
* UIProcess/WebTextChecker.cpp: Add missing inclusion of WebPageProxy.h
* WebProcess/Databases/WebDatabaseProvider.cpp: Add missing inclusion of WebIDBConnectionToServer.h


Canonical link: https://commits.webkit.org/216673@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aperezdc committed Oct 22, 2019
1 parent 1670007 commit 4450bb1
Show file tree
Hide file tree
Showing 23 changed files with 70 additions and 2 deletions.
16 changes: 16 additions & 0 deletions Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,19 @@
2019-10-22 Adrian Perez de Castro <aperez@igalia.com>

[GTK][WPE] Fix non-unified builds after r251326
https://bugs.webkit.org/show_bug.cgi?id=203244

Reviewed by Youenn Fablet.

* ftl/FTLOSREntry.h: Add missing forward declaration of JSC::VM.
* inspector/ScriptCallStackFactory.h: Add missing forward declaration of JSC::JSGlobalObject.
* llint/LLIntExceptions.h: Add missing forward declaration of JSC::VM.
* runtime/ExceptionFuzz.h: Add missing forward declaration of JSC::JSGlobalObject.
* runtime/JSDateMath.h: Ditto.
* runtime/JSStringJoiner.h: Add missing inclusion of the JSGlobalObject.h header.
* runtime/Watchdog.h: Add missing forward declaration of JSC::JSGlobalObject.
* wasm/WasmOperations.h: Add missing forward declaration of JSC::JSWebAssemblyInstance.

2019-10-21 Yusuke Suzuki <ysuzuki@apple.com>

[JSC] Thread JSGlobalObject* instead of ExecState*
Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/ftl/FTLOSREntry.h
Expand Up @@ -31,6 +31,7 @@ namespace JSC {

class CallFrame;
class CodeBlock;
class VM;

namespace FTL {

Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/inspector/ScriptCallStackFactory.h
Expand Up @@ -37,6 +37,7 @@
namespace JSC {
class CallFrame;
class Exception;
class JSGlobalObject;
class JSValue;
}

Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/llint/LLIntExceptions.h
Expand Up @@ -30,6 +30,7 @@
namespace JSC {

class CallFrame;
class VM;
struct Instruction;

namespace LLInt {
Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/runtime/ExceptionFuzz.h
Expand Up @@ -30,6 +30,7 @@
namespace JSC {

class CallFrame;
class JSGlobalObject;
class ThrowScope;

// Call this only if you know that exception fuzzing is enabled.
Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/runtime/JSDateMath.h
Expand Up @@ -48,6 +48,7 @@
namespace JSC {

class CallFrame;
class JSGlobalObject;
class VM;

JS_EXPORT_PRIVATE void msToGregorianDateTime(VM&, double, WTF::TimeType outputTimeType, GregorianDateTime&);
Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/runtime/JSStringJoiner.h
Expand Up @@ -27,6 +27,7 @@

#include "ExceptionHelpers.h"
#include "JSCJSValue.h"
#include "JSGlobalObject.h"

namespace JSC {

Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/runtime/Watchdog.h
Expand Up @@ -34,6 +34,7 @@
namespace JSC {

class CallFrame;
class JSGlobalObject;
class VM;

class Watchdog : public WTF::ThreadSafeRefCounted<Watchdog> {
Expand Down
3 changes: 3 additions & 0 deletions Source/JavaScriptCore/wasm/WasmOperations.h
Expand Up @@ -30,6 +30,9 @@
#include "SlowPathReturnType.h"

namespace JSC {

class JSWebAssemblyInstance;

namespace Probe {
class Context;
} // namespace JSC::Probe
Expand Down
19 changes: 19 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,22 @@
2019-10-22 Adrian Perez de Castro <aperez@igalia.com>

[GTK][WPE] Fix non-unified builds after r251326
https://bugs.webkit.org/show_bug.cgi?id=203244

Reviewed by Youenn Fablet.

No new tests needed.

* Modules/async-clipboard/Clipboard.cpp: Switch inclusion of Blob.h to JSBlob.h, in order to
have a toJS() conversion for Blob defined. Remove the unneeded JSPromise.h header inclusion.
* Modules/indexeddb/IDBFactory.h: Add missing forward declaration of JSC::JSGlobalObject.
* bindings/js/JSDOMBindingSecurity.h: Ditto.
* bindings/js/ScriptState.h: Ditto.
* dom/Node.cpp: Add missing inclusion of JavaScriptCore/HeapInlines.h
* page/RemoteDOMWindow.h: Add missing forward declaration of JSC::JSGlobalObject.
* platform/graphics/HEVCUtilities.cpp: Add missing inclusion of the wtf/text/StringHash.h
header, needed to use String as key for a HashMap.

2019-10-22 Miguel Gomez <magomez@igalia.com>

REGRESSION(r244372): [GTK][WPE] fast/images/icon-decoding.html and others are failing
Expand Down
3 changes: 1 addition & 2 deletions Source/WebCore/Modules/async-clipboard/Clipboard.cpp
Expand Up @@ -26,11 +26,10 @@
#include "config.h"
#include "Clipboard.h"

#include "Blob.h"
#include "ClipboardItem.h"
#include "Frame.h"
#include "JSBlob.h"
#include "JSClipboardItem.h"
#include "JSDOMPromise.h"
#include "JSDOMPromiseDeferred.h"
#include "Navigator.h"
#include "Pasteboard.h"
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/Modules/indexeddb/IDBFactory.h
Expand Up @@ -35,6 +35,7 @@

namespace JSC {
class CallFrame;
class JSGlobalObject;
class JSValue;
}

Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/bindings/js/JSDOMBindingSecurity.h
Expand Up @@ -28,6 +28,7 @@

namespace JSC {
class CallFrame;
class JSGlobalObject;
}

namespace WebCore {
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/bindings/js/ScriptState.h
Expand Up @@ -33,6 +33,7 @@

namespace JSC {
class CallFrame;
class JSGlobalObject;
}

namespace WebCore {
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/dom/Node.cpp
Expand Up @@ -77,6 +77,7 @@
#include "WheelEvent.h"
#include "XMLNSNames.h"
#include "XMLNames.h"
#include <JavaScriptCore/HeapInlines.h>
#include <wtf/IsoMallocInlines.h>
#include <wtf/RefCountedLeakCounter.h>
#include <wtf/SHA1.h>
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/page/RemoteDOMWindow.h
Expand Up @@ -32,6 +32,7 @@

namespace JSC {
class CallFrame;
class JSGlobalObject;
class JSObject;
class JSValue;
template<typename> class Strong;
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/platform/graphics/HEVCUtilities.cpp
Expand Up @@ -29,6 +29,7 @@
#include <wtf/HashMap.h>
#include <wtf/HashSet.h>
#include <wtf/NeverDestroyed.h>
#include <wtf/text/StringHash.h>
#include <wtf/text/StringToIntegerConversion.h>

namespace WebCore {
Expand Down
13 changes: 13 additions & 0 deletions Source/WebKit/ChangeLog
@@ -1,3 +1,16 @@
2019-10-22 Adrian Perez de Castro <aperez@igalia.com>

[GTK][WPE] Fix non-unified builds after r251326
https://bugs.webkit.org/show_bug.cgi?id=203244

Reviewed by Youenn Fablet.

* Shared/UserData.cpp: Add missing inclusion of WebCoreArgumentCoders.h
* UIProcess/Automation/SimulatedInputDispatcher.cpp: Add missing inclusion of wtf/Variant.h
* UIProcess/ProvisionalPageProxy.h: Add missing inclusion of WebCore/ResourceRequest.h
* UIProcess/WebTextChecker.cpp: Add missing inclusion of WebPageProxy.h
* WebProcess/Databases/WebDatabaseProvider.cpp: Add missing inclusion of WebIDBConnectionToServer.h

2019-10-22 youenn fablet <youenn@apple.com>

WebSWServerToContextConnection should not assert when failing loads at destruction time
Expand Down
1 change: 1 addition & 0 deletions Source/WebKit/Shared/UserData.cpp
Expand Up @@ -45,6 +45,7 @@
#include "Encoder.h"
#include "ShareableBitmap.h"
#include "WebCertificateInfo.h"
#include "WebCoreArgumentCoders.h"
#include "WebImage.h"
#include "WebRenderLayer.h"
#include "WebRenderObject.h"
Expand Down
Expand Up @@ -32,6 +32,7 @@
#include "Logging.h"
#include "WebAutomationSession.h"
#include "WebAutomationSessionMacros.h"
#include <wtf/Variant.h>

namespace WebKit {

Expand Down
1 change: 1 addition & 0 deletions Source/WebKit/UIProcess/ProvisionalPageProxy.h
Expand Up @@ -30,6 +30,7 @@
#include "WebFramePolicyListenerProxy.h"
#include "WebPageProxyMessages.h"
#include "WebsitePoliciesData.h"
#include <WebCore/ResourceRequest.h>
#include <wtf/WeakPtr.h>

namespace API {
Expand Down
1 change: 1 addition & 0 deletions Source/WebKit/UIProcess/WebTextChecker.cpp
Expand Up @@ -28,6 +28,7 @@

#include "TextChecker.h"
#include "WKAPICast.h"
#include "WebPageProxy.h"
#include "WebProcessPool.h"
#include <wtf/RefPtr.h>

Expand Down
1 change: 1 addition & 0 deletions Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp
Expand Up @@ -27,6 +27,7 @@
#include "WebDatabaseProvider.h"

#include "NetworkProcessConnection.h"
#include "WebIDBConnectionToServer.h"
#include "WebProcess.h"
#include <wtf/HashMap.h>
#include <wtf/NeverDestroyed.h>
Expand Down

0 comments on commit 4450bb1

Please sign in to comment.