Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Remove feed and feeds URL scheme workarounds
https://bugs.webkit.org/show_bug.cgi?id=100442

Reviewed by Dan Bernstein.

* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):

Canonical link: https://commits.webkit.org/118464@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Anders Carlsson committed Oct 26, 2012
1 parent cb78f35 commit 44f12bf
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 14 deletions.
12 changes: 12 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
2012-10-25 Anders Carlsson <andersca@apple.com>

Remove feed and feeds URL scheme workarounds
https://bugs.webkit.org/show_bug.cgi?id=100442

Reviewed by Dan Bernstein.

* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):

2012-10-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r132514.
Expand Down
11 changes: 0 additions & 11 deletions Source/WebCore/dom/DocumentEventQueue.cpp
Expand Up @@ -40,12 +40,6 @@

namespace WebCore {

static inline bool shouldDispatchScrollEventSynchronously(Document* document)
{
ASSERT_ARG(document, document);
return applicationIsSafari() && (document->url().protocolIs("feed") || document->url().protocolIs("feeds"));
}

class DocumentEventQueueTimer : public SuspendableTimer {
WTF_MAKE_NONCOPYABLE(DocumentEventQueueTimer);
public:
Expand Down Expand Up @@ -98,11 +92,6 @@ void DocumentEventQueue::enqueueOrDispatchScrollEvent(PassRefPtr<Node> target, S
bool canBubble = targetType == ScrollEventDocumentTarget;
RefPtr<Event> scrollEvent = Event::create(eventNames().scrollEvent, canBubble, false /* non cancelleable */);

if (shouldDispatchScrollEventSynchronously(target->document())) {
target->dispatchEvent(scrollEvent.release());
return;
}

if (!m_nodesWithQueuedScrollEvents.add(target.get()).isNewEntry)
return;

Expand Down
3 changes: 0 additions & 3 deletions Source/WebCore/page/mac/EventHandlerMac.mm
Expand Up @@ -711,9 +711,6 @@ static bool frameHasPlatformWidget(Frame* frame)
{
Document* document = m_frame->document();

// RSS view needs arrow key keypress events.
if (applicationIsSafari() && (document->url().protocolIs("feed") || document->url().protocolIs("feeds")))
return true;
Settings* settings = m_frame->settings();
if (!settings)
return false;
Expand Down

0 comments on commit 44f12bf

Please sign in to comment.