Skip to content
Permalink
Browse files
Fix build warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125012

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-29
Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::SocketEventSource::eventCallback):
* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKArrayIsMutable):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

Canonical link: https://commits.webkit.org/143133@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
mtibor authored and webkit-commit-queue committed Nov 30, 2013
1 parent 62078e6 commit 45063ea3d5d37ae5c4b8f2855b1771d135e7c329
@@ -1,3 +1,23 @@
2013-11-29 Tibor Meszaros <mtibor@inf.u-szeged.hu>

Fix build warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125012

Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::SocketEventSource::eventCallback):
* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKArrayIsMutable):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

2013-11-29 Sam Weinig <sam@webkit.org>

[Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts
@@ -100,7 +100,7 @@ class WorkQueue::SocketEventSource : public WorkQueue::EventSource {
return condition & m_condition;
}

static gboolean eventCallback(GSocket* socket, GIOCondition condition, SocketEventSource* eventSource)
static gboolean eventCallback(GSocket*, GIOCondition condition, SocketEventSource* eventSource)
{
ASSERT(eventSource);

@@ -37,7 +37,7 @@ WK_EXPORT CGContextRef WKGraphicsContextGetCGContext(WKGraphicsContextRef graphi
#endif
}

bool WKArrayIsMutable(WKArrayRef array)
bool WKArrayIsMutable(WKArrayRef)
{
return false;
}
@@ -549,6 +549,9 @@ void WebChromeClient::unavailablePluginButtonClicked(Element* element, RenderEmb
if (!pluginspageAttributeURL.protocolIsInHTTPFamily())
pluginspageAttributeURL = URL();
m_page->send(Messages::WebPageProxy::UnavailablePluginButtonClicked(pluginUnavailabilityReason, pluginElement->serviceType(), pluginURLString, pluginspageAttributeURL.string(), frameURLString, pageURLString));
#else
UNUSED_PARAM(element);
UNUSED_PARAM(pluginUnavailabilityReason);
#endif // ENABLE(NETSCAPE_PLUGIN_API)
}

@@ -894,6 +897,8 @@ void WebChromeClient::didAddHeaderLayer(GraphicsLayer* headerParent)
#if ENABLE(RUBBER_BANDING)
if (PageBanner* banner = m_page->headerPageBanner())
banner->didAddParentLayer(headerParent);
#else
UNUSED_PARAM(headerParent);
#endif
}

@@ -902,6 +907,8 @@ void WebChromeClient::didAddFooterLayer(GraphicsLayer* footerParent)
#if ENABLE(RUBBER_BANDING)
if (PageBanner* banner = m_page->footerPageBanner())
banner->didAddParentLayer(footerParent);
#else
UNUSED_PARAM(footerParent);
#endif
}

@@ -1384,6 +1384,10 @@ PassRefPtr<Widget> WebFrameLoaderClient::createJavaAppletWidget(const IntSize& p
}
return plugin.release();
#else
UNUSED_PARAM(pluginSize);
UNUSED_PARAM(appletElement);
UNUSED_PARAM(paramNames);
UNUSED_PARAM(paramValues);
return 0;
#endif
}

0 comments on commit 45063ea

Please sign in to comment.