Skip to content
Permalink
Browse files
Revert "<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoo…
…pTimerRef every time it's called"

This reverts commit r85195.  It was crashing DumpRenderTree on Lion.

* wtf/mac/MainThreadMac.mm:
(WTF::postTimer):

Canonical link: https://commits.webkit.org/74976@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ddkilzer committed Apr 29, 2011
1 parent 1b1e235 commit 45e456c4334ccc66923a767f502828ea241aa241
Showing with 10 additions and 3 deletions.
  1. +9 −0 Source/JavaScriptCore/ChangeLog
  2. +1 −3 Source/JavaScriptCore/wtf/mac/MainThreadMac.mm
@@ -1,3 +1,12 @@
2011-04-28 David Kilzer <ddkilzer@apple.com>

Revert "<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called"

This reverts commit r85195. It was crashing DumpRenderTree on Lion.

* wtf/mac/MainThreadMac.mm:
(WTF::postTimer):

2011-04-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.
@@ -33,7 +33,6 @@
#import <Foundation/NSThread.h>
#import <stdio.h>
#import <wtf/Assertions.h>
#import <wtf/RetainPtr.h>
#import <wtf/Threading.h>

@interface WTFMainThreadCaller : NSObject {
@@ -96,8 +95,7 @@ static void postTimer()
return;

isTimerPosted = true;
RetainPtr<CFRunLoopTimerRef> runLoopTimer(AdoptCF, CFRunLoopTimerCreate(0, 0, 0, 0, 0, timerFired, 0));
CFRunLoopAddTimer(CFRunLoopGetCurrent(), runLoopTimer.get(), kCFRunLoopCommonModes);
CFRunLoopAddTimer(CFRunLoopGetCurrent(), CFRunLoopTimerCreate(0, 0, 0, 0, 0, timerFired, 0), kCFRunLoopCommonModes);
}

void scheduleDispatchFunctionsOnMainThread()

0 comments on commit 45e456c

Please sign in to comment.