Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
ShowRenderTree: Shuffle letters to have better readability.
https://bugs.webkit.org/show_bug.cgi?id=162460

Reviewed by Simon Fraser.
old: (B)lock/(I)nline/I(N)line-block, (R)elative/A(B)solute/Fi(X)ed/Stick(Y) positioned, (O)verflow clipping, (A)nonymous, (G)enerated, (F)loating, has(L)ayer, (C)omposited, (D)irty layout, Dirty (S)tyle.
new: (B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout.

Not testable.

* rendering/RenderObject.cpp:
(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showRenderObject):


Canonical link: https://commits.webkit.org/180419@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@206279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
alanbaradlay committed Sep 22, 2016
1 parent a8316eb commit 4634186
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 13 deletions.
15 changes: 15 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,18 @@
2016-09-22 Zalan Bujtas <zalan@apple.com>

ShowRenderTree: Shuffle letters to have better readability.
https://bugs.webkit.org/show_bug.cgi?id=162460

Reviewed by Simon Fraser.
old: (B)lock/(I)nline/I(N)line-block, (R)elative/A(B)solute/Fi(X)ed/Stick(Y) positioned, (O)verflow clipping, (A)nonymous, (G)enerated, (F)loating, has(L)ayer, (C)omposited, (D)irty layout, Dirty (S)tyle.
new: (B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout.

Not testable.

* rendering/RenderObject.cpp:
(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showRenderObject):

2016-09-22 Daniel Bates <dabates@apple.com>

[CSP] Violation report may be sent to wrong domain on frame-ancestors violation
Expand Down
26 changes: 13 additions & 13 deletions Source/WebCore/rendering/RenderObject.cpp
Expand Up @@ -947,7 +947,7 @@ FloatRect RenderObject::computeFloatRectForRepaint(const FloatRect&, const Rende

static void showRenderTreeLegend()
{
fprintf(stderr, "\n(B)lock/(I)nline/I(N)line-block, (R)elative/A(B)solute/Fi(X)ed/Stick(Y) positioned, (O)verflow clipping, (A)nonymous, (G)enerated, (F)loating, has(L)ayer, (C)omposited, (D)irty layout, Dirty (S)tyle\n");
fprintf(stderr, "\n(B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout\n");
}

void RenderObject::showNodeTreeForThis() const
Expand Down Expand Up @@ -1026,23 +1026,28 @@ void RenderObject::showRenderObject(bool mark, int depth) const
if (isRelPositioned())
fputc('R', stderr);
else if (isStickyPositioned())
fputc('Y', stderr);
fputc('K', stderr);
else if (isOutOfFlowPositioned()) {
if (style().position() == AbsolutePosition)
fputc('B', stderr);
fputc('A', stderr);
else
fputc('X', stderr);
}
} else
fputc('-', stderr);

if (isFloating())
fputc('F', stderr);
else
fputc('-', stderr);

if (hasOverflowClip())
fputc('O', stderr);
else
fputc('-', stderr);

if (isAnonymous())
fputc('A', stderr);
fputc('Y', stderr);
else
fputc('-', stderr);

Expand All @@ -1051,11 +1056,6 @@ void RenderObject::showRenderObject(bool mark, int depth) const
else
fputc('-', stderr);

if (isFloating())
fputc('F', stderr);
else
fputc('-', stderr);

if (hasLayer())
fputc('L', stderr);
else
Expand All @@ -1068,13 +1068,13 @@ void RenderObject::showRenderObject(bool mark, int depth) const

fputc(' ', stderr);

if (needsLayout())
fputc('D', stderr);
if (node() && node()->needsStyleRecalc())
fputc('+', stderr);
else
fputc('-', stderr);

if (node() && node()->needsStyleRecalc())
fputc('S', stderr);
if (needsLayout())
fputc('+', stderr);
else
fputc('-', stderr);

Expand Down

0 comments on commit 4634186

Please sign in to comment.