Skip to content
Permalink
Browse files
2011-06-21 Peter Varga <pvarga@webkit.org>
        Reviewed by Andreas Kling.

        [Qt][V8] Enable marking objects with complex GC rules
        https://bugs.webkit.org/show_bug.cgi?id=61291

        No new tests needed.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/V8/V8TestInterface.cpp:
        (WebCore::V8TestInterface::wrapSlow):
        * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
        (WebCore::V8TestMediaQueryListListener::wrapSlow):
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::V8TestObj::wrapSlow):
        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
        (WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

Canonical link: https://commits.webkit.org/78672@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Peter Varga committed Jun 21, 2011
1 parent 7c293cc commit 476eac00494f1bab8a163a09f603cfc23bffb00f
@@ -1,3 +1,22 @@
2011-06-21 Peter Varga <pvarga@webkit.org>

Reviewed by Andreas Kling.

[Qt][V8] Enable marking objects with complex GC rules
https://bugs.webkit.org/show_bug.cgi?id=61291

No new tests needed.

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

2011-06-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.
@@ -2573,13 +2573,9 @@ END

push(@implContent, <<END);
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
\#if !PLATFORM(QT)
// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
// https://bugs.webkit.org/show_bug.cgi?id=61291
if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
\#endif
END
if (IsNodeSubType($dataNode)) {
push(@implContent, <<END);
@@ -103,13 +103,9 @@ v8::Handle<v8::Object> V8TestInterface::wrapSlow(TestInterface* impl)

impl->ref();
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
#if !PLATFORM(QT)
// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
// https://bugs.webkit.org/show_bug.cgi?id=61291

if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
@@ -110,13 +110,9 @@ v8::Handle<v8::Object> V8TestMediaQueryListListener::wrapSlow(TestMediaQueryList

impl->ref();
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
#if !PLATFORM(QT)
// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
// https://bugs.webkit.org/show_bug.cgi?id=61291

if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
@@ -1397,13 +1397,9 @@ v8::Handle<v8::Object> V8TestObj::wrapSlow(TestObj* impl)

impl->ref();
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
#if !PLATFORM(QT)
// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
// https://bugs.webkit.org/show_bug.cgi?id=61291

if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}
@@ -99,13 +99,9 @@ v8::Handle<v8::Object> V8TestSerializedScriptValueInterface::wrapSlow(TestSerial
impl->ref();
SerializedScriptValue::deserializeAndSetProperty(wrapper, "value", static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly), impl->value());
v8::Persistent<v8::Object> wrapperHandle = v8::Persistent<v8::Object>::New(wrapper);
#if !PLATFORM(QT)
// FIXME: qtscript-staging's shipped V8 does not have the needed functionality yet.
// https://bugs.webkit.org/show_bug.cgi?id=61291

if (!hasDependentLifetime)
wrapperHandle.MarkIndependent();
#endif
getDOMObjectMap().set(impl, wrapperHandle);
return wrapper;
}

0 comments on commit 476eac0

Please sign in to comment.