Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Implement unprefixed :fullscreen pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=246041 rdar://100783064 Reviewed by Antti Koivisto. Defined in https://fullscreen.spec.whatwg.org/#:fullscreen-pseudo-class This differs from :-webkit-full-screen, since :fullscreen applies to all fullscreen element in the top layer, as opposed to :-webkit-full-screen, which applies on the top-most one. Unfortunately, this still does not allow us to remove full style rebuilds for 2 reasons: - We still need to support :-webkit-full-screen-ancestor/document - There seems to be a bug where adding position: fixed; & adding to top layer in the same layout causes dirty renderers. Tests are not necessary, as this is exercised by the user agent stylesheet (which is already well tested by the fullscreen/ directory). * LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-css-invalidation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/fullscreen/rendering/fullscreen-pseudo-class-support-expected.txt: * Source/WebCore/css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const): * Source/WebCore/css/CSSSelector.h: * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): * Source/WebCore/css/SelectorCheckerTestFunctions.h: (WebCore::matchesFullscreenPseudoClass): (WebCore::matchesWebkitFullScreenPseudoClass): (WebCore::matchesFullScreenPseudoClass): Deleted. * Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in: * Source/WebCore/css/fullscreen.css: (#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API): (:root:-webkit-full-screen-document:not(:fullscreen)): (:fullscreen video,): (img:fullscreen): (iframe:fullscreen): (:not(:root):fullscreen::backdrop): (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Deleted. (:-webkit-full-screen video,): Deleted. (img:-webkit-full-screen): Deleted. (iframe:-webkit-full-screen): Deleted. (:not(:root):-webkit-full-screen::backdrop): Deleted. * Source/WebCore/cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION): (WebCore::SelectorCompiler::addPseudoClassType): * Source/WebCore/dom/Element.cpp: (WebCore::Element::setFullscreenFlag): * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::willEnterFullscreen): Canonical link: https://commits.webkit.org/257542@main
- Loading branch information
Showing
11 changed files
with
55 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Should be green | ||
|
||
FAIL Invalidate :fullscreen based style assert_equals: Green when :root is fullscreened. expected "rgb(0, 128, 0)" but got "rgb(255, 0, 0)" | ||
PASS Invalidate :fullscreen based style | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
|
||
FAIL :fullscreen pseudo-class support The string did not match the expected pattern. | ||
PASS :fullscreen pseudo-class support | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters