Skip to content
Permalink
Browse files
Work around a bug in KURL's parsing of Windows-style absolute file: URLs
Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
incorrect parsing of absolute Windows-style file: URLs

Reviewed by Tim Hatcher.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
<http://webkit.org/b/55683>.

Canonical link: https://commits.webkit.org/70144@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aroben committed Mar 3, 2011
1 parent 74e99aa commit 484e6a60880f1787f93c49c3a2432726ca5a8ffa
Showing with 15 additions and 1 deletion.
  1. +13 −0 Tools/ChangeLog
  2. +2 −1 Tools/WebKitTestRunner/TestInvocation.cpp
@@ -1,3 +1,16 @@
2011-03-03 Adam Roben <aroben@apple.com>

Work around a bug in KURL's parsing of Windows-style absolute file: URLs

Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
incorrect parsing of absolute Windows-style file: URLs

Reviewed by Tim Hatcher.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
<http://webkit.org/b/55683>.

2011-03-03 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.
@@ -58,7 +58,8 @@ static WKURLRef createWKURL(const char* pathOrURL)
if (!length)
return 0;

const char* filePrefix = "file://";
// FIXME: Remove the "localhost/" suffix once <http://webkit.org/b/55683> is fixed.
const char* filePrefix = "file://localhost/";
static const size_t prefixLength = strlen(filePrefix);
#if OS(WINDOWS)
const char separator = '\\';

0 comments on commit 484e6a6

Please sign in to comment.