Skip to content
Permalink
Browse files
2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>
        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: animation incorrect when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=38371

        This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update()
        instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on
        each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update.

        Tested by http://www.the-art-of-web.com/css/css-animation/

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::update):

Canonical link: https://commits.webkit.org/49900@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed May 2, 2010
1 parent d7271fb commit 489ed1cb7d0dc4f6f34861c95675e4877775dd32
Showing 2 changed files with 17 additions and 0 deletions.
@@ -292,6 +292,7 @@ void QGraphicsWebViewPrivate::update(const QRect & dirtyRect)
if (overlay)
overlay->update(QRectF(dirtyRect));
#if USE(ACCELERATED_COMPOSITING)
updateCompositingScrollPosition();
syncLayers();
#endif
}
@@ -1,3 +1,19 @@
2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: animation incorrect when scrolling
https://bugs.webkit.org/show_bug.cgi?id=38371

This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update()
instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on
each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update.

Tested by http://www.the-art-of-web.com/css/css-animation/

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::update):

2010-05-01 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

0 comments on commit 489ed1c

Please sign in to comment.