Skip to content
Permalink
Browse files
Update autoscroll test to lift at the end and be less flakey
https://bugs.webkit.org/show_bug.cgi?id=197084

Test not lifting at the end caused issues for other tests.
Also the positions were a bit too exact and caused the
test to be flakey. These new positions should result in more consistent
behaviour.

Reviewed by Tim Horton.

* fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html:


Canonical link: https://commits.webkit.org/211331@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
megangardner committed Apr 19, 2019
1 parent ba791d8 commit 49912d7076343024339ea78a8d3bc7a52bcd71b6
Showing 2 changed files with 17 additions and 2 deletions.
@@ -1,3 +1,17 @@
2019-04-18 Megan Gardner <megan_gardner@apple.com>

Update autoscroll test to lift at the end and be less flakey
https://bugs.webkit.org/show_bug.cgi?id=197084

Test not lifting at the end caused issues for other tests.
Also the positions were a bit too exact and caused the
test to be flakey. These new positions should result in more consistent
behaviour.

Reviewed by Tim Horton.

* fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html:

2019-04-18 Justin Fan <justin_fan@apple.com>

[WebGPU] Implement API default values
@@ -28,8 +28,9 @@
await didShowKeyboard();
await longPressAndHoldAtPoint(tapPointX, tapPointY);
await continueTouchAndDragFromPointToPoint(tapPointX, tapPointY, dragX, tapPointY);
await holdAtPoint(dragX, tapPointY, 2.0);
await continueTouchAndDragFromPointToPoint(dragX, tapPointY, dragX + 5, tapPointY);
await holdAtPoint(dragX, tapPointY + 20, 1.0);
await continueTouchAndDragFromPointToPoint(dragX, tapPointY + 20, dragX + 5, tapPointY + 20);
await liftUpAtPoint(dragX + 5, tapPointY + 20);
if (scrollBox.scrollLeft > 0)
output += 'PASS: Text Box has been scrolled.';
else

0 comments on commit 49912d7

Please sign in to comment.