Skip to content
Permalink
Browse files
2010-03-08 Eric Uhrhane <ericu@chromium.org>
        Reviewed by David Levin.

        Remove the now-redundant Settings fields for the Database
        https://bugs.webkit.org/show_bug.cgi?id=35763

        No new tests; this code isn't called.

        * WebCore.base.exp:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
2010-03-08  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Remove the now-redundant Settings fields for the Database
        https://bugs.webkit.org/show_bug.cgi?id=35763

        No new tests; this code isn't called.

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        * src/WebSettingsImpl.h:
2010-03-08  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Remove the now-redundant Settings fields for the Database
        https://bugs.webkit.org/show_bug.cgi?id=35763

        No new tests; this code isn't called.

        * webkit/webkitwebview.cpp: Remove the calls into Settings.
        (DNDContentsRequest::webkit_web_view_update_settings):
        (DNDContentsRequest::webkit_web_view_settings_notify):
2010-03-08  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Remove the now-redundant Settings fields for the Database
        https://bugs.webkit.org/show_bug.cgi?id=35763

        No new tests; this code isn't called.

        * WebView/WebView.mm: Remove the call into Settings.
        (-[WebView _preferencesChangedNotification:]):
2010-03-08  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Remove the now-redundant Settings fields for the Database
        https://bugs.webkit.org/show_bug.cgi?id=35763

        No new tests; this code isn't called.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply): Remove the call into Settings.

Canonical link: https://commits.webkit.org/46963@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Mar 8, 2010
1 parent bdd5fa0 commit 4a320b3545d0568ab5997b54da02174810a5afb8
Showing 14 changed files with 64 additions and 25 deletions.
@@ -1,3 +1,17 @@
2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

* WebCore.base.exp:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

2010-03-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.
@@ -635,7 +635,6 @@ __ZN7WebCore8Settings18setDefaultFontSizeEi
__ZN7WebCore8Settings18setFixedFontFamilyERKNS_12AtomicStringE
__ZN7WebCore8Settings18setMinimumFontSizeEi
__ZN7WebCore8Settings18setSerifFontFamilyERKNS_12AtomicStringE
__ZN7WebCore8Settings19setDatabasesEnabledEb
__ZN7WebCore8Settings19setShowDebugBordersEb
__ZN7WebCore8Settings20setCursiveFontFamilyERKNS_12AtomicStringE
__ZN7WebCore8Settings20setFantasyFontFamilyERKNS_12AtomicStringE
@@ -73,7 +73,6 @@ Settings::Settings(Page* page)
, m_caretBrowsingEnabled(false)
, m_areImagesEnabled(true)
, m_arePluginsEnabled(false)
, m_databasesEnabled(false)
, m_localStorageEnabled(false)
, m_isJavaScriptEnabled(false)
, m_isWebSecurityEnabled(true)
@@ -267,14 +266,6 @@ void Settings::setPluginsEnabled(bool arePluginsEnabled)
m_arePluginsEnabled = arePluginsEnabled;
}

void Settings::setDatabasesEnabled(bool databasesEnabled)
{
m_databasesEnabled = databasesEnabled;
#if ENABLE(DATABASE)
Database::setIsAvailable(databasesEnabled);
#endif
}

void Settings::setLocalStorageEnabled(bool localStorageEnabled)
{
m_localStorageEnabled = localStorageEnabled;
@@ -131,9 +131,6 @@ namespace WebCore {
void setPluginsEnabled(bool);
bool arePluginsEnabled() const { return m_arePluginsEnabled; }

void setDatabasesEnabled(bool);
bool databasesEnabled() const { return m_databasesEnabled; }

void setLocalStorageEnabled(bool);
bool localStorageEnabled() const { return m_localStorageEnabled; }

@@ -321,7 +318,6 @@ namespace WebCore {
bool m_caretBrowsingEnabled : 1;
bool m_areImagesEnabled : 1;
bool m_arePluginsEnabled : 1;
bool m_databasesEnabled : 1;
bool m_localStorageEnabled : 1;
bool m_isJavaScriptEnabled : 1;
bool m_isWebSecurityEnabled : 1;
@@ -1,3 +1,16 @@
2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:

2010-03-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.
@@ -76,7 +76,6 @@ class WebSettings {
virtual void setEditableLinkBehaviorNeverLive() = 0;
virtual void setFontRenderingModeNormal() = 0;
virtual void setShouldPaintCustomScrollbars(bool) = 0;
virtual void setDatabasesEnabled(bool) = 0;
virtual void setAllowUniversalAccessFromFileURLs(bool) = 0;
virtual void setAllowFileAccessFromFileURLs(bool) = 0;
virtual void setTextDirectionSubmenuInclusionBehaviorNeverIncluded() = 0;
@@ -226,11 +226,6 @@ void WebSettingsImpl::setShouldPaintCustomScrollbars(bool enabled)
m_settings->setShouldPaintCustomScrollbars(enabled);
}

void WebSettingsImpl::setDatabasesEnabled(bool enabled)
{
m_settings->setDatabasesEnabled(enabled);
}

void WebSettingsImpl::setAllowUniversalAccessFromFileURLs(bool allow)
{
m_settings->setAllowUniversalAccessFromFileURLs(allow);
@@ -78,7 +78,6 @@ class WebSettingsImpl : public WebSettings {
virtual void setEditableLinkBehaviorNeverLive();
virtual void setFontRenderingModeNormal();
virtual void setShouldPaintCustomScrollbars(bool);
virtual void setDatabasesEnabled(bool);
virtual void setAllowUniversalAccessFromFileURLs(bool);
virtual void setAllowFileAccessFromFileURLs(bool);
virtual void setTextDirectionSubmenuInclusionBehaviorNeverIncluded();
@@ -1,3 +1,16 @@
2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

* webkit/webkitwebview.cpp: Remove the calls into Settings.
(DNDContentsRequest::webkit_web_view_update_settings):
(DNDContentsRequest::webkit_web_view_settings_notify):

2010-03-06 Arno Renevier <arno@renevier.net>

Reviewed by Eric Seidel.
@@ -2730,7 +2730,6 @@ static void webkit_web_view_update_settings(WebKitWebView* webView)
settings->setDeveloperExtrasEnabled(enableDeveloperExtras);
settings->setPrivateBrowsingEnabled(enablePrivateBrowsing);
settings->setCaretBrowsingEnabled(enableCaretBrowsing);
settings->setDatabasesEnabled(enableHTML5Database);
#if ENABLE(DATABASE)
Database::setIsAvailable(enableHTML5Database);
#endif
@@ -2824,7 +2823,6 @@ static void webkit_web_view_settings_notify(WebKitWebSettings* webSettings, GPar
settings->setCaretBrowsingEnabled(g_value_get_boolean(&value));
#if ENABLE(DATABASE)
else if (name == g_intern_string("enable-html5-database")) {
settings->setDatabasesEnabled(g_value_get_boolean(&value));
Database::setIsAvailable(g_value_get_boolean(&value));
}
#endif
@@ -1,3 +1,15 @@
2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

* WebView/WebView.mm: Remove the call into Settings.
(-[WebView _preferencesChangedNotification:]):

2010-03-07 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Cameron Zwarich.
@@ -1305,7 +1305,6 @@ - (void)_preferencesChangedNotification:(NSNotification *)notification
settings->setMinimumFontSize([preferences minimumFontSize]);
settings->setMinimumLogicalFontSize([preferences minimumLogicalFontSize]);
settings->setPluginsEnabled([preferences arePlugInsEnabled]);
settings->setDatabasesEnabled([preferences databasesEnabled]);
#if ENABLE(DATABASE)
Database::setIsAvailable([preferences databasesEnabled]);
#endif
@@ -215,7 +215,6 @@ void QWebSettingsPrivate::apply()
#if ENABLE(DATABASE)
value = attributes.value(QWebSettings::OfflineStorageDatabaseEnabled,
global->attributes.value(QWebSettings::OfflineStorageDatabaseEnabled));
settings->setDatabasesEnabled(value);
WebCore::Database::setIsAvailable(value);
#endif

@@ -1,3 +1,15 @@
2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply): Remove the call into Settings.

2010-03-08 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

0 comments on commit 4a320b3

Please sign in to comment.