From 4abd69b35cfacc3a7899983af675bff3c8319c1d Mon Sep 17 00:00:00 2001 From: Devin Rousso Date: Fri, 13 Oct 2017 23:52:34 +0000 Subject: [PATCH] Web Inspector: fix ESLint errors https://bugs.webkit.org/show_bug.cgi?id=175065 Reviewed by Joseph Pecoraro. Removed trailing whitespace, extra parenthesis, and some unnecessary escape characters. Added missing semicolons, spacing around default values for parameters, and changed `==` to `===` where applicable. Specific changes to each file were removed for brevity. * .eslintrc: Alphabetize each list of global variables and add some missing utility functions. * UserInterface/Base/EventListener.js: * UserInterface/Base/EventListenerSet.js: * UserInterface/Base/Main.js: * UserInterface/Base/Setting.js: * UserInterface/Base/TextUtilities.js: * UserInterface/Base/URLUtilities.js: * UserInterface/Base/Utilities.js: * UserInterface/Base/YieldableTask.js: * UserInterface/Controllers/AppControllerBase.js: * UserInterface/Controllers/CanvasManager.js: * UserInterface/Controllers/CodeMirrorCompletionController.js: * UserInterface/Controllers/DOMDebuggerManager.js: * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js: * UserInterface/Controllers/RuntimeManager.js: * UserInterface/Controllers/SourceMapManager.js: * UserInterface/Debug/DebugContentView.js: * UserInterface/Debug/UncaughtExceptionReporter.js: * UserInterface/Models/CSSKeywordCompletions.js: * UserInterface/Models/DOMNode.js: * UserInterface/Models/DOMNodeStyles.js: * UserInterface/Models/KeyboardShortcut.js: * UserInterface/Models/ProfileNode.js: * UserInterface/Models/Resource.js: * UserInterface/Models/ResourceCollection.js: * UserInterface/Models/Script.js: * UserInterface/Models/ScriptSyntaxTree.js: * UserInterface/Models/ScriptTimelineRecord.js: * UserInterface/Protocol/Connection.js: * UserInterface/Test/FrontendTestHarness.js: * UserInterface/Test/TestHarness.js: * UserInterface/Views/CSSStyleDeclarationSection.js: * UserInterface/Views/ChartDetailsSectionRow.js: * UserInterface/Views/CodeMirrorAdditions.js: * UserInterface/Views/CodeMirrorFormatters.js: * UserInterface/Views/CodeMirrorRegexMode.js: * UserInterface/Views/ContentBrowserTabContentView.js: * UserInterface/Views/DataGrid.js: * UserInterface/Views/DataGridNode.js: * UserInterface/Views/FindBanner.js: * UserInterface/Views/GroupNavigationItem.js: * UserInterface/Views/HierarchicalPathNavigationItem.js: * UserInterface/Views/NetworkTableContentView.js: * UserInterface/Views/NetworkTimelineView.js: * UserInterface/Views/ObjectTreePropertyTreeElement.js: * UserInterface/Views/ObjectTreeView.js: * UserInterface/Views/RecordingContentView.js: * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js: * UserInterface/Views/ResourceCookiesContentView.js: * UserInterface/Views/ResourceDetailsSection.js: * UserInterface/Views/ResourceHeadersContentView.js: * UserInterface/Views/ResourceTimelineDataGridNode.js: * UserInterface/Views/SettingEditor.js: * UserInterface/Views/Sidebar.js: * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: * UserInterface/Views/Table.js: * UserInterface/Views/TextEditor.js: * UserInterface/Views/TimelineDataGridNode.js: * UserInterface/Views/TreeElement.js: * UserInterface/Views/TreeOutline.js: * UserInterface/Views/WebSocketDataGridNode.js: * UserInterface/Workers/Formatter/EsprimaFormatter.js: * UserInterface/Workers/Formatter/FormatterWorker.js: Canonical link: https://commits.webkit.org/194515@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223308 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebInspectorUI/.eslintrc | 78 +++++++++++++----- Source/WebInspectorUI/ChangeLog | 79 +++++++++++++++++++ .../UserInterface/Base/EventListener.js | 2 +- .../UserInterface/Base/EventListenerSet.js | 2 +- .../WebInspectorUI/UserInterface/Base/Main.js | 23 +++--- .../UserInterface/Base/Setting.js | 4 +- .../UserInterface/Base/TextUtilities.js | 2 +- .../UserInterface/Base/URLUtilities.js | 4 +- .../UserInterface/Base/Utilities.js | 8 +- .../UserInterface/Base/YieldableTask.js | 2 +- .../Controllers/AppControllerBase.js | 2 +- .../Controllers/CanvasManager.js | 2 +- .../CodeMirrorCompletionController.js | 4 +- .../Controllers/DOMDebuggerManager.js | 2 +- .../JavaScriptRuntimeCompletionProvider.js | 8 +- .../Controllers/RuntimeManager.js | 4 +- .../Controllers/SourceMapManager.js | 2 +- .../UserInterface/Debug/DebugContentView.js | 2 +- .../Debug/UncaughtExceptionReporter.js | 2 +- .../Models/CSSKeywordCompletions.js | 4 +- .../UserInterface/Models/DOMNode.js | 2 +- .../UserInterface/Models/DOMNodeStyles.js | 2 +- .../UserInterface/Models/KeyboardShortcut.js | 2 +- .../UserInterface/Models/ProfileNode.js | 2 +- .../UserInterface/Models/Resource.js | 2 +- .../Models/ResourceCollection.js | 2 +- .../UserInterface/Models/Script.js | 4 +- .../UserInterface/Models/ScriptSyntaxTree.js | 2 +- .../Models/ScriptTimelineRecord.js | 2 +- .../UserInterface/Protocol/Connection.js | 2 +- .../UserInterface/Test/FrontendTestHarness.js | 2 +- .../UserInterface/Test/TestHarness.js | 12 +-- .../Views/CSSStyleDeclarationSection.js | 8 +- .../Views/ChartDetailsSectionRow.js | 2 +- .../Views/CodeMirrorAdditions.js | 2 +- .../Views/CodeMirrorFormatters.js | 6 +- .../Views/CodeMirrorRegexMode.js | 2 +- .../Views/ContentBrowserTabContentView.js | 4 +- .../UserInterface/Views/DataGrid.js | 4 +- .../UserInterface/Views/DataGridNode.js | 4 +- .../UserInterface/Views/FindBanner.js | 2 +- .../Views/GroupNavigationItem.js | 4 +- .../Views/HierarchicalPathNavigationItem.js | 2 +- .../Views/NetworkTableContentView.js | 4 +- .../Views/NetworkTimelineView.js | 4 +- .../Views/ObjectTreePropertyTreeElement.js | 2 +- .../UserInterface/Views/ObjectTreeView.js | 2 +- .../Views/RecordingContentView.js | 2 +- .../RenderingFrameTimelineOverviewGraph.js | 4 +- .../Views/ResourceCookiesContentView.js | 6 +- .../Views/ResourceDetailsSection.js | 2 +- .../Views/ResourceHeadersContentView.js | 4 +- .../Views/ResourceTimelineDataGridNode.js | 2 +- .../UserInterface/Views/SettingEditor.js | 2 +- .../UserInterface/Views/Sidebar.js | 2 +- .../SpreadsheetCSSStyleDeclarationSection.js | 6 +- .../UserInterface/Views/Table.js | 2 +- .../UserInterface/Views/TextEditor.js | 2 +- .../Views/TimelineDataGridNode.js | 4 +- .../UserInterface/Views/TreeElement.js | 2 +- .../UserInterface/Views/TreeOutline.js | 2 +- .../Views/WebSocketDataGridNode.js | 2 +- .../Workers/Formatter/EsprimaFormatter.js | 2 +- .../Workers/Formatter/FormatterWorker.js | 2 +- 64 files changed, 241 insertions(+), 131 deletions(-) diff --git a/Source/WebInspectorUI/.eslintrc b/Source/WebInspectorUI/.eslintrc index d4c0204b0861..891f34108c9e 100644 --- a/Source/WebInspectorUI/.eslintrc +++ b/Source/WebInspectorUI/.eslintrc @@ -28,7 +28,10 @@ "env": { "browser": true, "worker": true, - "ecmaVersion": 2017, + "es6": true, + }, + "parserOptions": { + "ecmaVersion": 2018, }, "globals": { // Agents @@ -54,6 +57,9 @@ "TimelineAgent": true, "WorkerAgent": true, + // Namespace + "WI": true, + // WebInspector "AsyncTestSuite": true, "Formatter": true, @@ -76,50 +82,82 @@ // Externals "CodeMirror": true, + "THREE": true, "esprima": true, + // Formatters + "ESTreeWalker": true, + "EsprimaFormatter": true, + "FormatterWorker": true, + + // Heap Snapshot + "HeapSnapshot": true, + "HeapSnapshotDiff": true, + "HeapSnapshotWorker": true, + // DOM "CSSPrimitiveValue": true, "Exception": true, "WebKitPoint": true, // Utilities - "figureDash": true, + "appendWebInspectorConsoleEvaluationSourceURL": true, + "appendWebInspectorSourceURL": true, + "clamp": true, + "doubleQuotedString": true, "ellipsis": true, "emDash": true, "enDash": true, - "clamp": true, - "isEnterKey": true, - "isEmptyObject": true, + "figureDash": true, + "handlePromiseException": true, "insertionIndexForObjectInListSortedByFunction": true, + "insertObjectIntoSortedArray": true, + "isEmptyObject": true, + "isEnterKey": true, "isFunctionStringNativeCode": true, - "parseMIMEType": true, - "doubleQuotedString": true, - "isWebKitInternalScript": true, - "isWebInspectorInternalScript": true, + "isTextLikelyMinified": true, "isWebInspectorConsoleEvaluationScript": true, - "appendWebInspectorSourceURL": true, - "appendWebInspectorConsoleEvaluationSourceURL": true, + "isWebInspectorInternalScript": true, + "isWebKitInternalScript": true, + "multiplicationSign": true, + "parseMIMEType": true, + "resolveDotsInPath": true, + "simpleGlobStringToRegExp": true, "timestamp": true, - "handlePromiseException": true, - "insertObjectIntoSortedArray": true, + "zeroWidthSpace": true, + + // DOM Utilities + "createSVGElement": true, // Image Utilities "platformImagePath": true, - "wrappedSVGDocument": true, - "createSVGElement": true, "useSVGSymbol": true, + "wrappedSVGDocument": true, // URL Utilities "absoluteURL": true, - "parseQueryString": true, - "parseURL": true, - "parseSecurityOrigin": true, - "removeURLFragment": true, "decodeBase64ToBlob": true, - "relativePath": true, "parseDataURL": true, "parseLocationQueryParameters": true, + "parseQueryString": true, + "parseSecurityOrigin": true, + "parseURL": true, + "relativePath": true, + "removeURLFragment": true, + + // Formatter Utilities + "isECMAScriptLineTerminator": true, + "isECMAScriptWhitespace": true, + + // Debug + "handleInternalException": true, + + // CodeMirror + "createCodeMirrorColorTextMarkers": true, + "createCodeMirrorCubicBezierTextMarkers": true, + "createCodeMirrorGradientTextMarkers": true, + "createCodeMirrorSpringTextMarkers": true, + "createCodeMirrorVariableTextMarkers": true, }, "rules": { "array-bracket-spacing": [2, "never"], diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog index a9c4b5279b3c..4133d55c7617 100644 --- a/Source/WebInspectorUI/ChangeLog +++ b/Source/WebInspectorUI/ChangeLog @@ -1,3 +1,82 @@ +2017-10-13 Devin Rousso + + Web Inspector: fix ESLint errors + https://bugs.webkit.org/show_bug.cgi?id=175065 + + Reviewed by Joseph Pecoraro. + + Removed trailing whitespace, extra parenthesis, and some unnecessary escape characters. + Added missing semicolons, spacing around default values for parameters, and changed `==` to + `===` where applicable. + + Specific changes to each file were removed for brevity. + + * .eslintrc: + Alphabetize each list of global variables and add some missing utility functions. + + * UserInterface/Base/EventListener.js: + * UserInterface/Base/EventListenerSet.js: + * UserInterface/Base/Main.js: + * UserInterface/Base/Setting.js: + * UserInterface/Base/TextUtilities.js: + * UserInterface/Base/URLUtilities.js: + * UserInterface/Base/Utilities.js: + * UserInterface/Base/YieldableTask.js: + * UserInterface/Controllers/AppControllerBase.js: + * UserInterface/Controllers/CanvasManager.js: + * UserInterface/Controllers/CodeMirrorCompletionController.js: + * UserInterface/Controllers/DOMDebuggerManager.js: + * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js: + * UserInterface/Controllers/RuntimeManager.js: + * UserInterface/Controllers/SourceMapManager.js: + * UserInterface/Debug/DebugContentView.js: + * UserInterface/Debug/UncaughtExceptionReporter.js: + * UserInterface/Models/CSSKeywordCompletions.js: + * UserInterface/Models/DOMNode.js: + * UserInterface/Models/DOMNodeStyles.js: + * UserInterface/Models/KeyboardShortcut.js: + * UserInterface/Models/ProfileNode.js: + * UserInterface/Models/Resource.js: + * UserInterface/Models/ResourceCollection.js: + * UserInterface/Models/Script.js: + * UserInterface/Models/ScriptSyntaxTree.js: + * UserInterface/Models/ScriptTimelineRecord.js: + * UserInterface/Protocol/Connection.js: + * UserInterface/Test/FrontendTestHarness.js: + * UserInterface/Test/TestHarness.js: + * UserInterface/Views/CSSStyleDeclarationSection.js: + * UserInterface/Views/ChartDetailsSectionRow.js: + * UserInterface/Views/CodeMirrorAdditions.js: + * UserInterface/Views/CodeMirrorFormatters.js: + * UserInterface/Views/CodeMirrorRegexMode.js: + * UserInterface/Views/ContentBrowserTabContentView.js: + * UserInterface/Views/DataGrid.js: + * UserInterface/Views/DataGridNode.js: + * UserInterface/Views/FindBanner.js: + * UserInterface/Views/GroupNavigationItem.js: + * UserInterface/Views/HierarchicalPathNavigationItem.js: + * UserInterface/Views/NetworkTableContentView.js: + * UserInterface/Views/NetworkTimelineView.js: + * UserInterface/Views/ObjectTreePropertyTreeElement.js: + * UserInterface/Views/ObjectTreeView.js: + * UserInterface/Views/RecordingContentView.js: + * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js: + * UserInterface/Views/ResourceCookiesContentView.js: + * UserInterface/Views/ResourceDetailsSection.js: + * UserInterface/Views/ResourceHeadersContentView.js: + * UserInterface/Views/ResourceTimelineDataGridNode.js: + * UserInterface/Views/SettingEditor.js: + * UserInterface/Views/Sidebar.js: + * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: + * UserInterface/Views/Table.js: + * UserInterface/Views/TextEditor.js: + * UserInterface/Views/TimelineDataGridNode.js: + * UserInterface/Views/TreeElement.js: + * UserInterface/Views/TreeOutline.js: + * UserInterface/Views/WebSocketDataGridNode.js: + * UserInterface/Workers/Formatter/EsprimaFormatter.js: + * UserInterface/Workers/Formatter/FormatterWorker.js: + 2017-10-13 Nikita Vasilyev Web Inspector: Styles Redesign: hook up autocompletion to property names and values diff --git a/Source/WebInspectorUI/UserInterface/Base/EventListener.js b/Source/WebInspectorUI/UserInterface/Base/EventListener.js index 65c7e3f9cbf7..2519551d27bc 100644 --- a/Source/WebInspectorUI/UserInterface/Base/EventListener.js +++ b/Source/WebInspectorUI/UserInterface/Base/EventListener.js @@ -40,7 +40,7 @@ WI.EventListener = class EventListener { console.assert(!this._emitter && !this._callback, "EventListener already bound to a callback.", this); console.assert(emitter, `Missing event emitter for event: ${type}.`); - console.assert(type, `Missing event type.`); + console.assert(type, "Missing event type."); console.assert(callback, `Missing callback for event: ${type}.`); var emitterIsValid = emitter && (emitter instanceof WI.Object || emitter instanceof Node || (typeof emitter.addEventListener === "function")); console.assert(emitterIsValid, "Event emitter ", emitter, ` (type: ${type}) is null or does not implement Node or WI.Object.`); diff --git a/Source/WebInspectorUI/UserInterface/Base/EventListenerSet.js b/Source/WebInspectorUI/UserInterface/Base/EventListenerSet.js index 6129b1c29430..63c3c63d5d50 100644 --- a/Source/WebInspectorUI/UserInterface/Base/EventListenerSet.js +++ b/Source/WebInspectorUI/UserInterface/Base/EventListenerSet.js @@ -45,7 +45,7 @@ WI.EventListenerSet = class EventListenerSet register(emitter, type, callback, thisObject, usesCapture) { console.assert(emitter, `Missing event emitter for event: ${type}.`); - console.assert(type, `Missing event type.`); + console.assert(type, "Missing event type."); console.assert(callback, `Missing callback for event: ${type}.`); var emitterIsValid = emitter && (emitter instanceof WI.Object || emitter instanceof Node || (typeof emitter.addEventListener === "function")); console.assert(emitterIsValid, "Event emitter ", emitter, ` (type: ${type}) is null or does not implement Node or WI.Object.`); diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js index 170fe5fa4a75..cb13144ebc68 100644 --- a/Source/WebInspectorUI/UserInterface/Base/Main.js +++ b/Source/WebInspectorUI/UserInterface/Base/Main.js @@ -375,7 +375,6 @@ WI.contentLoaded = function() reloadToolTip = WI.UIString("Restart (%s)").format(this._reloadPageKeyboardShortcut.displayName); else reloadToolTip = WI.UIString("Reload page (%s)\nReload page ignoring cache (%s)").format(this._reloadPageKeyboardShortcut.displayName, this._reloadPageFromOriginKeyboardShortcut.displayName); - this._reloadToolbarButton = new WI.ButtonToolbarItem("reload", reloadToolTip, "Images/ReloadToolbar.svg"); this._reloadToolbarButton.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._reloadToolbarButtonClicked, this); @@ -720,7 +719,7 @@ WI.updateWindowTitle = function() var lastPathComponent; try { lastPathComponent = decodeURIComponent(urlComponents.lastPathComponent || ""); - } catch (e) { + } catch { lastPathComponent = urlComponents.lastPathComponent; } @@ -992,8 +991,8 @@ WI.showNetworkTab = function() let tabContentView; if (WI.settings.experimentalEnableNewNetworkTab.value) { tabContentView = this.tabBrowser.bestTabContentViewForClass(WI.NetworkTabContentView); - if (!tabBrowser) - tabBrowser = new WI.NetworkTabContentView; + if (!tabContentView) + tabContentView = new WI.NetworkTabContentView; } else { tabContentView = this.tabBrowser.bestTabContentViewForClass(WI.LegacyNetworkTabContentView); if (!tabContentView) @@ -1865,7 +1864,7 @@ WI._updateInspectModeToolbarButton = function() } this._inspectModeToolbarButton.hidden = false; -} +}; WI._toggleInspectMode = function(event) { @@ -2030,7 +2029,7 @@ WI._populateFind = function(event) return; contentBrowser.handlePopulateFindShortcut(); -} +}; WI._findNext = function(event) { @@ -2048,7 +2047,7 @@ WI._findNext = function(event) return; contentBrowser.handleFindNextShortcut(); -} +}; WI._findPrevious = function(event) { @@ -2066,7 +2065,7 @@ WI._findPrevious = function(event) return; contentBrowser.handleFindPreviousShortcut(); -} +}; WI._copy = function(event) { @@ -2207,7 +2206,7 @@ WI._enableControlFlowProfilerSettingChanged = function(event) WI._resourceCachingDisabledSettingChanged = function(event) { NetworkAgent.setResourceCachingDisabled(this.resourceCachingDisabledSetting.value); -} +}; WI.elementDragStart = function(element, dividerDrag, elementDragEnd, event, cursor, eventTarget) { @@ -2359,7 +2358,7 @@ WI.linkifyURLAsNode = function(url, linkText, classes) if (!linkText) linkText = url; - classes = (classes ? classes + " " : ""); + classes = classes ? classes + " " : ""; var a = document.createElement("a"); a.href = url; @@ -2634,13 +2633,13 @@ WI._sharedWindowKeydownListener = function(event) } }; -WI.reportInternalError = function(errorOrString, details={}) +WI.reportInternalError = function(errorOrString, details = {}) { // The 'details' object includes additional information from the caller as free-form string keys and values. // Each key and value will be shown in the uncaught exception reporter, console error message, or in // a pre-filled bug report generated for this internal error. - let error = (errorOrString instanceof Error) ? errorOrString : new Error(errorOrString); + let error = errorOrString instanceof Error ? errorOrString : new Error(errorOrString); error.details = details; // The error will be displayed in the Uncaught Exception Reporter sheet if DebugUI is enabled. diff --git a/Source/WebInspectorUI/UserInterface/Base/Setting.js b/Source/WebInspectorUI/UserInterface/Base/Setting.js index 037c4ecef054..7c91b1b0a14e 100644 --- a/Source/WebInspectorUI/UserInterface/Base/Setting.js +++ b/Source/WebInspectorUI/UserInterface/Base/Setting.js @@ -61,7 +61,7 @@ WI.Setting = class Setting extends WI.Object if (!window.InspectorTest && window.localStorage && this._localStorageKey in window.localStorage) { try { this._value = JSON.parse(window.localStorage[this._localStorageKey]); - } catch (e) { + } catch { delete window.localStorage[this._localStorageKey]; } } @@ -83,7 +83,7 @@ WI.Setting = class Setting extends WI.Object delete window.localStorage[this._localStorageKey]; else window.localStorage[this._localStorageKey] = JSON.stringify(this._value); - } catch (e) { + } catch { console.error("Error saving setting with name: " + this._name); } } diff --git a/Source/WebInspectorUI/UserInterface/Base/TextUtilities.js b/Source/WebInspectorUI/UserInterface/Base/TextUtilities.js index bad1c4ef940a..2f41532a4ac3 100644 --- a/Source/WebInspectorUI/UserInterface/Base/TextUtilities.js +++ b/Source/WebInspectorUI/UserInterface/Base/TextUtilities.js @@ -40,7 +40,7 @@ WI.rangeForNextCSSNameOrValue = function(text, index = 0) { // Don't select leading/trailing whitespace. from += substring.match(/^\s*/)[0].length; - to -= substring.match(/[\s\;]*$/)[0].length; + to -= substring.match(/[\s;]*$/)[0].length; return {from, to}; }; diff --git a/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js b/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js index afbd45181181..6ae0c9d8bfc7 100644 --- a/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js +++ b/Source/WebInspectorUI/UserInterface/Base/URLUtilities.js @@ -202,7 +202,7 @@ function parseQueryString(queryString, arrayResult) try { // Replace "+" with " " then decode percent encoded values. return decodeURIComponent(string.replace(/\+/g, " ")); - } catch (e) { + } catch { return string; } } @@ -231,7 +231,7 @@ WI.displayNameForURL = function(url, urlComponents) var displayName; try { displayName = decodeURIComponent(urlComponents.lastPathComponent || ""); - } catch (e) { + } catch { displayName = urlComponents.lastPathComponent; } diff --git a/Source/WebInspectorUI/UserInterface/Base/Utilities.js b/Source/WebInspectorUI/UserInterface/Base/Utilities.js index 112a7a8146d8..0c9e7189a36e 100644 --- a/Source/WebInspectorUI/UserInterface/Base/Utilities.js +++ b/Source/WebInspectorUI/UserInterface/Base/Utilities.js @@ -281,7 +281,7 @@ Object.defineProperty(Node.prototype, "rangeOfWord", } if (node.nodeType === Node.TEXT_NODE) { - var start = (node === this ? (offset - 1) : (node.nodeValue.length - 1)); + let start = node === this ? (offset - 1) : (node.nodeValue.length - 1); for (var i = start; i >= 0; --i) { if (stopCharacters.indexOf(node.nodeValue[i]) !== -1) { startNode = node; @@ -316,7 +316,7 @@ Object.defineProperty(Node.prototype, "rangeOfWord", } if (node.nodeType === Node.TEXT_NODE) { - var start = (node === this ? offset : 0); + let start = node === this ? offset : 0; for (var i = start; i < node.nodeValue.length; ++i) { if (stopCharacters.indexOf(node.nodeValue[i]) !== -1) { endNode = node; @@ -1572,7 +1572,7 @@ function insertObjectIntoSortedArray(object, array, comparator) function decodeBase64ToBlob(base64Data, mimeType) { - mimeType = mimeType || ''; + mimeType = mimeType || ""; const sliceSize = 1024; var byteCharacters = atob(base64Data); @@ -1585,7 +1585,7 @@ function decodeBase64ToBlob(base64Data, mimeType) var end = Math.min(begin + sliceSize, bytesLength); var bytes = new Array(end - begin); - for (var offset = begin, i = 0 ; offset < end; ++i, ++offset) + for (var offset = begin, i = 0; offset < end; ++i, ++offset) bytes[i] = byteCharacters[offset].charCodeAt(0); byteArrays[sliceIndex] = new Uint8Array(bytes); diff --git a/Source/WebInspectorUI/UserInterface/Base/YieldableTask.js b/Source/WebInspectorUI/UserInterface/Base/YieldableTask.js index b303419a6e6f..0ac36a555ae0 100644 --- a/Source/WebInspectorUI/UserInterface/Base/YieldableTask.js +++ b/Source/WebInspectorUI/UserInterface/Base/YieldableTask.js @@ -25,7 +25,7 @@ WI.YieldableTask = class YieldableTask { - constructor(delegate, items, options={}) + constructor(delegate, items, options = {}) { let {workInterval, idleInterval} = options; console.assert(!workInterval || workInterval > 0, workInterval); diff --git a/Source/WebInspectorUI/UserInterface/Controllers/AppControllerBase.js b/Source/WebInspectorUI/UserInterface/Controllers/AppControllerBase.js index 7403e7af499e..6073cad068f2 100644 --- a/Source/WebInspectorUI/UserInterface/Controllers/AppControllerBase.js +++ b/Source/WebInspectorUI/UserInterface/Controllers/AppControllerBase.js @@ -30,7 +30,7 @@ WI.DebuggableType = { WI.NotImplementedError = class NotImplementedError extends Error { - constructor(message="This method is not implemented.") + constructor(message = "This method is not implemented.") { super(message); } diff --git a/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js b/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js index 1856a05766af..9dd02d1d3b70 100644 --- a/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js +++ b/Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js @@ -158,7 +158,7 @@ WI.CanvasManager = class CanvasManager extends WI.Object if (!canvas) return; - let recording = recordingPayload ? WI.Recording.fromPayload(recordingPayload) : null + let recording = recordingPayload ? WI.Recording.fromPayload(recordingPayload) : null; if (recording) recording.source = canvas; diff --git a/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js b/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js index 0407055e6329..83c13d5a126f 100644 --- a/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js +++ b/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js @@ -256,7 +256,7 @@ WI.CodeMirrorCompletionController = class CodeMirrorCompletionController extends this._commitCompletionHint(); // The clicked hint marker causes the editor to loose focus. Restore it so the user can keep typing. - setTimeout(() => { this._codeMirror.focus() }, 0); + setTimeout(() => { this._codeMirror.focus(); }, 0); }); this._completionHintMarker = this._codeMirror.setUniqueBookmark(position, {widget: container, insertLeft: true}); @@ -563,7 +563,7 @@ WI.CodeMirrorCompletionController = class CodeMirrorCompletionController extends } return this._codeMirror.getTokenAt({line: lineNumber, ch: token.start ? token.start : Number.MAX_VALUE}); - } + }; // Inside a function, determine the function name. if (token.state.state === "parens") { diff --git a/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js b/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js index abe48b0bd042..068b1993e1f8 100644 --- a/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js +++ b/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js @@ -262,7 +262,7 @@ WI.DOMDebuggerManager = class DOMDebuggerManager extends WI.Object domBreakpointNodeIdentifierMap.delete(nodeIdentifier); if (!domBreakpointNodeIdentifierMap.size) - this._domBreakpointFrameIdentifierMap.delete(frameIdentifier) + this._domBreakpointFrameIdentifierMap.delete(frameIdentifier); } _detachBreakpointsForFrame(frame) diff --git a/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js b/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js index c935edb3eed9..69cb3f7a957e 100644 --- a/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js +++ b/Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js @@ -144,9 +144,7 @@ WI.JavaScriptRuntimeCompletionProvider = class JavaScriptRuntimeCompletionProvid for (var i = 0; i < names.length; ++i) resultSet[names[i]] = true; } - } catch (e) { - // Ignore - } + } catch { } } if (arrayLength) @@ -175,9 +173,7 @@ WI.JavaScriptRuntimeCompletionProvider = class JavaScriptRuntimeCompletionProvid var names = Object.getOwnPropertyNames(o); for (var i = 0; i < names.length; ++i) resultSet[names[i]] = true; - } catch (e) { - // Ignore - } + } catch { } } return resultSet; diff --git a/Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js b/Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js index 0f9bbaeba4ea..6c515164f70c 100644 --- a/Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js +++ b/Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js @@ -174,12 +174,12 @@ WI.RuntimeManager = class RuntimeManager extends WI.Object try { esprima.parse(originalExpression); return originalExpression; - } catch (error) { } + } catch { } // Do not transform if the async function version does not parse. try { esprimaSyntaxTree = esprima.parse("(async function(){" + originalExpression + "})"); - } catch (error) { + } catch { return originalExpression; } diff --git a/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js b/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js index ceb6af6f38c2..b0a9e39441dc 100644 --- a/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js +++ b/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js @@ -113,7 +113,7 @@ WI.SourceMapManager = class SourceMapManager extends WI.Object var baseURL = sourceMapURL.startsWith("data:") ? originalSourceCode.url : sourceMapURL; var sourceMap = new WI.SourceMap(baseURL, payload, originalSourceCode); this._loadAndParseSucceeded(sourceMapURL, sourceMap); - } catch (e) { + } catch { this._loadAndParseFailed(sourceMapURL); } } diff --git a/Source/WebInspectorUI/UserInterface/Debug/DebugContentView.js b/Source/WebInspectorUI/UserInterface/Debug/DebugContentView.js index 654a410d9848..d2b8b0654b7c 100644 --- a/Source/WebInspectorUI/UserInterface/Debug/DebugContentView.js +++ b/Source/WebInspectorUI/UserInterface/Debug/DebugContentView.js @@ -54,4 +54,4 @@ WI.DebugContentView = class DebugContentView extends WI.ContentView console.debug(`closed: ${this._string}`); super.closed(); } -} +}; diff --git a/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js b/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js index e8365a0be613..40f905cd2f0f 100644 --- a/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js +++ b/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js @@ -182,7 +182,7 @@ function createErrorSheet() { let inspectedPageURL = null; try { inspectedPageURL = WI.frameResourceManager.mainFrame.url; - } catch (e) { } + } catch { } let topLevelItems = [ `Inspected URL: ${inspectedPageURL || "(unknown)"}`, diff --git a/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js b/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js index 7f879fdee0a5..019e3fd8a0f4 100644 --- a/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js +++ b/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js @@ -70,7 +70,7 @@ WI.CSSKeywordCompletions.forFunction = function(functionName) suggestions = []; else if (functionName === "calc" || functionName === "min" || functionName === "max") suggestions = suggestions.concat(["calc()", "min()", "max()"]); - else if (functionName == "env") + else if (functionName === "env") suggestions = suggestions.concat(["safe-area-inset-top", "safe-area-inset-right", "safe-area-inset-bottom", "safe-area-inset-left"]); else if (functionName === "image-set") suggestions.push("url()"); @@ -82,7 +82,7 @@ WI.CSSKeywordCompletions.forFunction = function(functionName) } return new WI.CSSCompletions(suggestions, true); -} +}; WI.CSSKeywordCompletions.addCustomCompletions = function(properties) { diff --git a/Source/WebInspectorUI/UserInterface/Models/DOMNode.js b/Source/WebInspectorUI/UserInterface/Models/DOMNode.js index 5a89e780be2f..04ae31945948 100644 --- a/Source/WebInspectorUI/UserInterface/Models/DOMNode.js +++ b/Source/WebInspectorUI/UserInterface/Models/DOMNode.js @@ -588,7 +588,7 @@ WI.DOMNode = class DOMNode extends WI.Object id = CSS.escape(id); if (/[\s'"]/.test(id)) - return `[id=\"${id}\"]`; + return `[id="${id}"]`; return `#${id}`; } diff --git a/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js b/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js index 63f5297aadf8..ca6536ef73de 100644 --- a/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js +++ b/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js @@ -773,7 +773,7 @@ WI.DOMNodeStyles = class DOMNodeStyles extends WI.Object if (styleSheet) { if (!sourceCodeLocation && styleSheet.isInspectorStyleSheet()) - sourceCodeLocation = styleSheet.createSourceCodeLocation(sourceRange.startLine, sourceRange.startColumn) + sourceCodeLocation = styleSheet.createSourceCodeLocation(sourceRange.startLine, sourceRange.startColumn); sourceCodeLocation = styleSheet.offsetSourceCodeLocation(sourceCodeLocation); } diff --git a/Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js b/Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js index 3d7fda8b8e82..ea417f12a8cf 100644 --- a/Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js +++ b/Source/WebInspectorUI/UserInterface/Models/KeyboardShortcut.js @@ -263,5 +263,5 @@ WI.KeyboardShortcut.Key = { LeftCurlyBrace: new WI.Key(219, "{"), Backslash: new WI.Key(220, "\\"), RightCurlyBrace: new WI.Key(221, "}"), - SingleQuote: new WI.Key(222, "\'") + SingleQuote: new WI.Key(222, "'") }; diff --git a/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js b/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js index b4f42ed913eb..d31c24476562 100644 --- a/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js +++ b/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js @@ -168,7 +168,7 @@ WI.ProfileNode = class ProfileNode endTime: this._endTime, selfTime: this._selfTime, totalTime: this._totalTime, - averageTime: (this._selfTime / this._callCount), + averageTime: this._selfTime / this._callCount, }; } diff --git a/Source/WebInspectorUI/UserInterface/Models/Resource.js b/Source/WebInspectorUI/UserInterface/Models/Resource.js index 9b960becc790..69063b1493a2 100644 --- a/Source/WebInspectorUI/UserInterface/Models/Resource.js +++ b/Source/WebInspectorUI/UserInterface/Models/Resource.js @@ -544,7 +544,7 @@ WI.Resource = class Resource extends WI.SourceCode get estimatedNetworkEncodedSize() { - let exact = this.networkEncodedSize; + let exact = this.networkEncodedSize; if (!isNaN(exact)) return exact; diff --git a/Source/WebInspectorUI/UserInterface/Models/ResourceCollection.js b/Source/WebInspectorUI/UserInterface/Models/ResourceCollection.js index 140ccbcf7227..13e2f9910258 100644 --- a/Source/WebInspectorUI/UserInterface/Models/ResourceCollection.js +++ b/Source/WebInspectorUI/UserInterface/Models/ResourceCollection.js @@ -197,7 +197,7 @@ WI.ResourceCollection.TypeVerifier = { Stylesheet: (object) => { if (WI.Collection.TypeVerifier.CSSStyleSheet(object)) return true; - return WI.Collection.TypeVerifier.Resource(object) && object.type === WI.Resource.Type.Stylesheet + return WI.Collection.TypeVerifier.Resource(object) && object.type === WI.Resource.Type.Stylesheet; }, Image: (object) => WI.Collection.TypeVerifier.Resource(object) && object.type === WI.Resource.Type.Image, Font: (object) => WI.Collection.TypeVerifier.Resource(object) && object.type === WI.Resource.Type.Font, diff --git a/Source/WebInspectorUI/UserInterface/Models/Script.js b/Source/WebInspectorUI/UserInterface/Models/Script.js index b5dec4a4ddd0..b1910e8661c4 100644 --- a/Source/WebInspectorUI/UserInterface/Models/Script.js +++ b/Source/WebInspectorUI/UserInterface/Models/Script.js @@ -274,9 +274,7 @@ WI.Script = class Script extends WI.SourceCode if (resource) return resource; } - } catch (e) { - // Ignore possible URIErrors. - } + } catch { } return null; } diff --git a/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js b/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js index 50e76b16e8ba..5951a9c01ca6 100644 --- a/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js +++ b/Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js @@ -843,7 +843,7 @@ WI.ScriptSyntaxTree = class ScriptSyntaxTree computed: node.computed }; if (result.kind === "get" || result.kind === "set" || result.method) - result.value.typeProfilingReturnDivot = node.range[0]; // "g" in "get" or "s" in "set" or "[" in "['computed']" method or "m" in "methodName". + result.value.typeProfilingReturnDivot = node.range[0]; // "g" in "get" or "s" in "set" or "[" in "['computed']" method or "m" in "methodName". break; case "RestElement": result = { diff --git a/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js b/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js index 5d87f98c36e3..9e402eab7dbf 100644 --- a/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js +++ b/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js @@ -342,7 +342,7 @@ WI.ScriptTimelineRecord.EventType.displayName = function(eventType, details, inc nameMap.set("webkitplaybacktargetavailabilitychanged", "Playback Target Availability Changed"); nameMap.set("webkitpointerlockchange", "Pointer Lock Change"); nameMap.set("webkitpointerlockerror", "Pointer Lock Error"); - nameMap.set("webkitregionlayoutupdate", "Region Layout Update"); // COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced by regionOversetChanged. + nameMap.set("webkitregionlayoutupdate", "Region Layout Update"); // COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced by regionOversetChanged. nameMap.set("webkitregionoversetchange", "Region Overset Change"); nameMap.set("webkitremovesourcebuffer", "Remove Source Buffer"); nameMap.set("webkitresourcetimingbufferfull", "Resource Timing Buffer Full"); diff --git a/Source/WebInspectorUI/UserInterface/Protocol/Connection.js b/Source/WebInspectorUI/UserInterface/Protocol/Connection.js index 48f69e33c5f5..8ee1b2410056 100644 --- a/Source/WebInspectorUI/UserInterface/Protocol/Connection.js +++ b/Source/WebInspectorUI/UserInterface/Protocol/Connection.js @@ -63,7 +63,7 @@ InspectorBackend.Connection = class InspectorBackendConnection dispatch(message) { - let messageObject = (typeof message === "string") ? JSON.parse(message) : message; + let messageObject = typeof message === "string" ? JSON.parse(message) : message; if ("id" in messageObject) this._dispatchResponse(messageObject); diff --git a/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js b/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js index 83ce0637ed77..d5fe1ea97f7d 100644 --- a/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js +++ b/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js @@ -120,7 +120,7 @@ FrontendTestHarness = class FrontendTestHarness extends TestHarness this.completeTest(); } - reloadPage(options={}) + reloadPage(options = {}) { console.assert(!this._testPageIsReloading); console.assert(!this._testPageReloadedOnce); diff --git a/Source/WebInspectorUI/UserInterface/Test/TestHarness.js b/Source/WebInspectorUI/UserInterface/Test/TestHarness.js index 407cca43b4dc..2652e842ed48 100644 --- a/Source/WebInspectorUI/UserInterface/Test/TestHarness.js +++ b/Source/WebInspectorUI/UserInterface/Test/TestHarness.js @@ -186,7 +186,7 @@ TestHarness = class TestHarness extends WI.Object if (message instanceof Element) return message.textContent; - return (typeof message !== "string") ? JSON.stringify(message) : message; + return typeof message !== "string" ? JSON.stringify(message) : message; } static sanitizeURL(url) @@ -195,7 +195,7 @@ TestHarness = class TestHarness extends WI.Object return "(unknown)"; let lastPathSeparator = Math.max(url.lastIndexOf("/"), url.lastIndexOf("\\")); - let location = (lastPathSeparator > 0) ? url.substr(lastPathSeparator + 1) : url; + let location = lastPathSeparator > 0 ? url.substr(lastPathSeparator + 1) : url; if (!location.length) location = "(unknown)"; @@ -211,10 +211,10 @@ TestHarness = class TestHarness extends WI.Object // Most frames are of the form "functionName@file:///foo/bar/File.js:345". // But, some frames do not have a functionName. Get rid of the file path. let nameAndURLSeparator = frame.indexOf("@"); - let frameName = (nameAndURLSeparator > 0) ? frame.substr(0, nameAndURLSeparator) : "(anonymous)"; + let frameName = nameAndURLSeparator > 0 ? frame.substr(0, nameAndURLSeparator) : "(anonymous)"; let lastPathSeparator = Math.max(frame.lastIndexOf("/"), frame.lastIndexOf("\\")); - let frameLocation = (lastPathSeparator > 0) ? frame.substr(lastPathSeparator + 1) : frame; + let frameLocation = lastPathSeparator > 0 ? frame.substr(lastPathSeparator + 1) : frame; if (!frameLocation.length) frameLocation = "unknown"; @@ -282,14 +282,14 @@ TestHarness = class TestHarness extends WI.Object let valueString = JSON.stringify(value); if (valueString.length <= maximumValueStringLength) return valueString; - } catch (e) {} + } catch { } try { let valueString = String(value); if (valueString === defaultValueString && value.constructor && value.constructor.name !== "Object") return value.constructor.name + " instance " + instanceIdentifier(value); return valueString; - } catch (e) { + } catch { return defaultValueString; } } diff --git a/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js b/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js index 0d6fdbe1cb7d..aa8ae710724c 100644 --- a/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js +++ b/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js @@ -230,9 +230,9 @@ WI.CSSStyleDeclarationSection = class CSSStyleDeclarationSection extends WI.Obje case WI.CSSStyleDeclaration.Type.Rule: console.assert(this._style.ownerRule); - let selectors = this._style.ownerRule.selectors; - let matchedSelectorIndices = this._style.ownerRule.matchedSelectorIndices; - let alwaysMatch = !matchedSelectorIndices.length; + var selectors = this._style.ownerRule.selectors; + var matchedSelectorIndices = this._style.ownerRule.matchedSelectorIndices; + var alwaysMatch = !matchedSelectorIndices.length; if (selectors.length) { let hasMatchingPseudoElementSelector = false; for (let i = 0; i < selectors.length; ++i) { @@ -452,7 +452,7 @@ WI.CSSStyleDeclarationSection = class CSSStyleDeclarationSection extends WI.Obje function parseTextForRule(text) { - let containsBraces = /[\{\}]/; + let containsBraces = /[{}]/; if (!containsBraces.test(text)) return []; diff --git a/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js b/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js index 4b75f2385135..987daaa00e99 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js +++ b/Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js @@ -54,7 +54,7 @@ WI.ChartDetailsSectionRow = class ChartDetailsSectionRow extends WI.DetailsSecti this._items = new Map; this._title = ""; this._chartSize = chartSize; - this._radius = (this._chartSize / 2) - 1; // Subtract one to accomodate chart stroke width. + this._radius = (this._chartSize / 2) - 1; // Subtract one to accomodate chart stroke width. this._innerRadius = innerRadiusRatio ? Math.floor(this._radius * innerRadiusRatio) : 0; this._total = 0; diff --git a/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js b/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js index 3e0b5bdf0123..c4522a59a7d6 100644 --- a/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js +++ b/Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js @@ -386,7 +386,7 @@ CodeMirror.defineExtension("hasLineClass", function(line, where, className) { // This matches the arguments to addLineClass and removeLineClass. - var classProperty = (where === "text" ? "textClass" : (where === "background" ? "bgClass" : "wrapClass")); + var classProperty = where === "text" ? "textClass" : (where === "background" ? "bgClass" : "wrapClass"); var lineInfo = this.lineInfo(line); if (!lineInfo) return false; diff --git a/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js b/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js index fba5d74d1d61..6be3d7462a67 100644 --- a/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js +++ b/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js @@ -63,7 +63,7 @@ CodeMirror.extendMode("javascript", { shouldHaveSpaceAfterLastToken: function(lastToken, lastContent, token, state, content, isComment) { - if (lastToken && /\bkeyword\b/.test(lastToken)) { // Most keywords require spaces after them, unless a '{' or ';' can come after it. + if (lastToken && /\bkeyword\b/.test(lastToken)) { // Most keywords require spaces after them, unless a '{' or ';' can come after it. if (lastContent === "else") return true; if (lastContent === "catch") @@ -302,7 +302,7 @@ CodeMirror.extendMode("javascript", { // Signal for when we will be entering an if. if (token && state.lexical.type === "form" && state.lexical.prev && state.lexical.prev !== "form" && /\bkeyword\b/.test(token)) - state._jsPrettyPrint.enteringIf = (content === "if"); + state._jsPrettyPrint.enteringIf = content === "if"; }, modifyStateForTokenPost: function(lastToken, lastContent, token, state, content, isComment) @@ -522,7 +522,7 @@ CodeMirror.extendMode("css-rule", { // Add new line before a regular property like `display`. if (/\bproperty\b/.test(token)) - return !(/\bmeta\b/.test(lastToken)); + return !/\bmeta\b/.test(lastToken); // Add new line before a CSS variable like `--foo`. if (state.state === "maybeprop" && /\bvariable-2\b/.test(token)) diff --git a/Source/WebInspectorUI/UserInterface/Views/CodeMirrorRegexMode.js b/Source/WebInspectorUI/UserInterface/Views/CodeMirrorRegexMode.js index 8825e7d498ad..c431b8a3ce81 100644 --- a/Source/WebInspectorUI/UserInterface/Views/CodeMirrorRegexMode.js +++ b/Source/WebInspectorUI/UserInterface/Views/CodeMirrorRegexMode.js @@ -160,4 +160,4 @@ CodeMirror.defineMode("regex", function() { }; }); -CodeMirror.defineMIME("text/x-regex", "regex"); \ No newline at end of file +CodeMirror.defineMIME("text/x-regex", "regex"); diff --git a/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js index d3f24ee702ac..16719bce11bd 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js +++ b/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js @@ -51,7 +51,7 @@ WI.ContentBrowserTabContentView = class ContentBrowserTabContentView extends WI. if (navigationSidebarPanelConstructor) { let showToolTip = WI.UIString("Show the navigation sidebar (%s)").format(WI.navigationSidebarKeyboardShortcut.displayName); let hideToolTip = WI.UIString("Hide the navigation sidebar (%s)").format(WI.navigationSidebarKeyboardShortcut.displayName); - let image = WI.resolvedLayoutDirection() == WI.LayoutDirection.RTL ? "Images/ToggleRightSidebar.svg" : "Images/ToggleLeftSidebar.svg"; + let image = WI.resolvedLayoutDirection() === WI.LayoutDirection.RTL ? "Images/ToggleRightSidebar.svg" : "Images/ToggleLeftSidebar.svg"; this._showNavigationSidebarItem = new WI.ActivateButtonNavigationItem("toggle-navigation-sidebar", showToolTip, hideToolTip, image, 16, 16); this._showNavigationSidebarItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, WI.toggleNavigationSidebar, WI); @@ -67,7 +67,7 @@ WI.ContentBrowserTabContentView = class ContentBrowserTabContentView extends WI. if (detailsSidebarPanelConstructors && detailsSidebarPanelConstructors.length) { let showToolTip = WI.UIString("Show the details sidebar (%s)").format(WI.detailsSidebarKeyboardShortcut.displayName); let hideToolTip = WI.UIString("Hide the details sidebar (%s)").format(WI.detailsSidebarKeyboardShortcut.displayName); - let image = WI.resolvedLayoutDirection() == WI.LayoutDirection.RTL ? "Images/ToggleLeftSidebar.svg" : "Images/ToggleRightSidebar.svg"; + let image = WI.resolvedLayoutDirection() === WI.LayoutDirection.RTL ? "Images/ToggleLeftSidebar.svg" : "Images/ToggleRightSidebar.svg"; this._showDetailsSidebarItem = new WI.ActivateButtonNavigationItem("toggle-details-sidebar", showToolTip, hideToolTip, image, 16, 16); this._showDetailsSidebarItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, WI.toggleDetailsSidebar, WI); diff --git a/Source/WebInspectorUI/UserInterface/Views/DataGrid.js b/Source/WebInspectorUI/UserInterface/Views/DataGrid.js index a02aea1bba55..da01df6774d7 100644 --- a/Source/WebInspectorUI/UserInterface/Views/DataGrid.js +++ b/Source/WebInspectorUI/UserInterface/Views/DataGrid.js @@ -641,10 +641,10 @@ WI.DataGrid = class DataGrid extends WI.View for (var identifier of this.columns.keys()) { var width = Math.round(100 * widths[identifier] / totalColumnWidths); if (minPercent && width < minPercent) { - recoupPercent += (minPercent - width); + recoupPercent += minPercent - width; width = minPercent; } else if (maxPercent && width > maxPercent) { - recoupPercent -= (width - maxPercent); + recoupPercent -= width - maxPercent; width = maxPercent; } widths[identifier] = width; diff --git a/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js b/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js index 4264a45d6d55..925769d384ab 100644 --- a/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js +++ b/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js @@ -389,7 +389,7 @@ WI.DataGridNode = class DataGridNode extends WI.Object return zeroWidthSpace; // Zero width space to keep the cell from collapsing. let data = this.data[columnIdentifier]; - return (typeof data === "number") ? data.maxDecimals(2).toLocaleString() : data; + return typeof data === "number" ? data.maxDecimals(2).toLocaleString() : data; } elementWithColumnIdentifier(columnIdentifier) @@ -634,7 +634,7 @@ WI.DataGridNode = class DataGridNode extends WI.Object while (node && ((!skipHidden || (node.revealed && node.expanded)) ? node.children.lastValue : null)) { if (!dontPopulate && node.hasChildren) node.dispatchEventToListeners("populate"); - node = ((!skipHidden || (node.revealed && node.expanded)) ? node.children.lastValue : null); + node = (!skipHidden || (node.revealed && node.expanded)) ? node.children.lastValue : null; } if (node) diff --git a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js index f13ab7649b2e..c2b27dd1a647 100644 --- a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js +++ b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js @@ -102,7 +102,7 @@ WI.FindBanner = class FindBanner extends WI.NavigationItem this._numberOfResults = numberOfResults; - this._previousResultButton.disabled = this._nextResultButton.disabled = (numberOfResults <= 0); + this._previousResultButton.disabled = this._nextResultButton.disabled = numberOfResults <= 0; if (numberOfResults === null) this._resultCountLabel.textContent = ""; diff --git a/Source/WebInspectorUI/UserInterface/Views/GroupNavigationItem.js b/Source/WebInspectorUI/UserInterface/Views/GroupNavigationItem.js index 30771cffd582..bfe2a6f1c558 100644 --- a/Source/WebInspectorUI/UserInterface/Views/GroupNavigationItem.js +++ b/Source/WebInspectorUI/UserInterface/Views/GroupNavigationItem.js @@ -42,7 +42,7 @@ WI.GroupNavigationItem = class GroupNavigationItem extends WI.NavigationItem { return this._navigationItems; } - + set navigationItems(items) { this._navigationItems = items; @@ -107,4 +107,4 @@ WI.GroupNavigationItem = class GroupNavigationItem extends WI.NavigationItem this.element.appendChild(item.element); } } -} +}; diff --git a/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js b/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js index d3be3aa0400d..ecfc1c0663ce 100644 --- a/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js +++ b/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js @@ -168,7 +168,7 @@ WI.HierarchicalPathNavigationItem = class HierarchicalPathNavigationItem extends // Since components have a minimum width, we need to see how much was actually // removed and subtract that from what remans to be removed. componentWidths[i] = Math.max(this._components[i].minimumWidth, forcedWidth); - widthToRemove -= (componentWidth - componentWidths[i]); + widthToRemove -= componentWidth - componentWidths[i]; // If there is nothing else to remove, then we can stop. if (widthToRemove <= 0) diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js index cc1378bbc0e7..96f3445cf736 100644 --- a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js +++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js @@ -62,7 +62,7 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie ]; for (let [key, checker] of uniqueTypes) { let type = WI.Resource.Type[key]; - let scopeBarItem = new WI.ScopeBarItem("network-type-filter-" + key, WI.NetworkTableContentView.shortDisplayNameForResourceType(type)) + let scopeBarItem = new WI.ScopeBarItem("network-type-filter-" + key, WI.NetworkTableContentView.shortDisplayNameForResourceType(type)); scopeBarItem.__checker = checker; typeFilterScopeBarItems.push(scopeBarItem); } @@ -420,7 +420,7 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie if (isNaN(bValue)) return -1; return aValue - bValue; - } + }; break; case "priority": diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js index a39271ca83fb..880e481b938c 100644 --- a/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js +++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js @@ -192,8 +192,8 @@ WI.NetworkTimelineView = class NetworkTimelineView extends WI.TimelineView { if (sortColumnIdentifier === "priority") return WI.Resource.comparePriority(node1.data.priority, node2.data.priority) * sortDirection; - - if (sortColumnIdentifier == "name") { + + if (sortColumnIdentifier === "name") { let displayName1 = node1.displayName(); let displayName2 = node2.displayName(); diff --git a/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js b/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js index 950307b68fd1..634e5e296c68 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js +++ b/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js @@ -90,7 +90,7 @@ WI.ObjectTreePropertyTreeElement = class ObjectTreePropertyTreeElement extends W _updateHasChildren() { var resolvedValue = this.resolvedValue(); - var valueHasChildren = (resolvedValue && resolvedValue.hasChildren); + var valueHasChildren = resolvedValue && resolvedValue.hasChildren; var wasThrown = this.hadError(); if (this._mode === WI.ObjectTreeView.Mode.Properties) diff --git a/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js b/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js index a141459185aa..414f4f088b54 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js +++ b/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js @@ -150,7 +150,7 @@ WI.ObjectTreeView = class ObjectTreeView extends WI.Object return chunkb.length - chunka.length; } } else if (chunka !== chunkb) - return (chunka < chunkb) ? -1 : 1; + return chunka < chunkb ? -1 : 1; a = a.substring(chunka.length); b = b.substring(chunkb.length); } diff --git a/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js b/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js index 26429a7adcee..a0fedbe2e532 100644 --- a/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js +++ b/Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js @@ -199,7 +199,7 @@ WI.RecordingContentView = class RecordingContentView extends WI.ContentView snapshot.context[name](...snapshot.state[name]); else snapshot.context[name] = snapshot.state[name]; - } catch (e) { + } catch { delete snapshot.state[name]; } } diff --git a/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js b/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js index 91dc40aee55a..8a05ed2c4345 100644 --- a/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js +++ b/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js @@ -57,7 +57,7 @@ WI.RenderingFrameTimelineOverviewGraph = class RenderingFrameTimelineOverviewGra return Math.max(previousValue, currentValue.duration); }, 0); - this._graphHeightSeconds = maximumFrameDuration * 1.1; // Add 10% margin above frames. + this._graphHeightSeconds = maximumFrameDuration * 1.1; // Add 10% margin above frames. this._graphHeightSeconds = Math.min(this._graphHeightSeconds, WI.RenderingFrameTimelineOverviewGraph.MaximumGraphHeightSeconds); this._graphHeightSeconds = Math.max(this._graphHeightSeconds, WI.RenderingFrameTimelineOverviewGraph.MinimumGraphHeightSeconds); return this._graphHeightSeconds; @@ -222,7 +222,7 @@ WI.RenderingFrameTimelineOverviewGraph = class RenderingFrameTimelineOverviewGra return; } - var frameWidth = (1 / this.timelineOverview.secondsPerPixel); + var frameWidth = 1 / this.timelineOverview.secondsPerPixel; this._selectedFrameMarker.style.width = frameWidth + "px"; var markerLeftPosition = this.selectedRecord.frameIndex - this.startTime; diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js b/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js index 06539336ec0c..b1e1b39cc1fa 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js +++ b/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js @@ -160,13 +160,13 @@ WI.ResourceCookiesContentView = class ResourceCookiesContentView extends WI.Cont if (isNaN(bValue)) return -1; return aValue - bValue; - } + }; break; case "httpOnly": case "secure": // Boolean. - comparator = (a, b) => (a[sortColumnIdentifier] - b[sortColumnIdentifier]); + comparator = (a, b) => a[sortColumnIdentifier] - b[sortColumnIdentifier]; break; case "expires": @@ -179,7 +179,7 @@ WI.ResourceCookiesContentView = class ResourceCookiesContentView extends WI.Cont if (!bExpires) return -1; return aExpires.getTime() - bExpires.getTime(); - } + }; break; default: diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSection.js b/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSection.js index d44ca3295ed7..274d5571f86a 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSection.js +++ b/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSection.js @@ -56,4 +56,4 @@ WI.ResourceDetailsSection = class ResourceDetailsSection console.assert(typeof isError === "boolean"); this.element.classList.toggle("error", isError); } -} +}; diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js b/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js index 2a7190751d0e..c0a0f204b912 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js +++ b/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js @@ -227,7 +227,7 @@ WI.ResourceHeadersContentView = class ResourceHeadersContentView extends WI.Cont // Don't include a colon if no value. console.assert(typeof key === "string"); - let displayKey = key + (!!value ? ": " : ""); + let displayKey = key + (value ? ": " : ""); let keyElement = p.appendChild(document.createElement("span")); keyElement.className = "key"; @@ -388,7 +388,7 @@ WI.ResourceHeadersContentView = class ResourceHeadersContentView extends WI.Cont if (requestDataContentType && requestDataContentType.match(/^application\/x-www-form-urlencoded\s*(;.*)?$/i)) { // Simple form data that should be parsable like a query string. this._appendKeyValuePair(detailsElement, WI.UIString("MIME Type"), requestDataContentType); - let queryStringPairs = parseQueryString(requestData, true) + let queryStringPairs = parseQueryString(requestData, true); for (let {name, value} of queryStringPairs) this._appendKeyValuePair(detailsElement, name, value); return; diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js b/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js index f2366078ff2c..4488286589f7 100644 --- a/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js +++ b/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js @@ -314,7 +314,7 @@ WI.ResourceTimelineDataGridNode = class ResourceTimelineDataGridNode extends WI. if (!this._spinner) this._spinner = new WI.IndeterminateProgressSpinner; let contentElement = cell.firstChild; - contentElement.appendChild(this._spinner.element); + contentElement.appendChild(this._spinner.element); } else { if (this._spinner) this._spinner.element.remove(); diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingEditor.js b/Source/WebInspectorUI/UserInterface/Views/SettingEditor.js index e85698ef24a5..6ba62af470f2 100644 --- a/Source/WebInspectorUI/UserInterface/Views/SettingEditor.js +++ b/Source/WebInspectorUI/UserInterface/Views/SettingEditor.js @@ -88,7 +88,7 @@ WI.SettingEditor = class SettingEditor extends WI.Object let oldValue = this._value; this._value = value; - if (this._type == WI.SettingEditor.Type.Checkbox) + if (this._type === WI.SettingEditor.Type.Checkbox) this._editorElement.checked = !!this._value; else this._editorElement.value = this._value; diff --git a/Source/WebInspectorUI/UserInterface/Views/Sidebar.js b/Source/WebInspectorUI/UserInterface/Views/Sidebar.js index 10115b596a60..a95791eb2be7 100644 --- a/Source/WebInspectorUI/UserInterface/Views/Sidebar.js +++ b/Source/WebInspectorUI/UserInterface/Views/Sidebar.js @@ -257,7 +257,7 @@ WI.Sidebar = class Sidebar extends WI.View var newWidth = positionDelta + this._widthBeforeResize; this.width = newWidth; - this.collapsed = (newWidth < (this.minimumWidth / 2)); + this.collapsed = newWidth < (this.minimumWidth / 2); } resizerDragEnded(resizer) diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js index 9138b10dc9d7..efc67d771ff2 100644 --- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js +++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js @@ -202,9 +202,9 @@ WI.SpreadsheetCSSStyleDeclarationSection = class SpreadsheetCSSStyleDeclarationS case WI.CSSStyleDeclaration.Type.Rule: console.assert(this._style.ownerRule); - let selectors = this._style.ownerRule.selectors; - let matchedSelectorIndices = this._style.ownerRule.matchedSelectorIndices; - let alwaysMatch = !matchedSelectorIndices.length; + var selectors = this._style.ownerRule.selectors; + var matchedSelectorIndices = this._style.ownerRule.matchedSelectorIndices; + var alwaysMatch = !matchedSelectorIndices.length; if (selectors.length) { let hasMatchingPseudoElementSelector = false; for (let i = 0; i < selectors.length; ++i) { diff --git a/Source/WebInspectorUI/UserInterface/Views/Table.js b/Source/WebInspectorUI/UserInterface/Views/Table.js index d4f8ce344c3d..ef93012a0e79 100644 --- a/Source/WebInspectorUI/UserInterface/Views/Table.js +++ b/Source/WebInspectorUI/UserInterface/Views/Table.js @@ -272,7 +272,7 @@ WI.Table = class Table extends WI.View this._selectedRowIndex = rowIndex; - let newSelectedRow = this._cachedRows.get(this._selectedRowIndex) + let newSelectedRow = this._cachedRows.get(this._selectedRowIndex); if (newSelectedRow) newSelectedRow.classList.add("selected"); diff --git a/Source/WebInspectorUI/UserInterface/Views/TextEditor.js b/Source/WebInspectorUI/UserInterface/Views/TextEditor.js index 176c1e62d19a..307543284c30 100644 --- a/Source/WebInspectorUI/UserInterface/Views/TextEditor.js +++ b/Source/WebInspectorUI/UserInterface/Views/TextEditor.js @@ -1532,7 +1532,7 @@ WI.TextEditor = class TextEditor extends WI.View if (lineNumber !== undefined) { // We have a new line that will now show the dragged breakpoint. var newColumnBreakpoints = {}; - var columnNumber = (lineNumber === this._lineNumberWithMousedDownBreakpoint ? this._columnNumberWithDraggedBreakpoint : 0); + var columnNumber = lineNumber === this._lineNumberWithMousedDownBreakpoint ? this._columnNumberWithDraggedBreakpoint : 0; newColumnBreakpoints[columnNumber] = this._draggingBreakpointInfo; this._previousColumnBreakpointInfo = this._allColumnBreakpointInfoForLine(lineNumber); this._setColumnBreakpointInfoForLine(lineNumber, newColumnBreakpoints); diff --git a/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js b/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js index 0eb1e926951c..d6540a51e684 100644 --- a/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js +++ b/Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js @@ -325,8 +325,8 @@ WI.TimelineDataGridNode = class TimelineDataGridNode extends WI.DataGridNode displayName() { // Can be overridden by subclasses. - const includeDetails = true; - return WI.TimelineTabContentView.displayNameForRecord(this.record, true); + const includeDetailsInMainTitle = true; + return WI.TimelineTabContentView.displayNameForRecord(this.record, includeDetailsInMainTitle); } iconClassNames() diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js index 248291b579e1..f440e957c285 100644 --- a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js +++ b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js @@ -433,7 +433,7 @@ WI.TreeElement = class TreeElement extends WI.Object while (item) { if (depth < maxDepth) item.expand(); - item = item.traverseNextTreeElement(false, this, (depth >= maxDepth), info); + item = item.traverseNextTreeElement(false, this, depth >= maxDepth, info); depth += info.depthChange; } } diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js index 536d8a01e525..bd231edc4b23 100644 --- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js +++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js @@ -192,7 +192,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object if (!child) return; - var previousChild = (index > 0 ? this.children[index - 1] : null); + var previousChild = index > 0 ? this.children[index - 1] : null; if (previousChild) { previousChild.nextSibling = child; child.previousSibling = previousChild; diff --git a/Source/WebInspectorUI/UserInterface/Views/WebSocketDataGridNode.js b/Source/WebInspectorUI/UserInterface/Views/WebSocketDataGridNode.js index d4a00d07e08d..502e601aa26b 100644 --- a/Source/WebInspectorUI/UserInterface/Views/WebSocketDataGridNode.js +++ b/Source/WebInspectorUI/UserInterface/Views/WebSocketDataGridNode.js @@ -82,7 +82,7 @@ WI.WebSocketDataGridNode = class WebSocketDataGridNode extends WI.DataGridNode let expression = "(" + this._data.data + ")"; WI.runtimeManager.evaluateInInspectedWindow(expression, options, logResult); }); - } catch (error) { } + } catch { } contextMenu.appendSeparator(); } diff --git a/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js b/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js index 7feae46b8531..47407d49dcbc 100644 --- a/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js +++ b/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js @@ -36,7 +36,7 @@ EsprimaFormatter = class EsprimaFormatter let tree = (function() { try { return esprima.parse(sourceText, {attachComment: true, range: true, tokens: true, sourceType}); - } catch (error) { + } catch { return null; } })(); diff --git a/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterWorker.js b/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterWorker.js index 9c056f11db72..0f5c8450d283 100644 --- a/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterWorker.js +++ b/Source/WebInspectorUI/UserInterface/Workers/Formatter/FormatterWorker.js @@ -68,7 +68,7 @@ FormatterWorker = class FormatterWorker if (includeSourceMapData) result.sourceMapData = {mapping: {original: [], formatted: []}, originalLineEndings: [], formattedLineEndings: []}; return result; - } catch (e) {} + } catch { } // Format invalid JSON and anonymous functions. // Some applications do not use JSON.parse but eval on JSON content. That is more permissive