Remove ChromeClient::scrollbarsModeDidChange

https://bugs.webkit.org/show_bug.cgi?id=175805 Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-22 Reviewed by Daniel Bates. Source/WebCore: No change in behavior. It was never called, and no implementations did anything. * loader/EmptyClients.h: * page/Chrome.cpp: (WebCore::Chrome::scrollbarsModeDidChange const): Deleted. * page/Chrome.h: * page/ChromeClient.h: * platform/HostWindow.h: Source/WebKit: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted. * WebProcess/WebCoreSupport/WebChromeClient.h: Source/WebKitLegacy/mac: * WebCoreSupport/WebChromeClient.h: Source/WebKitLegacy/win: * WebCoreSupport/WebChromeClient.h: Canonical link: https://commits.webkit.org/192484@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Aug 22, 2017 · 4af81acf6a0a8c111bb7d99a7fe04b1c0b1288c2 · 4af81ac
1 parent 3727d37
commit 4af81acf6a0a8c111bb7d99a7fe04b1c0b1288c2
Showing 13 changed files with 45 additions and 19 deletions.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        No change in behavior.  It was never called, and no implementations did anything.
+
+        * loader/EmptyClients.h:
+        * page/Chrome.cpp:
+        (WebCore::Chrome::scrollbarsModeDidChange const): Deleted.
+        * page/Chrome.h:
+        * page/ChromeClient.h:
+        * platform/HostWindow.h:
+
 2017-08-22  Devin Rousso  <webkit@devinrousso.com>
 
         Web Inspector: provide way for ShaderPrograms to be enabled/disabled

diff --git a/Source/WebCore/loader/EmptyClients.h b/Source/WebCore/loader/EmptyClients.h
@@ -122,7 +122,6 @@ class EmptyChromeClient : public ChromeClient {
     PlatformPageClient platformPageClient() const final { return 0; }
     void contentsSizeChanged(Frame&, const IntSize&) const final { }
 
-    void scrollbarsModeDidChange() const final { }
     void mouseDidMoveOverElement(const HitTestResult&, unsigned) final { }
 
     void setToolTip(const String&, TextDirection) final { }

diff --git a/Source/WebCore/page/Chrome.cpp b/Source/WebCore/page/Chrome.cpp
@@ -137,11 +137,6 @@ void Chrome::scrollRectIntoView(const IntRect& rect) const
     m_client.scrollRectIntoView(rect);
 }
 
-void Chrome::scrollbarsModeDidChange() const
-{
-    m_client.scrollbarsModeDidChange();
-}
-
 void Chrome::setWindowRect(const FloatRect& rect) const
 {
     m_client.setWindowRect(rect);

diff --git a/Source/WebCore/page/Chrome.h b/Source/WebCore/page/Chrome.h
@@ -81,7 +81,6 @@ class Chrome : public HostWindow {
     IntRect rootViewToAccessibilityScreen(const IntRect&) const override;
 #endif
     PlatformPageClient platformPageClient() const override;
-    void scrollbarsModeDidChange() const override;
     void setCursor(const Cursor&) override;
     void setCursorHiddenUntilMouseMoves(bool) override;
 

diff --git a/Source/WebCore/page/ChromeClient.h b/Source/WebCore/page/ChromeClient.h
@@ -178,7 +178,6 @@ class WEBCORE_EXPORT ChromeClient {
 #endif    
 
     virtual PlatformPageClient platformPageClient() const = 0;
-    virtual void scrollbarsModeDidChange() const = 0;
 
 #if ENABLE(CURSOR_SUPPORT)
     virtual void setCursor(const Cursor&) = 0;

diff --git a/Source/WebCore/platform/HostWindow.h b/Source/WebCore/platform/HostWindow.h
@@ -66,9 +66,6 @@ class HostWindow {
     // Method for retrieving the native client of the page.
     virtual PlatformPageClient platformPageClient() const = 0;
 
-    // To notify WebKit of scrollbar mode changes.
-    virtual void scrollbarsModeDidChange() const = 0;
-
     // Request that the cursor change.
     virtual void setCursor(const Cursor&) = 0;
 

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,14 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+
 2017-08-22  Chris Dumez  <cdumez@apple.com>
 
         Add sanity check for source origin in WebLoaderStrategy::startPingLoad()

diff --git a/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp b/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
@@ -640,11 +640,6 @@ void WebChromeClient::unavailablePluginButtonClicked(Element& element, RenderEmb
 #endif // ENABLE(NETSCAPE_PLUGIN_API)
 }
 
-void WebChromeClient::scrollbarsModeDidChange() const
-{
-    notImplemented();
-}
-
 void WebChromeClient::mouseDidMoveOverElement(const HitTestResult& hitTestResult, unsigned modifierFlags)
 {
     RefPtr<API::Object> userData;

diff --git a/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h b/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
@@ -124,7 +124,6 @@ class WebChromeClient final : public WebCore::ChromeClient {
     bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
 
-    void scrollbarsModeDidChange() const final;
     void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
 
     void setToolTip(const String&, WebCore::TextDirection) final;

diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
@@ -1,3 +1,12 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        * WebCoreSupport/WebChromeClient.h:
+
 2017-08-22  Alex Christensen  <achristensen@webkit.org>
 
         Remove ChromeClient::hasOpenedPopup

diff --git a/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h b/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
@@ -110,7 +110,6 @@ class WebChromeClient : public WebCore::ChromeClient {
 
     void setStatusbarText(const String&) override;
 
-    void scrollbarsModeDidChange() const final { }
     bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;

diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
@@ -1,3 +1,12 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        * WebCoreSupport/WebChromeClient.h:
+
 2017-08-22  Alex Christensen  <achristensen@webkit.org>
 
         Remove ChromeClient::hasOpenedPopup

diff --git a/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h b/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h
@@ -101,7 +101,6 @@ class WebChromeClient final : public WebCore::ChromeClient {
     PlatformPageClient platformPageClient() const final;
     void contentsSizeChanged(WebCore::Frame&, const WebCore::IntSize&) const final;
 
-    void scrollbarsModeDidChange() const final { }
     void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
     bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;