Skip to content
Permalink
Browse files
2010-10-19 Philippe Normand <pnormand@igalia.com>
        Reviewed by Xan Lopez.

        [GTK] Soup cache code still has some warnings
        https://bugs.webkit.org/show_bug.cgi?id=47733

        Fixed some compilation warnings happening with gcc 4.4.5 on
        64-bits architecture.

        * platform/network/soup/cache/webkit/soup-cache.c:
        (webkit_soup_cache_entry_set_freshness):
        (close_ready_cb):

Canonical link: https://commits.webkit.org/60618@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
philn committed Oct 19, 2010
1 parent fbb9049 commit 4c098cd576a1b092bc2174d2dff5f38812405955
Showing 2 changed files with 16 additions and 2 deletions.
@@ -1,3 +1,17 @@
2010-10-19 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] Soup cache code still has some warnings
https://bugs.webkit.org/show_bug.cgi?id=47733

Fixed some compilation warnings happening with gcc 4.4.5 on
64-bits architecture.

* platform/network/soup/cache/webkit/soup-cache.c:
(webkit_soup_cache_entry_set_freshness):
(close_ready_cb):

2010-10-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.
@@ -297,7 +297,7 @@ webkit_soup_cache_entry_set_freshness (WebKitSoupCacheEntry *entry, SoupMessage
hash = soup_header_parse_param_list (cache_control);

/* Should we re-validate the entry when it goes stale */
entry->must_revalidate = (gboolean)g_hash_table_lookup (hash, "must-revalidate");
entry->must_revalidate = g_hash_table_lookup_extended (hash, "must-revalidate", NULL, NULL);

/* Section 2.3.1 */
if (priv->cache_type == WEBKIT_SOUP_CACHE_SHARED) {
@@ -509,7 +509,7 @@ close_ready_cb (GObject *source, GAsyncResult *result, WebKitSoupCacheWritingFix
webkit_soup_cache_entry_free (entry, TRUE);
entry = NULL;
} else if ((soup_message_headers_get_encoding (entry->headers) == SOUP_ENCODING_CHUNKED) ||
entry->length != content_length) {
entry->length != (gsize) content_length) {
/** Two options here:
*
* 1. "chunked" data, entry was temporarily added to

0 comments on commit 4c098cd

Please sign in to comment.