Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Fix testbmalloc build
https://bugs.webkit.org/show_bug.cgi?id=195660 Patch by Sam Weinig <sam@webkit.org> on 2019-03-13 Reviewed by Geoffrey Garen. * bmalloc.xcodeproj/project.pbxproj: Link Foundation in when building testbmalloc. Since bmalloc requires Foundation, and is a static library, all clients of bmalloc are required to link it themselves. * bmalloc/IsoPageInlines.h: * bmalloc/StdLibExtras.h: Added. (bmalloc::bitwise_cast): Add bitwise_cast implementation, and use it in IsoPageInlines.h. It is a layering violation to expect the one from WTF to be available, as seems to have been the case. Canonical link: https://commits.webkit.org/209983@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
033d8a8
commit 4c85f07ec49f8f460848f8fdb20c2bd0bdd8d92a
Showing
4 changed files
with
75 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,7 @@ | ||
| #include "CryptoRandom.h" | ||
| #include "IsoDirectory.h" | ||
| #include "IsoPage.h" | ||
| #include "StdLibExtras.h" | ||
| #include "VMAllocate.h" | ||
|
|
||
| namespace bmalloc { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Copyright (C) 2019 Apple Inc. All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * 1. Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * 2. Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY | ||
| * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
| * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR | ||
| * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
| * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
| * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
| * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||
| * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #ifndef StdLibExtras_h | ||
| #define StdLibExtras_h | ||
|
|
||
| #include "BCompiler.h" | ||
| #include <memory> | ||
| #include <type_traits> | ||
|
|
||
| namespace bmalloc { | ||
|
|
||
| template<typename ToType, typename FromType> | ||
| inline ToType bitwise_cast(FromType from) | ||
| { | ||
| static_assert(sizeof(FromType) == sizeof(ToType), "bitwise_cast size of FromType and ToType must be equal!"); | ||
| #if BCOMPILER_HAS_CLANG_FEATURE(is_trivially_copyable) | ||
| // Not all recent STL implementations support the std::is_trivially_copyable type trait. Work around this by only checking on toolchains which have the equivalent compiler intrinsic. | ||
| static_assert(__is_trivially_copyable(ToType), "bitwise_cast of non-trivially-copyable type!"); | ||
| static_assert(__is_trivially_copyable(FromType), "bitwise_cast of non-trivially-copyable type!"); | ||
| #endif | ||
| typename std::remove_const<ToType>::type to { }; | ||
| std::memcpy(static_cast<void*>(&to), static_cast<void*>(&from), sizeof(to)); | ||
| return to; | ||
| } | ||
|
|
||
| } // namespace bmalloc | ||
|
|
||
| #endif // StdLibExtras_h |