Skip to content
Permalink
Browse files
replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>

Reviewed by Eric Carlson.

We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.

Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.

* platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Canonical link: https://commits.webkit.org/250300@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youennf committed May 5, 2022
1 parent 36ee86f commit 4da77ec821d6d1a03fc08582ed05c2c6b3afd7fd
Showing 2 changed files with 17 additions and 3 deletions.
@@ -1,3 +1,20 @@
2022-05-05 Youenn Fablet <youenn@apple.com>

replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>

Reviewed by Eric Carlson.

We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.

Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.

* platform/mediastream/mac/CoreAudioCaptureSource.cpp:

2022-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set
@@ -298,9 +298,6 @@ OSStatus CoreAudioSharedUnit::configureMicrophoneProc(int sampleRate)
{
ASSERT(isMainThread());

if (!isProducingMicrophoneSamples())
return noErr;

AURenderCallbackStruct callback = { microphoneCallback, this };
auto err = PAL::AudioUnitSetProperty(m_ioUnit, kAudioOutputUnitProperty_SetInputCallback, kAudioUnitScope_Global, inputBus, &callback, sizeof(callback));
if (err) {

0 comments on commit 4da77ec

Please sign in to comment.