Skip to content
Permalink
Browse files
replaceWithJump should not decrease the offset by 1 on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109689

Reviewed by Zoltan Herczeg.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::replaceWithJump):


Canonical link: https://commits.webkit.org/127971@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Zoltan Herczeg committed Feb 13, 2013
1 parent 383f7ec commit 4e585afea8e3b03f5a5b890f061304bc70edd20c
Showing 2 changed files with 11 additions and 1 deletion.
@@ -1,3 +1,13 @@
2013-02-13 Zoltan Herczeg <zherczeg@webkit.org>

replaceWithJump should not decrease the offset by 1 on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109689

Reviewed by Zoltan Herczeg.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::replaceWithJump):

2013-02-12 Joseph Pecoraro <pecoraro@apple.com>

[iOS] Enable PAGE_VISIBILITY_API
@@ -904,7 +904,7 @@ namespace JSC {

static void replaceWithJump(void* instructionStart, void* to)
{
ARMWord* instruction = reinterpret_cast<ARMWord*>(instructionStart) - 1;
ARMWord* instruction = reinterpret_cast<ARMWord*>(instructionStart);
intptr_t difference = reinterpret_cast<intptr_t>(to) - (reinterpret_cast<intptr_t>(instruction) + DefaultPrefetchOffset * sizeof(ARMWord));

if (!(difference & 1)) {

0 comments on commit 4e585af

Please sign in to comment.