Skip to content
Permalink
Browse files
CommitLogViewer._preceedingCommit should not always be null
https://bugs.webkit.org/show_bug.cgi?id=185540

Reviewed by Ryosuke Niwa.

Fix the bug introduced in r227746 that CommitLogViewer._preceedingCommit is always null.

* browser-tests/index.html: Fix expected measurement-set url.
* public/v3/components/commit-log-viewer.js:
(CommitLogViewer.prototype._fetchCommitLogs): CommitLogViewer._preceedingCommit should be set
when fetching for preceeding revision succeeds.

Canonical link: https://commits.webkit.org/201045@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dewei-zhu committed May 11, 2018
1 parent 63959c3 commit 4ff938da6c1143e3cb8ab197b8b9fa78d6ca2a53
@@ -1,3 +1,17 @@
2018-05-10 Dewei Zhu <dewei_zhu@apple.com>

CommitLogViewer._preceedingCommit should not always be null
https://bugs.webkit.org/show_bug.cgi?id=185540

Reviewed by Ryosuke Niwa.

Fix the bug introduced in r227746 that CommitLogViewer._preceedingCommit is always null.

* browser-tests/index.html: Fix expected measurement-set url.
* public/v3/components/commit-log-viewer.js:
(CommitLogViewer.prototype._fetchCommitLogs): CommitLogViewer._preceedingCommit should be set
when fetching for preceeding revision succeeds.

2018-05-03 Dewei Zhu <dewei_zhu@apple.com>

Range bisector should check the commits for repositories without change in specified range.
@@ -363,7 +363,7 @@

respondWithSampleCluster(request, options)
{
expect(request.url).to.be('../data/measurement-set-1-1.json');
expect(request.url).to.be('/data/measurement-set-1-1.json');
expect(request.method).to.be('GET');
request.resolve(this.makeSampleCluster(options));
},
@@ -36,7 +36,6 @@ class CommitLogViewer extends ComponentBase {
}

let promise;
let precedingCommitPromise;
const fetchSingleCommit = !precedingRevision || precedingRevision == lastRevision;
if (fetchSingleCommit) {
promise = CommitLog.fetchForSingleRevision(repository, lastRevision).then((commits) => {
@@ -55,7 +54,7 @@ class CommitLogViewer extends ComponentBase {
CommitLog.fetchForSingleRevision(repository, precedingRevision).then((precedingCommit) => {
if (this._fetchingPromise != promise)
return;
this._precedingCommit = null;
this._precedingCommit = precedingCommit[0];
})
]);
}

0 comments on commit 4ff938d

Please sign in to comment.