Replace axObject->isAXHidden() || axObject->isDOMHidden() with `axO…

…bject->isHidden()` https://bugs.webkit.org/show_bug.cgi?id=230678 Reviewed by Antti Koivisto. No behaviour change. The definition of isHidden is: `bool isHidden() const override { return isAXHidden() || isDOMHidden(); }` * inspector/InspectorAuditAccessibilityObject.cpp: (WebCore::InspectorAuditAccessibilityObject::getComputedProperties): * inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties): Canonical link: https://commits.webkit.org/242045@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@282955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Sep 23, 2021 · 504e80f · 504e80f
1 parent 521e283
commit 504e80f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2021-09-23  Tim Nguyen  <ntim@apple.com>
+
+        Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->isHidden()`
+        https://bugs.webkit.org/show_bug.cgi?id=230678
+
+        Reviewed by Antti Koivisto.
+
+        No behaviour change. The definition of isHidden is:
+
+        `bool isHidden() const override { return isAXHidden() || isDOMHidden(); }`
+
+        * inspector/InspectorAuditAccessibilityObject.cpp:
+        (WebCore::InspectorAuditAccessibilityObject::getComputedProperties):
+        * inspector/agents/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+
 2021-09-23  Jean-Yves Avenard  <jya@apple.com>
 
         Opus and Vorbis codecs aren't available on iPad.

diff --git a/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp b/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp
@@ -175,7 +175,7 @@ ExceptionOr<std::optional<InspectorAuditAccessibilityObject::ComputedProperties>
             computedProperties.focused = axObject->isFocused();
 
         computedProperties.headingLevel = axObject->headingLevel();
-        computedProperties.hidden = axObject->isAXHidden() || axObject->isDOMHidden();
+        computedProperties.hidden = axObject->isHidden();
         computedProperties.hierarchicalLevel = axObject->hierarchicalLevel();
         computedProperties.ignored = axObject->accessibilityIsIgnored();
         computedProperties.ignoredByDefault = axObject->accessibilityIsIgnoredByDefault();

diff --git a/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp b/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
@@ -2117,7 +2117,7 @@ Ref<Protocol::DOM::AccessibilityProperties> InspectorDOMAgent::buildObjectForAcc
             else // Future versions of ARIA may allow additional truthy values. Ex. format, order, or size.
                 invalid = Protocol::DOM::AccessibilityProperties::Invalid::True;
 
-            if (axObject->isAXHidden() || axObject->isDOMHidden())
+            if (axObject->isHidden())
                 hidden = true;
 
             label = axObject->computedLabel();