Skip to content
Permalink
Browse files
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
        Reviewed by Alexey Proskuryakov.

        Build fix for Intel ICC Compiler.
        https://bugs.webkit.org/show_bug.cgi?id=55221

        The virtual inheritance seems to confuse ICC.
        Anything that links with webkit has an undefined reference otherwise.

        * svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::~SVGTransformable):
        * svg/SVGTransformable.h:

Canonical link: https://commits.webkit.org/69811@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue committed Feb 28, 2011
1 parent 298c180 commit 508f5753e675080dbff9632bc82c7b3ee66a3a39
Showing 3 changed files with 21 additions and 0 deletions.
@@ -1,3 +1,17 @@
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Alexey Proskuryakov.

Build fix for Intel ICC Compiler.
https://bugs.webkit.org/show_bug.cgi?id=55221

The virtual inheritance seems to confuse ICC.
Anything that links with webkit has an undefined reference otherwise.

* svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::~SVGTransformable):
* svg/SVGTransformable.h:

2011-02-28 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.
@@ -89,6 +89,11 @@ static int parseTransformParamList(const UChar*& ptr, const UChar* end, float* v
static const int requiredValuesForType[] = {0, 6, 1, 1, 1, 1, 1};
static const int optionalValuesForType[] = {0, 0, 1, 1, 2, 0, 0};

// This destructor is needed in order to link correctly with Intel ICC.
SVGTransformable::~SVGTransformable()
{
}

bool SVGTransformable::parseTransformValue(unsigned type, const UChar*& ptr, const UChar* end, SVGTransform& transform)
{
if (type == SVGTransform::SVG_TRANSFORM_UNKNOWN)
@@ -40,6 +40,8 @@ class SVGTransformable : virtual public SVGLocatable {
DoNotClearList
};

virtual ~SVGTransformable();

static bool parseTransformAttribute(SVGTransformList&, const AtomicString& transform);
static bool parseTransformAttribute(SVGTransformList&, const UChar*& ptr, const UChar* end, TransformParsingMode mode = ClearList);
static bool parseTransformValue(unsigned type, const UChar*& ptr, const UChar* end, SVGTransform&);

0 comments on commit 508f575

Please sign in to comment.