Skip to content
Permalink
Browse files
[LayoutReloaded] Remove Layout.InitialContainingBlock class
https://bugs.webkit.org/show_bug.cgi?id=184436

Reviewed by Antti Koivisto.

* LayoutReloaded/LayoutTree/Box.js:
(Layout.Box.prototype.establishesBlockFormattingContext):
* LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
* LayoutReloaded/TreeBuilder.js:
(TreeBuilder.prototype.createTree):
* LayoutReloaded/test/index.html:

Canonical link: https://commits.webkit.org/199995@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
alanbujtas committed Apr 10, 2018
1 parent f4c94d4 commit 50c034758f220649919136b1093181e9e094e4b3
@@ -1,3 +1,17 @@
2018-04-09 Zalan Bujtas <zalan@apple.com>

[LayoutReloaded] Remove Layout.InitialContainingBlock class
https://bugs.webkit.org/show_bug.cgi?id=184436

Reviewed by Antti Koivisto.

* LayoutReloaded/LayoutTree/Box.js:
(Layout.Box.prototype.establishesBlockFormattingContext):
* LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
* LayoutReloaded/TreeBuilder.js:
(TreeBuilder.prototype.createTree):
* LayoutReloaded/test/index.html:

2018-04-09 Zalan Bujtas <zalan@apple.com>

[LayoutReloaded] Add support for inline-block.
@@ -150,6 +150,9 @@ Layout.Box = class Box {
}

establishesBlockFormattingContext() {
// Initial Containing Block always creates a new (inital) block formatting context.
if (!this.parent())
return true;
// 9.4.1 Block formatting contexts
// Floats, absolutely positioned elements, block containers (such as inline-blocks, table-cells, and table-captions)
// that are not block boxes, and block boxes with 'overflow' other than 'visible' (except when that value has been propagated to the viewport)

This file was deleted.

@@ -28,7 +28,7 @@ class TreeBuilder {

createTree(document, renderTreeDump) {
// Root.
let initialBlockContainer = new Layout.InitialBlockContainer(document, parseInt(renderTreeDump.substring(0, renderTreeDump.indexOf("("))));
let initialBlockContainer = new Layout.BlockContainer(document, parseInt(renderTreeDump.substring(0, renderTreeDump.indexOf("("))));
initialBlockContainer.setRendererName("RenderView");
renderTreeDump = renderTreeDump.substring(renderTreeDump.indexOf("|") + 1);

@@ -99,7 +99,6 @@
addJS("../LayoutTree/Box.js");
addJS("../LayoutTree/Container.js");
addJS("../LayoutTree/BlockContainer.js");
addJS("../LayoutTree/InitialBlockContainer.js");
addJS("../LayoutTree/InlineContainer.js");
addJS("../LayoutTree/InlineBox.js");
addJS("../LayoutTree/Text.js");

0 comments on commit 50c0347

Please sign in to comment.