REGRESSION (r251574, r251600): _WKTextManipulationToken and _WKTextMa…

…nipulationConfiguration are missing -dealloc <https://webkit.org/b/209794> Reviewed by Wenson Hsieh. * UIProcess/API/Cocoa/_WKTextManipulationConfiguration.mm: (-[_WKTextManipulationConfiguration dealloc]): Add. * UIProcess/API/Cocoa/_WKTextManipulationToken.mm: (-[_WKTextManipulationToken dealloc]): Add. Canonical link: https://commits.webkit.org/222715@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@259280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Mar 31, 2020 · 515190c · 515190c
1 parent 134eeee
commit 515190c
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 0 deletions.
diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2020-03-30  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r251574, r251600): _WKTextManipulationToken and _WKTextManipulationConfiguration are missing -dealloc
+        <https://webkit.org/b/209794>
+
+        Reviewed by Wenson Hsieh.
+
+        * UIProcess/API/Cocoa/_WKTextManipulationConfiguration.mm:
+        (-[_WKTextManipulationConfiguration dealloc]): Add.
+        * UIProcess/API/Cocoa/_WKTextManipulationToken.mm:
+        (-[_WKTextManipulationToken dealloc]): Add.
+
 2020-03-30  John Wilander  <wilander@apple.com>
 
         Experimental: Enforce SameSite=strict for domains classified as bounce trackers

diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationConfiguration.mm b/Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationConfiguration.mm
@@ -27,5 +27,14 @@
 #import "_WKTextManipulationConfiguration.h"
 
 @implementation _WKTextManipulationConfiguration
+
+- (void)dealloc
+{
+    [_exclusionRules release];
+    _exclusionRules = nil;
+
+    [super dealloc];
+}
+
 @end
 
diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.mm b/Source/WebKit/UIProcess/API/Cocoa/_WKTextManipulationToken.mm
@@ -28,6 +28,16 @@
 
 @implementation _WKTextManipulationToken
 
+- (void)dealloc
+{
+    [_identifier release];
+    _identifier = nil;
+    [_content release];
+    _content = nil;
+
+    [super dealloc];
+}
+
 static BOOL isEqualOrBothNil(id a, id b)
 {
     if (a == b)