diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 17d2645ba0f3..c958302730ef 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,15 @@ +2012-01-23 Emil A Eklund + + check-webkit-style whitespace/operators triggers on overloaded division operator + https://bugs.webkit.org/show_bug.cgi?id=76650 + + Reviewed by Darin Adler. + + * Scripts/webkitpy/style/checkers/cpp.py: + (check_spacing): + * Scripts/webkitpy/style/checkers/cpp_unittest.py: + (CppStyleTest.test_operator_methods): + 2012-01-23 Ryosuke Niwa run-perf-tests should report server-side errors diff --git a/Tools/Scripts/webkitpy/style/checkers/cpp.py b/Tools/Scripts/webkitpy/style/checkers/cpp.py index 039fc765f630..6241de9df5a6 100644 --- a/Tools/Scripts/webkitpy/style/checkers/cpp.py +++ b/Tools/Scripts/webkitpy/style/checkers/cpp.py @@ -1808,7 +1808,7 @@ def check_spacing(file_extension, clean_lines, line_number, error): line = clean_lines.elided[line_number] # get rid of comments and strings # Don't try to do spacing checks for operator methods - line = sub(r'operator(==|!=|<|<<|<=|>=|>>|>|\+=|-=|\*=|/=|%=|&=|\|=|^=|<<=|>>=)\(', 'operator\(', line) + line = sub(r'operator(==|!=|<|<<|<=|>=|>>|>|\+=|-=|\*=|/=|%=|&=|\|=|^=|<<=|>>=|/)\(', 'operator\(', line) # Don't try to do spacing checks for #include or #import statements at # minimum because it messes up checks for spacing around / if match(r'\s*#\s*(?:include|import)', line): diff --git a/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py b/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py index 65ad1d663499..0c5c6041f8f0 100644 --- a/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py +++ b/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py @@ -1715,6 +1715,7 @@ def test_spacing_for_binary_ops(self): def test_operator_methods(self): self.assert_lint('String operator+(const String&, const String&);', '') + self.assert_lint('String operator/(const String&, const String&);', '') self.assert_lint('bool operator==(const String&, const String&);', '') self.assert_lint('String& operator-=(const String&, const String&);', '') self.assert_lint('String& operator+=(const String&, const String&);', '')