Skip to content
Permalink
Browse files
Silence log after r242122
https://bugs.webkit.org/show_bug.cgi?id=195074

* UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath const):
m_localStorageDirectory can now be null for ephemeral sessions.
This is not a failure to create a directory and needs no log.
This fixes the WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog API test.



Canonical link: https://commits.webkit.org/209450@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
achristensen07 committed Feb 27, 2019
1 parent 80c1402 commit 526ffa7f739aa930b6940b8bf66c78cd9a11bae7
Showing 2 changed files with 13 additions and 1 deletion.
@@ -1,3 +1,14 @@
2019-02-27 Alex Christensen <achristensen@webkit.org>

Silence log after r242122
https://bugs.webkit.org/show_bug.cgi?id=195074

* UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath const):
m_localStorageDirectory can now be null for ephemeral sessions.
This is not a failure to create a directory and needs no log.
This fixes the WKWebView.InitializingWebViewWithEphemeralStorageDoesNotLog API test.

2019-02-27 Timothy Hatcher <timothy@apple.com>

REGRESSION: WebKit content crash in Base System (because NSAppearance is NULL).
@@ -151,7 +151,8 @@ Vector<LocalStorageDatabaseTracker::OriginDetails> LocalStorageDatabaseTracker::
String LocalStorageDatabaseTracker::databasePath(const String& filename) const
{
if (!SQLiteFileSystem::ensureDatabaseDirectoryExists(m_localStorageDirectory)) {
LOG_ERROR("Unable to create LocalStorage database path %s", m_localStorageDirectory.utf8().data());
if (!m_localStorageDirectory.isNull())
LOG_ERROR("Unable to create LocalStorage database path %s", m_localStorageDirectory.utf8().data());
return String();
}

0 comments on commit 526ffa7

Please sign in to comment.