This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse the repository at this point in the history
Use _CFURLConnectionSetFrameworkStubs instead of DYLD_INTERPOSE on In…
…tel Macs https://bugs.webkit.org/show_bug.cgi?id=218810 Patch by Alex Christensen <firstname.lastname@example.org> on 2020-11-11 Reviewed by Geoffrey Garen. A long, long time ago, we realized that CFNetwork was looking in the keychain for persistent credentials, and in order to make the network process get credentials as the UI process, we introduced SecItemShim which used DYLD_INTERPOSE to intercept the calls to the security framework and synchronously message the UI process for those calls. Over the last 6 years we have realized that doesn't work on iOS or Apple silicon Macs, so we use _CFURLConnectionSetFrameworkStubs instead. That works on Intel Macs, too, and I'm reasonably certain that using it everywhere won't break anything, so as a step towards rdar://problem/15588174 which should allow us to use asynchronous messages and no more globalNetworkProcess pointer, let's stop using DYLD_INTERPOSE. * Shared/mac/SecItemShim.cpp: (WebKit::initializeSecItemShim): Canonical link: https://commits.webkit.org/231476@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing 2 changed files with 18 additions and 14 deletions.