Skip to content
Permalink
Browse files
Web Inspector: Revert -webkit-border-end changes that are unreliable
https://bugs.webkit.org/show_bug.cgi?id=195149

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-02-28
Reviewed by Matt Baker.

* UserInterface/Views/CPUUsageIndicatorView.css:
(.cpu-usage-indicator-view > .details):
(body[dir=ltr] .cpu-usage-indicator-view > .details):
(body[dir=rtl] .cpu-usage-indicator-view > .details):
* UserInterface/Views/CPUUsageStackedView.css:
(.cpu-usage-stacked-view > .details):
(body[dir=ltr] .cpu-usage-stacked-view > .details):
(body[dir=rtl] .cpu-usage-stacked-view > .details):
* UserInterface/Views/CPUUsageView.css:
(.cpu-usage-view > .details):
(body[dir=ltr] .cpu-usage-view > .details):
(body[dir=rtl] .cpu-usage-view > .details):
* UserInterface/Views/MemoryCategoryView.css:
(.memory-category-view > .details):
(body[dir=ltr] .memory-category-view > .details):
(body[dir=rtl] .memory-category-view > .details):

Canonical link: https://commits.webkit.org/209490@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Feb 28, 2019
1 parent a9f27c2 commit 527e8f0d3b0deeeb396db5b29ff37fea80eb637b
Showing 5 changed files with 64 additions and 4 deletions.
@@ -1,3 +1,27 @@
2019-02-28 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: Revert -webkit-border-end changes that are unreliable
https://bugs.webkit.org/show_bug.cgi?id=195149

Reviewed by Matt Baker.

* UserInterface/Views/CPUUsageIndicatorView.css:
(.cpu-usage-indicator-view > .details):
(body[dir=ltr] .cpu-usage-indicator-view > .details):
(body[dir=rtl] .cpu-usage-indicator-view > .details):
* UserInterface/Views/CPUUsageStackedView.css:
(.cpu-usage-stacked-view > .details):
(body[dir=ltr] .cpu-usage-stacked-view > .details):
(body[dir=rtl] .cpu-usage-stacked-view > .details):
* UserInterface/Views/CPUUsageView.css:
(.cpu-usage-view > .details):
(body[dir=ltr] .cpu-usage-view > .details):
(body[dir=rtl] .cpu-usage-view > .details):
* UserInterface/Views/MemoryCategoryView.css:
(.memory-category-view > .details):
(body[dir=ltr] .memory-category-view > .details):
(body[dir=rtl] .memory-category-view > .details):

2019-02-28 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: Cleanup some Chart code
@@ -34,7 +34,16 @@
flex-shrink: 0;
width: 150px;
-webkit-padding-start: 15px;
-webkit-border-end: 1px solid var(--border-color);

--cpu-usage-indicator-view-details-border-end: 1px solid var(--border-color);
}

body[dir=ltr] .cpu-usage-indicator-view > .details {
border-right: var(--cpu-usage-indicator-view-details-border-end);
}

body[dir=rtl] .cpu-usage-indicator-view > .details {
border-left: var(--cpu-usage-indicator-view-details-border-end);
}

body[dir=rtl] .cpu-usage-indicator-view > .graph {
@@ -40,7 +40,16 @@
color: var(--text-color-secondary);
overflow: hidden;
text-overflow: ellipsis;
-webkit-border-end: 1px solid var(--border-color);

--cpu-usage-stacked-view-details-border-end: 1px solid var(--border-color);
}

body[dir=ltr] .cpu-usage-stacked-view > .details {
border-right: var(--cpu-usage-stacked-view-details-border-end);
}

body[dir=rtl] .cpu-usage-stacked-view > .details {
border-left: var(--cpu-usage-stacked-view-details-border-end);
}

.cpu-usage-stacked-view > .details > .name {
@@ -40,7 +40,16 @@
color: var(--text-color-secondary);
overflow: hidden;
text-overflow: ellipsis;
-webkit-border-end: 1px solid var(--border-color);

--cpu-usage-view-details-border-end: 1px solid var(--border-color);
}

body[dir=ltr] .cpu-usage-view > .details {
border-right: var(--cpu-usage-view-details-border-end);
}

body[dir=rtl] .cpu-usage-view > .details {
border-left: var(--cpu-usage-view-details-border-end);
}

.cpu-usage-view > .details > .name {
@@ -40,7 +40,16 @@
color: var(--text-color-secondary);
overflow: hidden;
text-overflow: ellipsis;
-webkit-border-end: 1px solid var(--border-color);

--memory-category-view-details-border-end: 1px solid var(--border-color);
}

body[dir=ltr] .memory-category-view > .details {
border-right: var(--memory-category-view-details-border-end);
}

body[dir=rtl] .memory-category-view > .details {
border-left: var(--memory-category-view-details-border-end);
}

.memory-category-view > .details > .name {

0 comments on commit 527e8f0

Please sign in to comment.