This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
2010-12-17 Carol Szabo <email@example.com>
Reviewed by Darin Adler. A corrupted counter tree is created when renderers are added to the tree bypassing RenderObject::addChild https://bugs.webkit.org/show_bug.cgi?id=51270 This patch replaces the hack introduced for fixing bug 43812 with code that addresses the underlying problem for that bug. No new layout tests provided as there is no identified scenario when visible behavior would be different, the internal datastructures are maintained properly through this fix so the previous hack introduced for bug 43812 is now removed. The fact that the layout test introduced for 43812 continues to pass is proof that the code works. * rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Removed hack. * rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): Moved call to counter nodes updater to lower level functions to avoid bypass. * rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode): Changed to update the values of the counters that may be inserted in the tree. Canonical link: https://commits.webkit.org/64634@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing 4 changed files with 32 additions and 6 deletions.