Skip to content
Permalink
Browse files
RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uin…
…t32_t

https://bugs.webkit.org/show_bug.cgi?id=234657

Reviewed by Don Olmstead.

connectionID a parameter of ScriptMessageClient::didPostMessage() is casteed as <int>.
Since ConnectionID is define as uint32_t, it should be casted as <uint32_t>.

* UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp: Fixed cast for connectionID.



Canonical link: https://commits.webkit.org/245585@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ykimot committed Dec 26, 2021
1 parent 4a9f942 commit 54034c3e95ef222d4c8e73d05a39e8dc73848421
Showing 2 changed files with 13 additions and 1 deletion.
@@ -1,3 +1,15 @@
2021-12-26 Yousuke Kimoto <Yousuke.Kimoto@sony.com>

RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t
https://bugs.webkit.org/show_bug.cgi?id=234657

Reviewed by Don Olmstead.

connectionID a parameter of ScriptMessageClient::didPostMessage() is casteed as <int>.
Since ConnectionID is define as uint32_t, it should be casted as <uint32_t>.

* UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp: Fixed cast for connectionID.

2021-12-25 Commit Queue <commit-queue@webkit.org>

Unreviewed, reverting r285088.
@@ -60,7 +60,7 @@ class ScriptMessageClient final : public WebScriptMessageHandler::Client {
return;

URL requestURL { { }, page.pageLoadState().url() };
m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<int>(tokens[0]).value_or(0), parseInteger<int>(tokens[1]).value_or(0), tokens[2]);
m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<uint32_t>(tokens[0]).value_or(0), parseInteger<uint32_t>(tokens[1]).value_or(0), tokens[2]);
}

bool supportsAsyncReply() override

0 comments on commit 54034c3

Please sign in to comment.