DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]

https://bugs.webkit.org/show_bug.cgi?id=178366 Reviewed by Youenn Fablet. Source/WebCore: DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]. We attempted to do so using JSDOMQuad::visitAdditionalChildren() but the code did not work because we failed to generate a "isReachableFromOpaqueRoots()" function for JSDOMPoint. Test: fast/css/DOMQuad-points-SameObject.html * dom/DOMPoint.idl: LayoutTests: Add layout test coverage. * fast/css/DOMQuad-points-SameObject.html: Added. Canonical link: https://commits.webkit.org/194590@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Oct 17, 2017 · 541d5f5 · 541d5f5
1 parent bc5fa43
commit 541d5f5
Show file tree

Hide file tree

Showing 4 changed files with 65 additions and 0 deletions.
diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2017-10-16  Chris Dumez  <cdumez@apple.com>
+
+        DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
+        https://bugs.webkit.org/show_bug.cgi?id=178366
+
+        Reviewed by Youenn Fablet.
+
+        Add layout test coverage.
+
+        * fast/css/DOMQuad-points-SameObject.html: Added.
+
 2017-10-16  Andy Estes  <aestes@apple.com>
 
         [Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact and ApplePayError

diff --git a/LayoutTests/fast/css/DOMQuad-points-SameObject.html b/LayoutTests/fast/css/DOMQuad-points-SameObject.html
@@ -0,0 +1,39 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test.js"></script>
+<script>
+description("Tests that DOMQuad.p1 / p2 / p3 / p4 is [SameObject].");
+jsTestIsAsync = true;
+
+let quad = new DOMQuad();
+quad.p1.foo = 1;
+quad.p2.foo = 2;
+quad.p3.foo = 3;
+quad.p4.foo = 4;
+
+shouldBe("quad.p1.foo", "1");
+shouldBe("quad.p2.foo", "2");
+shouldBe("quad.p3.foo", "3");
+shouldBe("quad.p4.foo", "4");
+
+gc();
+
+shouldBe("quad.p1.foo", "1");
+shouldBe("quad.p2.foo", "2");
+shouldBe("quad.p3.foo", "3");
+shouldBe("quad.p4.foo", "4");
+
+setTimeout(function() {
+    gc();
+
+    shouldBe("quad.p1.foo", "1");
+    shouldBe("quad.p2.foo", "2");
+    shouldBe("quad.p3.foo", "3");
+    shouldBe("quad.p4.foo", "4");
+
+    finishJSTest();
+}, 0);
+</script>
+</body>
+</html>
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2017-10-16  Chris Dumez  <cdumez@apple.com>
+
+        DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]
+        https://bugs.webkit.org/show_bug.cgi?id=178366
+
+        Reviewed by Youenn Fablet.
+
+        DOMQuad.p1 / p2 / p3 / p4 should behave as [SameObject]. We attempted to do so using JSDOMQuad::visitAdditionalChildren()
+        but the code did not work because we failed to generate a "isReachableFromOpaqueRoots()" function for JSDOMPoint.
+
+        Test: fast/css/DOMQuad-points-SameObject.html
+
+        * dom/DOMPoint.idl:
+
 2017-10-16  Andy Estes  <aestes@apple.com>
 
         [Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact and ApplePayError

diff --git a/Source/WebCore/dom/DOMPoint.idl b/Source/WebCore/dom/DOMPoint.idl
@@ -34,6 +34,7 @@
     Constructor(optional unrestricted double x = 0, optional unrestricted double y = 0,
         optional unrestricted double z = 0, optional unrestricted double w = 1),
     Exposed=(Window,Worker),
+    GenerateIsReachable=Impl,
     ImplementationLacksVTable
 ]
 interface DOMPoint : DOMPointReadOnly {