Skip to content
Permalink
Browse files
[git-webkit] Fail quickly for invalid bugzilla credentials
https://bugs.webkit.org/show_bug.cgi?id=240182
<rdar://problem/92879251>

Reviewed by Stephanie Lewis.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Check credentials before creating an issue, exit
program if issue creation fails.

Canonical link: https://commits.webkit.org/250454@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JonWBedard committed May 10, 2022
1 parent 141e11a commit 5562d2a516fad6100198601ebd4a33bb63dd7bfd
@@ -1,3 +1,17 @@
2022-05-10 Jonathan Bedard <jbedard@apple.com>

[git-webkit] Fail quickly for invalid bugzilla credentials
https://bugs.webkit.org/show_bug.cgi?id=240182
<rdar://problem/92879251>

Reviewed by Stephanie Lewis.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Check credentials before creating an issue, exit
program if issue creation fails.

2022-05-10 Jonathan Bedard <jbedard@apple.com>

Patch is merged via merge-queue, but bugzilla is not closed
@@ -29,7 +29,7 @@ def readme():

setup(
name='webkitscmpy',
version='4.14.0',
version='4.14.1',
description='Library designed to interact with git and svn repositories.',
long_description=readme(),
classifiers=[
@@ -46,7 +46,7 @@ def _maybe_add_webkitcorepy_path():
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url <package index URL>`"
)

version = Version(4, 14, 0)
version = Version(4, 14, 1)

AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
AutoInstall.register(Package('jinja2', Version(2, 11, 3)))
@@ -118,10 +118,15 @@ def main(cls, args, repository, why=None, redact=False, **kwargs):

if not issue and Tracker.instance():
if ' ' in args.issue:
if getattr(Tracker.instance(), 'credentials'):
Tracker.instance().credentials(required=True, validate=True)
issue = Tracker.instance().create(
title=args.issue,
description=Terminal.input('Issue description: '),
)
if not issue:
sys.stderr.write('Failed to create new issue\n')
return 1
print("Created '{}'".format(issue))
if issue and issue.title and not redact:
args.issue = cls.to_branch_name(issue.title)

0 comments on commit 5562d2a

Please sign in to comment.