Skip to content
Permalink
Browse files
[GStreamer][MSE] Pausing video sometimes causes skip to finish
https://bugs.webkit.org/show_bug.cgi?id=197355

Reviewed by Philippe Normand.

Covered by existing tests.

* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
Assuming that when m_eosPending is on and we're paused() that the
network resource is fully loaded and the end is reached is clearly
wrong. Whether this is now correct is unclear...


Canonical link: https://commits.webkit.org/213116@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
charlie-ht committed Jun 24, 2019
1 parent ae18788 commit 58cc55c9ea2233a1805be77ff41a4a5154a277f4
Showing with 16 additions and 1 deletion.
  1. +15 −0 Source/WebCore/ChangeLog
  2. +1 −1 Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
@@ -1,3 +1,18 @@
2019-06-24 Charlie Turner <cturner@igalia.com>

[GStreamer][MSE] Pausing video sometimes causes skip to finish
https://bugs.webkit.org/show_bug.cgi?id=197355

Reviewed by Philippe Normand.

Covered by existing tests.

* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
Assuming that when m_eosPending is on and we're paused() that the
network resource is fully loaded and the end is reached is clearly
wrong. Whether this is now correct is unclear...

2019-06-24 Charlie Turner <cturner@igalia.com>

[GStreamer] Volume level sometimes changes inappropriately
@@ -758,7 +758,7 @@ MediaTime MediaPlayerPrivateGStreamerMSE::currentMediaTime() const
{
MediaTime position = MediaPlayerPrivateGStreamer::currentMediaTime();

if (m_eosPending && (paused() || (position >= durationMediaTime()))) {
if (m_eosPending && position >= durationMediaTime()) {
if (m_networkState != MediaPlayer::Loaded) {
m_networkState = MediaPlayer::Loaded;
m_player->networkStateChanged();

0 comments on commit 58cc55c

Please sign in to comment.