Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
WKWebView with no WKNavigationDelegate does not follow universal links
<rdar://problem/24374110> https://bugs.webkit.org/show_bug.cgi?id=158997 Reviewed by Dan Bernstein. Source/WebKit2: API Test: WKWebView.DefaultNavigationDelegate * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): When initializing the WKWebView, set a default navigation client. Tools: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added. Add a new test that shows that we have a default navigation delegate by swizzling -[NSWorkspace openURL:]. This will only be called if there is a default client. Canonical link: https://commits.webkit.org/177096@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
93 additions
and 0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Copyright (C) 2016 Apple Inc. All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions | ||
| * are met: | ||
| * 1. Redistributions of source code must retain the above copyright | ||
| * notice, this list of conditions and the following disclaimer. | ||
| * 2. Redistributions in binary form must reproduce the above copyright | ||
| * notice, this list of conditions and the following disclaimer in the | ||
| * documentation and/or other materials provided with the distribution. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
| * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
| * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS | ||
| * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF | ||
| * THE POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
|
|
||
| #import "config.h" | ||
|
|
||
| #if WK_API_ENABLED | ||
| #if PLATFORM(MAC) | ||
|
|
||
| #import "InstanceMethodSwizzler.h" | ||
| #import "PlatformUtilities.h" | ||
| #import "Test.h" | ||
| #import <WebKit/WKWebView.h> | ||
|
|
||
| static NSString *nonHTTPURLString = @"notreal:/hello"; | ||
|
|
||
| static bool isDone; | ||
|
|
||
| static void newOpenURL(id self, SEL _cmd, NSURL* value) | ||
| { | ||
| EXPECT_WK_STREQ(nonHTTPURLString, [value absoluteString]); | ||
| isDone = true; | ||
| } | ||
|
|
||
| TEST(WKWebView, DefaultNavigationDelegate) | ||
| { | ||
| TestWebKitAPI::InstanceMethodSwizzler swizzle([NSWorkspace class], @selector(openURL:), reinterpret_cast<IMP>(newOpenURL)); | ||
|
|
||
| WKWebView *webView = [[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]; | ||
|
|
||
| NSURLRequest *request = [NSURLRequest requestWithURL:[NSURL URLWithString:@"notreal:/hello"]]; | ||
| [webView loadRequest:request]; | ||
|
|
||
| TestWebKitAPI::Util::run(&isDone); | ||
| } | ||
|
|
||
| #endif | ||
| #endif |