Skip to content
Permalink
Browse files
[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-ve…
…rtical appearance values internal

https://bugs.webkit.org/show_bug.cgi?id=240448

Reviewed by Antti Koivisto.

Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html

iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it.

LayoutTests:

* fast/forms/range/thumbslider-crash-expected.txt: Removed.
* fast/forms/range/thumbslider-crash.html: Removed.
* fast/forms/range/thumbslider-no-parent-slider.html: Removed.
* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.
* platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Source/WebCore:

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* platform/ThemeTypes.h:

Canonical link: https://commits.webkit.org/250584@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
nt1m committed May 16, 2022
1 parent 6e7d7b2 commit 59325cece209b5aeca74be983fefd8e342a46ad0
Showing 19 changed files with 64 additions and 456 deletions.
@@ -1,3 +1,25 @@
2022-05-16 Tim Nguyen <ntim@apple.com>

[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
https://bugs.webkit.org/show_bug.cgi?id=240448

Reviewed by Antti Koivisto.

iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it.

* fast/forms/range/thumbslider-crash-expected.txt: Removed.
* fast/forms/range/thumbslider-crash.html: Removed.
* fast/forms/range/thumbslider-no-parent-slider.html: Removed.
* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.
* platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.

2022-05-16 Martin Robinson <mrobinson@webkit.org>

Do not allow unitless values for CSS unprefixed perspective property

This file was deleted.

This file was deleted.

This file was deleted.

@@ -1,3 +1,12 @@
2022-05-16 Tim Nguyen <ntim@apple.com>

[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
https://bugs.webkit.org/show_bug.cgi?id=240448

Reviewed by Antti Koivisto.

* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

2022-05-16 Martin Robinson <mrobinson@webkit.org>

Do not allow unitless values for CSS unprefixed perspective property
@@ -37,7 +37,7 @@ FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equa
PASS -webkit-appearance: dualbutton (invalid)
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
PASS -webkit-appearance: inner-spin-button (invalid)
PASS -webkit-appearance: list-button (invalid)
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
@@ -114,8 +114,8 @@ PASS -webkit-appearance: searchfield-results-decoration (invalid)
PASS -webkit-appearance: separator (invalid)
PASS -webkit-appearance: sheet (invalid)
FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
FAIL -webkit-appearance: sliderthumb-horizontal (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-horizontal"
FAIL -webkit-appearance: sliderthumb-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-vertical"
PASS -webkit-appearance: sliderthumb-horizontal (invalid)
PASS -webkit-appearance: sliderthumb-vertical (invalid)
PASS -webkit-appearance: snapshotted-plugin-overlay (invalid)
PASS -webkit-appearance: spinner (invalid)
PASS -webkit-appearance: spinner-downbutton (invalid)
@@ -200,7 +200,7 @@ FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: styl
PASS appearance: dualbutton (invalid)
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
PASS appearance: inner-spin-button (invalid)
PASS appearance: list-button (invalid)
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
@@ -277,8 +277,8 @@ PASS appearance: searchfield-results-decoration (invalid)
PASS appearance: separator (invalid)
PASS appearance: sheet (invalid)
FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
FAIL appearance: sliderthumb-horizontal (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-horizontal"
FAIL appearance: sliderthumb-vertical (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-vertical"
PASS appearance: sliderthumb-horizontal (invalid)
PASS appearance: sliderthumb-vertical (invalid)
PASS appearance: snapshotted-plugin-overlay (invalid)
PASS appearance: spinner (invalid)
PASS appearance: spinner-downbutton (invalid)
Deleted file not rendered

This file was deleted.

@@ -37,7 +37,7 @@ FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equa
PASS -webkit-appearance: dualbutton (invalid)
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
PASS -webkit-appearance: inner-spin-button (invalid)
PASS -webkit-appearance: list-button (invalid)
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
@@ -114,8 +114,8 @@ PASS -webkit-appearance: searchfield-results-decoration (invalid)
PASS -webkit-appearance: separator (invalid)
PASS -webkit-appearance: sheet (invalid)
FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
FAIL -webkit-appearance: sliderthumb-horizontal (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-horizontal"
FAIL -webkit-appearance: sliderthumb-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-vertical"
PASS -webkit-appearance: sliderthumb-horizontal (invalid)
PASS -webkit-appearance: sliderthumb-vertical (invalid)
PASS -webkit-appearance: snapshotted-plugin-overlay (invalid)
PASS -webkit-appearance: spinner (invalid)
PASS -webkit-appearance: spinner-downbutton (invalid)
@@ -200,7 +200,7 @@ FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: styl
PASS appearance: dualbutton (invalid)
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
PASS appearance: inner-spin-button (invalid)
PASS appearance: list-button (invalid)
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
@@ -277,8 +277,8 @@ PASS appearance: searchfield-results-decoration (invalid)
PASS appearance: separator (invalid)
PASS appearance: sheet (invalid)
FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
FAIL appearance: sliderthumb-horizontal (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-horizontal"
FAIL appearance: sliderthumb-vertical (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-vertical"
PASS appearance: sliderthumb-horizontal (invalid)
PASS appearance: sliderthumb-vertical (invalid)
PASS appearance: snapshotted-plugin-overlay (invalid)
PASS appearance: spinner (invalid)
PASS appearance: spinner-downbutton (invalid)

0 comments on commit 59325ce

Please sign in to comment.