Skip to content
Permalink
Browse files
Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=197326

Unreviewed test gardening.


LayoutTests/imported/w3c:

* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html:
* web-platform-tests/css/css-text/overflow-wrap/w3c-import.log:
* web-platform-tests/css/css-text/parsing/text-transform-valid.html:
* web-platform-tests/css/css-text/parsing/word-break-invalid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-invalid.html:
* web-platform-tests/css/css-text/parsing/word-break-valid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-valid.html:
* web-platform-tests/css/css-text/text-transform/w3c-import.log:
* web-platform-tests/css/css-text/white-space/break-spaces-003-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-003.html:
* web-platform-tests/css/css-text/white-space/break-spaces-004.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008-expected.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-015.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-016.html:
* web-platform-tests/css/css-text/white-space/textarea-break-spaces-001-expected.html:
* web-platform-tests/css/css-text/white-space/w3c-import.log:

LayoutTests:

* TestExpectations:
  - The break-spaces-008.html fails due to bug 197277


Canonical link: https://commits.webkit.org/211560@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
javifernandez committed Apr 29, 2019
1 parent ecfa6b1 commit 5940ad81c9f585e7c7da9e784e618aad178afa51
Showing 31 changed files with 100 additions and 40 deletions.
@@ -1,3 +1,13 @@
2019-04-29 Javier Fernandez <jfernandez@igalia.com>

Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=197326

Unreviewed test gardening.

* TestExpectations:
- The break-spaces-008.html fails due to bug 197277

2019-04-26 Youenn Fablet <youenn@apple.com>

Use normal loading path for ping loads
@@ -1971,6 +1971,8 @@ webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/o
webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-004.html [ Skip ]
webkit.org/b/195345 imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-word-overflow-wrap-interactions.html [ Skip ]

webkit.org/b/197277 imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-008.html [ ImageOnlyFailure ]


########################################
### START OF display: contents failures
@@ -1,3 +1,38 @@
2019-04-29 Javier Fernandez <jfernandez@igalia.com>

Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=197326

Unreviewed test gardening.

* web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html:
* web-platform-tests/css/css-text/overflow-wrap/w3c-import.log:
* web-platform-tests/css/css-text/parsing/text-transform-valid.html:
* web-platform-tests/css/css-text/parsing/word-break-invalid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-invalid.html:
* web-platform-tests/css/css-text/parsing/word-break-valid-expected.txt:
* web-platform-tests/css/css-text/parsing/word-break-valid.html:
* web-platform-tests/css/css-text/text-transform/w3c-import.log:
* web-platform-tests/css/css-text/white-space/break-spaces-003-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-003.html:
* web-platform-tests/css/css-text/white-space/break-spaces-004.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-005.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-006.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-007.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-008.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009-expected.html:
* web-platform-tests/css/css-text/white-space/break-spaces-009.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008-expected.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-008.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-015.html:
* web-platform-tests/css/css-text/white-space/pre-wrap-016.html:
* web-platform-tests/css/css-text/white-space/textarea-break-spaces-001-expected.html:
* web-platform-tests/css/css-text/white-space/w3c-import.log:

2019-04-28 Youenn Fablet <youenn@apple.com>

Fix imported/w3c/web-platform-tests/fetch/api/request/request-keepalive.html assert_throws call
@@ -3,15 +3,16 @@
<title>CSS Text Test: overflow-wrap: break-word</title>
<link rel="author" title="Javier Fernandez Garcia-Boente" href="mailto:jfernandez@igalia.com">
<link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-overflow-wrap-break-word">
<link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
<link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-pre-wrap">
<meta name="flags" content="ahem">
<link rel="match" href="reference/overflow-wrap-break-word-001-ref.html">
<meta name="assert" content="A Single leading white-space constitutes a soft breaking opportunity, honoring the 'white-space: break-spaces' property, that must prevent the word to be broken.">
<meta name="assert" content="A Single leading white-space constitutes a soft breaking opportunity, honoring the 'white-space: pre-wrap' property, that must prevent the word to be broken.">
<style>
div {
position: relative;
font-size: 20px;
font-family: Ahem;
position: relative;
font-size: 20px;
font-family: Ahem;
line-height: 1em;
}
.red {
position: absolute;
@@ -24,7 +25,6 @@
}
.test {
color: green;
line-height: 1em;
width: 5ch;

white-space: pre-wrap;
@@ -56,6 +56,10 @@ List of files:
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-span-001-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-span-001.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-span-002.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-cluster-001-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-cluster-001.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-cluster-002-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-cluster-002.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-001-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-001.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-002-expected.html
@@ -64,6 +68,8 @@ List of files:
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-003.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-004-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-min-content-size-004.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-normal-keep-all-001-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-normal-keep-all-001.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/word-wrap-001-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/word-wrap-001.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/word-wrap-002-expected.html
@@ -22,16 +22,20 @@
test_valid_value("text-transform", "capitalize full-width");
test_valid_value("text-transform", "uppercase full-size-kana");
test_valid_value("text-transform", "full-width full-size-kana");
test_valid_value("text-transform", "full-width lowercase");
test_valid_value("text-transform", "full-size-kana capitalize");
test_valid_value("text-transform", "full-size-kana full-width");

// serialization canonicalizes the order of values: https://drafts.csswg.org/cssom/#serialize-a-css-value
test_valid_value("text-transform", "full-width lowercase", "lowercase full-width");
test_valid_value("text-transform", "full-size-kana capitalize", "capitalize full-size-kana");
test_valid_value("text-transform", "full-size-kana full-width", "full-width full-size-kana");

test_valid_value("text-transform", "capitalize full-width full-size-kana");
test_valid_value("text-transform", "full-width full-size-kana uppercase");
test_valid_value("text-transform", "full-size-kana lowercase full-width");
test_valid_value("text-transform", "lowercase full-size-kana full-width");
test_valid_value("text-transform", "full-width uppercase full-size-kana");
test_valid_value("text-transform", "full-size-kana full-width capitalize");

// serialization canonicalizes the order of values
test_valid_value("text-transform", "full-width full-size-kana uppercase", "uppercase full-width full-size-kana");
test_valid_value("text-transform", "full-size-kana lowercase full-width", "lowercase full-width full-size-kana");
test_valid_value("text-transform", "lowercase full-size-kana full-width", "lowercase full-width full-size-kana");
test_valid_value("text-transform", "full-width uppercase full-size-kana", "uppercase full-width full-size-kana");
test_valid_value("text-transform", "full-size-kana full-width capitalize", "capitalize full-width full-size-kana");
</script>
</body>
</html>
@@ -2,4 +2,9 @@
PASS e.style['word-break'] = "auto" should not set the property value
PASS e.style['word-break'] = "normal keep-all" should not set the property value
PASS e.style['word-break'] = "break-all break-all" should not set the property value
PASS e.style['word-break'] = "normal break-word" should not set the property value
PASS e.style['word-break'] = "break-word normal" should not set the property value
PASS e.style['word-break'] = "keep-all break-word" should not set the property value
PASS e.style['word-break'] = "break-all break-word" should not set the property value
PASS e.style['word-break'] = "word-break" should not set the property value

@@ -4,7 +4,7 @@
<meta charset="utf-8">
<title>CSS Text Module Test: parsing word-break with invalid values</title>
<link rel="help" href="https://www.w3.org/TR/css-text-3/#propdef-word-break">
<meta name="assert" content="word-break supports only the grammar 'normal | keep-all | break-all'.">
<meta name="assert" content="word-break supports only the grammar 'normal | keep-all | break-all | break-word'.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/parsing-testcommon.js"></script>
@@ -14,6 +14,11 @@
test_invalid_value("word-break", "auto");
test_invalid_value("word-break", "normal keep-all");
test_invalid_value("word-break", "break-all break-all");
test_invalid_value("word-break", "normal break-word");
test_invalid_value("word-break", "break-word normal");
test_invalid_value("word-break", "keep-all break-word");
test_invalid_value("word-break", "break-all break-word");
test_invalid_value("word-break", "word-break");
</script>
</body>
</html>
@@ -2,4 +2,5 @@
PASS e.style['word-break'] = "normal" should set the property value
PASS e.style['word-break'] = "keep-all" should set the property value
PASS e.style['word-break'] = "break-all" should set the property value
PASS e.style['word-break'] = "break-word" should set the property value

@@ -4,7 +4,7 @@
<meta charset="utf-8">
<title>CSS Text Module Test: parsing word-break with valid values</title>
<link rel="help" href="https://www.w3.org/TR/css-text-3/#propdef-word-break">
<meta name="assert" content="word-break supports the full grammar 'normal | keep-all | break-all'.">
<meta name="assert" content="word-break supports the full grammar 'normal | keep-all | break-all | break-word'.">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/parsing-testcommon.js"></script>
@@ -14,6 +14,7 @@
test_valid_value("word-break", "normal");
test_valid_value("word-break", "keep-all");
test_valid_value("word-break", "break-all");
test_valid_value("word-break", "break-word");
</script>
</body>
</html>
@@ -78,6 +78,8 @@ List of files:
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-lowercase-001.xht
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-lowercase-002-expected.xht
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-lowercase-002.xht
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-multiple-001-expected.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-multiple-001.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-none-001-expected.xht
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-none-001.xht
/LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-shaping-001-expected.html
@@ -4,7 +4,6 @@
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
<style>
div {
position: relative;
width: 100px;
height: 100px;
background: green;
@@ -7,11 +7,12 @@
<link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces">
<link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-word">
<meta name="flags" content="ahem">
<link rel="match" href="reference/pre-wrap-001-ref.html">
<meta name="assert" content="The word is not broken if there are previous breaking opportunities, honoring the 'white-space: break-spaces' value.">
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="assert" content="break-word + break-spaces do not allow a break
between the last character of a word and the first space of a sequence of preserved spaces
if there are other wrapping opportunities earlier in the line.">
<style>
div {
position: relative;
font: 25px/1 Ahem;
}
.fail {
@@ -11,7 +11,6 @@
<meta name="assert" content="The word is not broken if there are previous breaking opportunities, honoring the 'white-space: break-spaces' value.">
<style>
div {
position: relative;
font: 20px/1 Ahem;
}
.fail {
@@ -4,7 +4,6 @@
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
<style>
div {
position: relative;
width: 100px;
height: 100px;
background: green;
@@ -9,7 +9,6 @@
<meta name="assert" content="If 'white-space' is set to 'break-spaces', collapsing preserved white-spaces' advance width is not allowed, so that they can be wrapped honoring the 'white-space' propery.">
<style>
div {
position: relative;
font: 10px/1 Ahem;
}
.fail {
@@ -4,7 +4,6 @@
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
<style>
div {
position: relative;
width: 100px;
height: 100px;
background: green;
@@ -11,7 +11,6 @@
<meta name="assert" content="White spaces are preserved, honoring the 'white-space: break-spaces', but the words are broken, honring the 'word-beak: break-all' even though there are previous breaking opportunities in the white-spaces.">
<style>
div {
position: relative;
font: 25px/1 Ahem;
}
.fail {
@@ -4,7 +4,6 @@
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
<style>
div {
position: relative;
width: 100px;
height: 100px;
background: green;
@@ -8,10 +8,9 @@
<link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="flags" content="ahem">
<meta name="assert" content="A single leading white-space should be used, honoring white-space: break-spaces, to avoid overflow; however, a single preserved white-space at the end of the line cannot be wrapped, hence it hangs when breaking after it to move the rest of the text to the next line.">
<meta name="assert" content="A single leading white-space should be used, honoring white-space: break-spaces, to avoid overflow; however, a single preserved white-space at the end of the line cannot be wrapped, hence it overflows when breaking after it to move the rest of the text to the next line.">
<style>
div {
position: relative;
font: 25px/1 Ahem;
}
.fail {
@@ -4,7 +4,6 @@
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
<style>
div {
position: relative;
width: 100px;
height: 100px;
background: green;
@@ -8,10 +8,9 @@
<link rel="help" href="https://drafts.csswg.org/css-text-3/#valdef-word-break-break-all">
<link rel="match" href="reference/white-space-break-spaces-005-ref.html">
<meta name="flags" content="ahem">
<meta name="assert" content="White spaces are preserved, honoring the 'white-space: break-spaces', which may lead to overfow. However, we can break before the first white-space after the word honoring the 'break-all' value.">
<meta name="assert" content="White spaces are preserved, honoring the 'white-space: break-spaces', which may lead to overfow. However, we can break before the las letter in the word honoring the 'break-all' value.">
<style>
div {
position: relative;
font: 25px/1 Ahem;
}
.fail {
@@ -30,6 +29,6 @@
</style>
<body>
<p>Test passes if there is a <strong>filled green square</strong> and <strong>no red</strong>.</p>
<div class="fail">XXXX<br><span>X</span>XX<span>X</span><br><span>XXXX</span><br><span>XXXX</span></div>
<div class="fail">XXX<span>X</span><br>X<span>X</span>XX<br><span>XXXX</span><br><span>XXXX</span></div>
<div class="test">XXXX XX</div>
</body>
@@ -4,7 +4,6 @@
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
<style>
div {
position: relative;
width: 100px;
height: 100px;
background: green;
@@ -13,7 +13,6 @@
if there are no other wrapping opportunities earlier in the line">
<style>
div {
position: relative;
font: 25px/1 Ahem;
}
.red {
@@ -27,7 +26,6 @@
background: green;
color: red;
width: 4ch;
z-index: -1;

white-space: break-spaces;
word-break: break-word;
@@ -4,7 +4,6 @@
<link rel="author" title="Javier Fernandez" href="mailto:jfernandez@igalia.com" />
<style>
div {
position: relative;
width: 100px;
height: 100px;
background: green;
@@ -9,7 +9,6 @@
<meta name="assert" content="The word is not broken despite the 'word-break: break-word' if there are previous breaking opportunities, honoring the white-space: pre-wrap value.">
<style>
div {
position: relative;
font-size: 20px;
font-family: Ahem;
}
@@ -9,7 +9,6 @@
<meta name="assert" content="The text is broken at the end of the space between the two words, never before, so it hangs and cause an overflow">
<style>
div {
position: relative;
font: 20px/1 Ahem;
}
.ref {
@@ -9,7 +9,6 @@
<meta name="assert" content="The word is not broken if there are previous breaking opportunities, honoring the white-space: pre-wrap value.">
<style>
div {
position: relative;
font-size: 20px;
font-family: Ahem;
line-height: 1em;
@@ -14,7 +14,6 @@
word-break: initial;
margin: 0;
padding: 0;
border-radius: 0px;
border: none;
outline: none;
resize: none;

0 comments on commit 5940ad8

Please sign in to comment.