Skip to content
Permalink
Browse files
Removing some check-webkit-style warnings from ./dfg
https://bugs.webkit.org/show_bug.cgi?id=132854

Patch by Tanay C <tanay.c@samsung.com> on 2014-05-19
Reviewed by Darin Adler.

* dfg/DFGAbstractInterpreter.h:
* dfg/DFGAbstractValue.h:
* dfg/DFGBlockInsertionSet.h:
* dfg/DFGCommonData.h:
* dfg/DFGDominators.h:
* dfg/DFGGraph.h:
* dfg/DFGInPlaceAbstractState.h:
* dfg/DFGPredictionPropagationPhase.h:

Canonical link: https://commits.webkit.org/151090@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Tanay C authored and webkit-commit-queue committed May 19, 2014
1 parent 025faee commit 5984f8ce81aabde2a41c2d12b53421a00c33c817
Showing 9 changed files with 31 additions and 15 deletions.
@@ -1,3 +1,19 @@
2014-05-19 Tanay C <tanay.c@samsung.com>

Removing some check-webkit-style warnings from ./dfg
https://bugs.webkit.org/show_bug.cgi?id=132854

Reviewed by Darin Adler.

* dfg/DFGAbstractInterpreter.h:
* dfg/DFGAbstractValue.h:
* dfg/DFGBlockInsertionSet.h:
* dfg/DFGCommonData.h:
* dfg/DFGDominators.h:
* dfg/DFGGraph.h:
* dfg/DFGInPlaceAbstractState.h:
* dfg/DFGPredictionPropagationPhase.h:

2014-05-18 Filip Pizlo <fpizlo@apple.com>

Unreviewed, remove bogus comment. We already made the FTL use our calling convention.
@@ -38,7 +38,7 @@ namespace JSC { namespace DFG {
template<typename AbstractStateType>
class AbstractInterpreter {
public:
AbstractInterpreter(Graph&, AbstractStateType& state);
AbstractInterpreter(Graph&, AbstractStateType&);
~AbstractInterpreter();

AbstractValue& forNode(Node* node)
@@ -200,11 +200,11 @@ struct AbstractValue {

FiltrationResult filter(Graph&, const StructureSet&);

FiltrationResult filterArrayModes(ArrayModes arrayModes);
FiltrationResult filterArrayModes(ArrayModes);

FiltrationResult filter(SpeculatedType type);
FiltrationResult filter(SpeculatedType);

FiltrationResult filterByValue(JSValue value);
FiltrationResult filterByValue(JSValue);

bool validate(JSValue value) const
{
@@ -397,7 +397,7 @@ struct AbstractValue {
checkConsistency();
}

void setFuturePossibleStructure(Graph&, Structure* structure);
void setFuturePossibleStructure(Graph&, Structure*);

void filterValueByType();
void filterArrayModesByType();
@@ -38,11 +38,11 @@ typedef WTF::Insertion<RefPtr<BasicBlock>> BlockInsertion;

class BlockInsertionSet {
public:
BlockInsertionSet(Graph& graph);
BlockInsertionSet(Graph&);
~BlockInsertionSet();

void insert(const BlockInsertion& insertion);
void insert(size_t index, PassRefPtr<BasicBlock> block);
void insert(const BlockInsertion&);
void insert(size_t index, PassRefPtr<BasicBlock>);
BasicBlock* insert(size_t index, float executionCount);
BasicBlock* insertBefore(BasicBlock* before, float executionCount);

@@ -78,7 +78,7 @@ class CommonData {
{ }

void notifyCompilingStructureTransition(Plan&, CodeBlock*, Node*);
unsigned addCodeOrigin(CodeOrigin codeOrigin);
unsigned addCodeOrigin(CodeOrigin);

void shrinkToFit();

@@ -42,7 +42,7 @@ class Dominators : public Analysis<Dominators> {
Dominators();
~Dominators();

void compute(Graph& graph);
void compute(Graph&);

bool dominates(BlockIndex from, BlockIndex to) const
{
@@ -55,7 +55,7 @@ class Dominators : public Analysis<Dominators> {
return dominates(from->index, to->index);
}

void dump(Graph& graph, PrintStream&) const;
void dump(Graph&, PrintStream&) const;

private:
bool pruneDominators(Graph&, BlockIndex);
@@ -180,15 +180,15 @@ class Graph : public virtual Scannable {
// CodeBlock is optional, but may allow additional information to be dumped (e.g. Identifier names).
void dump(PrintStream& = WTF::dataFile(), DumpContext* = 0);
enum PhiNodeDumpMode { DumpLivePhisOnly, DumpAllPhis };
void dumpBlockHeader(PrintStream&, const char* prefix, BasicBlock*, PhiNodeDumpMode, DumpContext* context);
void dumpBlockHeader(PrintStream&, const char* prefix, BasicBlock*, PhiNodeDumpMode, DumpContext*);
void dump(PrintStream&, Edge);
void dump(PrintStream&, const char* prefix, Node*, DumpContext* = 0);
static int amountOfNodeWhiteSpace(Node*);
static void printNodeWhiteSpace(PrintStream&, Node*);

// Dump the code origin of the given node as a diff from the code origin of the
// preceding node. Returns true if anything was printed.
bool dumpCodeOrigin(PrintStream&, const char* prefix, Node* previousNode, Node* currentNode, DumpContext* context);
bool dumpCodeOrigin(PrintStream&, const char* prefix, Node* previousNode, Node* currentNode, DumpContext*);

SpeculatedType getJSConstantSpeculation(Node* node)
{
@@ -38,7 +38,7 @@ namespace JSC { namespace DFG {

class InPlaceAbstractState {
public:
InPlaceAbstractState(Graph& graph);
InPlaceAbstractState(Graph&);

~InPlaceAbstractState();

@@ -46,7 +46,7 @@ class Graph;
bool performPredictionPropagation(Graph&);

// Helper used for FixupPhase for computing the predicted type of a ToPrimitive.
SpeculatedType resultOfToPrimitive(SpeculatedType type);
SpeculatedType resultOfToPrimitive(SpeculatedType);

} } // namespace JSC::DFG::Phase

0 comments on commit 5984f8c

Please sign in to comment.